Improve behavior when entering value without closing dialog

[naoliv]

It's strange to add a tag to an object (via Ctrl+A), press Shift+Enter (to enter more values) and still see the same value at the key and value.
Wouldn't it be better to clean the fields, since the inserted values are already present at the current objects?

[simon04]

In 8234/josm:

fix #11354 - Add tags: clear input fields after adding tag without closing dialog

[naoliv]

It's broken now.
Select one way, add highway=residential with Shift+Enter, the fields get cleared and then press Esc to quit the dialog (without adding other tags). Note how the way has no tags.
Tested with r8236

[simon04]

This is the same behaviour as before. But I agree, that it might be unwanted. See ticket:8024#comment:12 where this was added …

[naoliv]

Couldn't Cancel just close the dialog, without undoing everything?

[simon04]

Technically yes, but we should clarify which behaviour is expected. Two years ago, the current behaviour was implemented intentionally. I'm fine with both variants (mostly, since I had discovered this feature just recently and haven't used it much).

[stoecker]

Replying to naoliv:

Couldn't Cancel just close the dialog, without undoing everything?

Sounds not good to me. A operation cancel should reset the state to what was there before the dialog was called.

[skyper]

Replying to stoecker:

Replying to naoliv:

Couldn't Cancel just close the dialog, without undoing everything?

Sounds not good to me. A operation cancel should reset the state to what was there before the dialog was called.

+1

Adding multiple tags is a feature and it is still one action.

[naoliv]

Is it only me who closes the dialogs with the Esc key? :-/

[stoecker]

Use <ENTER> instead of aborting with <ESC>.