Imagery offset not updating the image

[naoliv]

Using Bing, clicking on Adjust imagery offset and then moving the layer with the left mouse button (or directly entering a value with the keyboard) isn't updating the layer.
If I move the layer with the right mouse button, it gets updated to the right place (the new position from the offset). If I change the zoom level it also updates. Pressing TAB in JOSM to hide/show the panel also updates it, but moving or entering a value (without doing things like this, to force an update of the map) isn't updating its position.

JOSM:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-04-18 01:31:13
Last Changed Author: simon04
Revision: 8212
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-04-18 02:23:03 +0200 (Sat, 18 Apr 2015)
Last Changed Rev: 8212

Identification: JOSM/1.5 (8212 en) Linux Debian GNU/Linux 8.0 (jessie)
Memory Usage: 247 MB / 4029 MB (165 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u79-2.5.5-1
VM arguments: [-Dawt.useSystemAAFontSettings=on]
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (30892)
- Create_grid_of_ways (30892)
- FastDraw (30892)
- FixAddresses (30892)
- OpeningHoursEditor (30962)
- PicLayer (30962)
- SimplifyArea (30962)
- buildings_tools (30955)
- download_along (30892)
- editgpx (30892)
- geotools (31068)
- graphview (30892)
- jts (31002)
- measurement (30892)
- merge-overlap (30988)
- opendata (31050)
- pdfimport (30892)
- poly (31056)
- reverter (30990)
- tagging-preset-tester (30892)
- todo (29154)
- turnrestrictions (31034)
- undelete (30892)
- utilsplugin2 (31072)

[Felis Pimeja]

Exactly the same problem on Windows 7. All the plugins are turned off. The problem started somewhere between snapshot r8167 (all is fine) and snapshot r8175 (the problem exists).

[Felis Pimeja]

Added an image to illustrate the misbehavior:

1. Start image ajust
2. Trying to drag Bing layer with left mouse button pressed and nothing happens
3. Trying to drag the viewport with right mouse button pressed - imagery reloads immediately. Same when zooming in-out with mouse wheel.

[naoliv]

Adding wiktorn back since it seems that he was removed unintentionally

[wiktorn]

Attached patch restores the setOffset method, which fixes the bug.

[stoecker]

In 8288/josm:

fix #11353 - imagery offset regression (patch by wiktorn)

[Don-vip]

Shouldn't we release a new stable as hotfix? It seems a major regression, no?

[naoliv]

Replying to Don-vip:

Shouldn't we release a new stable as hotfix? It seems a major regression, no?

If my "yes" count as something, then yes from me :-)

[stoecker]

There was only one report, so currently I see no hotfix reason :-) I assume most users do not use adjusting much.

[wiktorn]

Replying to stoecker:

There was only one report, so currently I see no hotfix reason :-) I assume most users do not use adjusting much.

That's a shame. Actually we do care a lot about properly adjusting the maps, so I'd vote for a hotfix release, just to stress, that's important for community.

[stoecker]

Replying to wiktorn:

Replying to stoecker:

There was only one report, so currently I see no hotfix reason :-) I assume most users do not use adjusting much.

That's a shame. Actually we do care a lot about properly adjusting the maps, so I'd vote for a hotfix release, just to stress, that's important for community.

It's not soooo easy. First I already did new changes and I'm not sure they are that stable. Then a release means still a lot of work even when reduced to the bare minimum (as ATM Vincent hasn't enough time for the other stuff). So if nobody complains I think "latest" will be enough for most users - there is always something wrong :-) Unless we get lots of complaints...

[aceman]

I have also noticed this bug. I use the offset tweaking daily.

[Don-vip]

Ok wait and see if we get more bug reports.

[algotua]

There was only one report, so currently I see no hotfix reason :-)

Many users complain on this bug in the forums and give link to this topic.
How it can be escalated if the problem is known?

[stoecker]

References?

[stoecker]

BTW - They simply can use latest instead of tested, there is no need to wait.

[Zverikk]

I'm for releasing a hotfix tested version. Adjusting an imagery layer offset is nearly impossible now. I don't struggle with it all the time, because for most locations using a stored imagery offset (via plugin) is enough. But this function is one of the major points why josm is better than id :)