New "Add key/value" dialog feature: Click on tag should apply it immediately

[flaimo]

I just tried out the ​feature I requested for the first time. As it is implemented now it doesn't actually save me any time, since a click just prefills the two input fields. the way i meant is was, that a click on one of the recently used tags (or pressing one of the keyboard shortcuts) applies the tag immediately and also closes the dialog. Also the tags should be underlined or else a user will never know that he can click the tags (usability problem).

[Don-vip]

That would close #8012 as well :)

[akks]

Maybe something like following would be convenient:

• Shift-Click = apply and close
• Ctrl-Click = add/delete tag without closing

[flaimo]

Actually "Apply and Close" should be the default without any modifier key. How big is the chance that is it necessary to review the tag after is has been copied to the two input fields. I would say probably near 0%.

[Don-vip]

I agree. And this makes the whole thing easier for us too :)

[tetsuo]

It would be convenient to be able adding more than one tag once!

• A double click to add apply and close.
• Simple click to add without closing, another simple click too add another tag - or the same - without closing ... a doucle click to add the last tag or click apply button to close.

I often add multiple tag to a bunch of node/way and the possibility to do this easily via recent tag list may be a really good enhancement. clicking ADD button on the top right of the screen is not handy.

Another way possible, editing tag/value directly in the property box available in the right pane.

[akks]

In 5636/josm:

see #8024: Recent tag list int Alt-A: Double-Click=apply and close, Shift-Click=apply and continue
TagEditHelper refactoring: please check that there is no regressions

[akks]

I have implemented Add&Close on double-click and "multiple add" on shift-click.

@team, @Don-vip: Please could you check that I did not break anything (some refactoring was done to separate code that we needed to extend)?

Do we need to add some message or tooltip for this extra behaviour?

[Don-vip]

I like the double-click behaviour, it's fine :)
Concerning the Shift-click, it works, but clicking on Cancel button should cancel all changes we made from this dialog.

[Don-vip]

Concerning the help message, we should not use a JOptionPane directly but a subclass of ExtendedDialog instead. This would allow to link a "Help" button and save the window geometry (asked in #8012).

[akks]

I am finishing rough Panel -> ExtendedDialog conversion. Position is remembered correctly. Maybe some extra code rework will be needed after commit.

[akks]

In 5642/josm:

see #8024: After adding recent tags by shift-click, Cancel can undo all operations.
Caution: new refactoring - now Add Tags and Edit Tags are ExtendedDialog subclasses

[akks]

Replying to Don-vip:

Concerning the help message, we should not use a JOptionPane directly but a subclass of ExtendedDialog instead. This would allow to link a "Help" button and save the window geometry (asked in #8012).

@Don-vip: by your advice, I transformed dialogs to ExtendedDialog subclasses and added Cancel behavour.

Problems are:

• saving position of the windows without saving its size, see #8012
• not so good-looking windows as before (please, can someone add margins or something like that?)
• do we need correctly added Help buttons in these dialogs?
• There are possible hard-to find regressions (focus, Linux middle-click, Tab order, etc.). I did not notice them, but they are possible.

For now I stop committing to let others make the code better without conflicts.

[Don-vip]

Neither the position or size of the dialog are remembered on my laptop (Ubuntu 12.10, gnome 3 classic). I'm looking at it.

The Help button is definitively needed with all these new keyboard shortcuts :)

[Don-vip]

In 5646/josm:

see #8024, fix #8012 - Remember position of add/edit tags dialog

[skyper]

Did this also effect "edit" ?

Anyway, on the "change value" dialog the value should be selected and not the key.

[skyper]

Replying to skyper:

Did this also effect "edit" ?

Anyway, on the "change value" dialog the value should be selected and not the key.

The same after simply clicking on an item from list.

[skyper]

Selecting a key from drop-down-list should should also change to value.

[skyper]

I wonder if we need two different dialogs (add tag <-> change value) or if it could work with one. E.g. double clicking on the property or the "edit" button opens the "add tag dialog" but prefilled with the previous chosen key-value-pair. I often have situations where I what to add some properties but also change one or two.

[akks]

In 5656/josm:

Patch by Don-Vip fix #8311: Should focus on the proper column when double-clicking to edit a key/value +
see #8024: focus on Value after Alt-E, focus on Key after Shift-Enter, recent tag Click or Shift-Click

[akks]

Replying to skyper:

I wonder if we need two different dialogs (add tag <-> change value) or if it could work with one. E.g. double clicking on the property or the "edit" button opens the "add tag dialog" but prefilled with the previous chosen key-value-pair. I often have situations where I what to add some properties but also change one or two.

You are right, now Add dialog can be used for editing values too. But it seems that Edit dialog have some differen logic - autocompletion and so on. Maybe some people are used to it.

Thank you for good ideas. Selecting key on Alt-E was a regression that I missed.

[akks]

@Don-vip: I have finished. You can add Help button or improve something else in these dialogs. It seems we are not not in stabilization phase :)

[skyper]

Replying to akks:

Replying to akks:

Replying to skyper:

In 5656/josm:

Patch by Don-Vip fix #8311: Should focus on the proper column when double-clicking to edit a key/value +
see #8024: focus on Value after Alt-E, focus on Key after Shift-Enter, recent tag Click or Shift-Click

Did not check the code but single Click on a recent tag from list should focus the value cause it is much more common to change the value instead of the key.

I wonder if we need two different dialogs (add tag <-> change value) or if it could work with one. E.g. double clicking on the property or the "edit" button opens the "add tag dialog" but prefilled with the previous chosen key-value-pair. I often have situations where I what to add some properties but also change one or two.

You are right, now Add dialog can be used for editing values too. But it seems that Edit dialog have some differen logic - autocompletion and so on. Maybe some people are used to it.

Did not realize much differences, so far.

Thank you for good ideas. Selecting key on Alt-E was a regression that I missed.

You are welcome. Thanks for coding.

[akks]

Replying to skyper:

Did not check the code but single Click on a recent tag from list should focus the value cause it is much more common to change the value instead of the key.

It works this way, commit comment is buggy.

[skyper]

Replying to akks:

Replying to skyper:

Did not check the code but single Click on a recent tag from list should focus the value cause it is much more common to change the value instead of the key.

It works this way, commit comment is buggy.

That's what I was hoping but I was not sure about it.

[skyper]

I did some update/clean-up on Help/Dialog/Properties? and created Help/Dialog/AddValue (still incomplete).
Gonna try to finish the next days but input/adds are always welcome.

On Help/Dialog/Properties? "key/value pairs" is often mentioned instead of tags but I am not sure what is better understandable.

[Don-vip]

In 5658/josm:

see #8024 - Add Help button to add/edit dialogs

[skyper]

This turns into a major enhancement. Thanks guys.

On little problem I have is the window border. My WM (metacity, gnome3) can not grab the edges nor sides to resize the window. Works with all other common dialogs (preferences, search, presets, upload ...) but not with "AddValue" nor "EditValue".

@akks:
Does this really belong to AddValue and not to EditValue which does not have a page, yet ?

[skyper]

Sorry one more shortcut:

Ctrl+Shift+<number> might be nice too.

[akks]

@akks:
Does this really belong to AddValue and not to EditValue which does not have a page, yet ?

Oops, I was too fast again. Reverted :)

Replying to skyper:

This turns into a major enhancement. Thanks guys.

On little problem I have is the window border. My WM (metacity, gnome3) can not grab the edges nor sides to resize the window. Works with all other common dialogs (preferences, search, presets, upload ...) but not with "AddValue" nor "EditValue".

Replying to skyper:

Sorry one more shortcut:
Ctrl+Shift+<number> might be nice too.

I'll se what I can do in near minutes...

[akks]

In 5659/josm:

see #8024: Ctrl-Shift-1..5 in Add Tag dialog = add and continue

[akks]

Last change was mechanical adding one more action.

As I can see, resizing was intentionally disabled by Don-vip, because Add dialog has variable size (recent tag list).
If the size will be remembered after resizing, half-empty dialog can pop-up next time.
Do you really need resizing and have ideas how we need to change this?

[skyper]

Replying to akks:

Last change was mechanical adding one more action.

Thanks.

As I can see, resizing was intentionally disabled by Don-vip, because Add dialog has variable size (recent tag list).
If the size will be remembered after resizing, half-empty dialog can pop-up next time.
Do you really need resizing

No, not really.

and have ideas how we need to change this?

I see, then it is the minimal size which could be a little bit wider or/and definable through preferences.

[Don-vip]

Yes, this is intentional. We had some troubles with layout while implementing recent tags (see #7671 comments), I don't want to break this by allowing the dialog to be resized.

However, margins remain to be added to have a look closer to the original JOptionPane. I think this is the only thing to do before closing this ticket :)

[akks]

Here is a margin-related patch. You can make it look better and commit :)
(and possibly add preferences for min size, which I can not manage)

[skyper]

Adding the third button helped a lot. No problem for me any longer.

[akks]

Can we close the ticket now?
(or we still need underlining?)