Modify

Opened 4 years ago

Closed 2 weeks ago

Last modified 12 days ago

#11168 closed defect (fixed)

undo fills in stuff which never was existing there - in the changeset comment

Reported by: aseerel4c26 Owned by: Don-vip
Priority: trivial Milestone: 19.04
Component: Core Version: latest
Keywords: undo upload comment Cc:

Description

  1. have previous uploads (so you have a upload comment history)
  2. set upload.comment.max-age = 0 (more info: see #9438), so the comment field is empty by default
  3. edit some data
  4. press the upload button (upload window appears)
  5. hit ctrl+z.

Expected: nothing, since I did not enter text in this field before, so there should be nothing to "undo".

Actual: the last changeset comment appears.

Note: this also happens if you enter any text and then Ctrl+Z and hold the keys, because you want to undo everything you've entered. Expected is that you get an empty field. Actual is that you land in some old comment.

In JOSM v. 8103 (although I guess that never was different). System: Linux, Java version: 1.8

Attachments (0)

Change History (5)

comment:1 Changed 3 weeks ago by Don-vip

Keywords: comment added

comment:2 Changed 3 weeks ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

comment:3 Changed 2 weeks ago by Don-vip

Milestone: 19.04

comment:4 Changed 2 weeks ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 14977/josm:

ensures consistency of upload comment:

  • fix #11168 - ctrl-z/undo could reset unwanted old changeset comment
  • fix #13474 - selecting "new changeset" after having entered a changeset comment did reset it to the previous value
  • fix #17452 - ctrl-enter while typing a changeset comment did upload with the previous value
  • fix behaviour of upload.comment.max-age: values were reset after 5 months instead of intended 4 hours because seconds were compared to milliseconds
  • avoid creation of unneeded undo/redo internal classes for non-editable text fields
  • ensures consistency of upload dialog if upload.comment properties are modified manually from advanced preferences
  • add a source attribute to preference events to know which class modified the preference entry
  • refactor reflection utils

comment:5 Changed 12 days ago by aseerel4c26

Thank you! Test case above works now. Tested with version 14986 openjdk 11.0.3. :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.