Opened 12 years ago
Closed 12 years ago
#9438 closed enhancement (fixed)
Option not to remember changeset comments or warn if it is unedited
Reported by: | Owned by: | team | |
---|---|---|---|
Priority: | normal | Milestone: | 14.01 |
Component: | Core | Version: | |
Keywords: | Cc: | maizzerna, stoecker |
Description
It would be useful to make the feature remembering the last changeset comment optional.
When you're doing unrelated one-off fixes, this is less useful and risks accidentally using an old comment. If it were empty for new changesets, there could also be a feature warning you about empty comments.
Attachments (0)
Change History (11)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
Summary: | Option not to remember changetset comments → Option not to remember changeset comments |
---|
comment:5 by , 12 years ago
Summary: | Option not to remember changeset comments → Option not to remember changeset comments or warn if it is unedited |
---|
comment:6 by , 12 years ago
Cc: | added |
---|
The max-age of 4h has been introduced r3399 with the comment "Also, the last recently used changeset comment is only used as a default if it was used less than 4 hours ago, to avoid people automatically using the same stuff all the time."
I'm not against removing the functionality completely. If one wants to upload stuff with the same comment, then the comment can be selected from the drop-down box. What is your opinion?
comment:7 by , 12 years ago
I think I would be okay with removing it. However, I'm new to JOSM. Established users may have workflows where this feature is more helpful. However, I agree the drop-down means it's not much work to reuse a recent old comment.
In the meantime, I think the configurable age works (I assume it can be set to 0 to disable the feature).
comment:8 by , 12 years ago
Cc: | added |
---|
In the meantime, I think the configurable age works (I assume it can be set to 0 to disable the feature).
Right, that works since standard integer arithmetic is used here.
@Dirk: Any concerns when removing this feature (pre-select changeset comment when it is younger than 4h)?
comment:9 by , 12 years ago
Actually I like that. I usually upload multiple times with something like "Driving around at 2013-12-07". That comment stays the same for multiple uploads. Also in Linux Drag&Drop and selecting is much easier, so a prefilled data field is actually preferred for me.
additional wish: often i enter a changeset comment and want to check again the data. But if i close the requester the new comment is lost.
This is something I'd like to have also...
comment:11 by , 12 years ago
Milestone: | → 14.01 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Since some prefer the current behaviour (see also #9514), let's keep it as it is. The feature can be disabled by changing the upload.comment.max-age
preference key accordingly (setting it to 0
for instance).
additional wish: often i enter a changeset comment and want to check again the data. But if i close the requester the new comment is lost.