Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10630 closed defect (fixed)

broken match in access preset

Reported by: skyper Owned by: team
Priority: normal Milestone: 14.10
Component: Internal preset Version: latest
Keywords: access match Cc:

Description (last modified by skyper)

The is a wrong value for match which prevents the general access preset from showing up in the tag/membership toggle dialog

Please, find attached patch which fixes the problem.

Attachments (1)

access_match_preset.diff (1.1 KB) - added by skyper 5 years ago.
patch

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by skyper

Attachment: access_match_preset.diff added

patch

comment:1 Changed 5 years ago by skyper

Description: modified (diff)

comment:2 Changed 5 years ago by skyper

Oh, I forgot: Think it was intentional to prevent the mismatch with the other values from emergency as main tag. Though, this does not work as we do not have an option for "keyvalue and neutral otherwise".

comment:3 Changed 5 years ago by Don-vip

Owner: changed from team to skyper
Status: newneedinfo

I'm not sure to understand the problem. What kind of object/tags cause your problem?

comment:4 in reply to:  3 Changed 5 years ago by skyper

Owner: changed from skyper to team
Status: needinfonew

Replying to Don-vip:

I'm not sure to understand the problem. What kind of object/tags cause your problem?

My problem is that without emergency=yes,official,designated,destination,permissive,private,no the "general access preset" will never match due to `match="tagvalue". This was introduced to fix #8995 though.

comment:5 Changed 5 years ago by Don-vip

Milestone: 14.10
Summary: [patch] broken match in access presetbroken match in access preset

Ok thanks. I'll add the missing match mode instead of reverting this change.

comment:6 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7613/josm:

see #8995, fix #10630 - change keyvalue match meaning to "neutral otherwise", add new keyvalue! match mode by default with the old meaning (negative otherwise)

comment:7 Changed 5 years ago by Don-vip

In 7614/josm:

see #10630 - add new keyvalue! match mode in the XSD

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.