Modify

Opened 4 years ago

Last modified 13 months ago

#10631 new defect

Filling in inner parts with the outer area doesn't work as expected

Reported by: Grillo Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: template_report multipolygon Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

  1. Draw a multipolygon
  2. Try to expand the outer part into the inner part by drawing a separate polygon and connecting it to the outer part
  3. join the inner area with the newly drawn polygon with ctrl-j

What is the expected result?

In earlier versions of Josm the outer would fill into the inner, and the inner border would move to the extent of the new placement.

What happens instead?

If the expansion polygon ends at the old outer border and it's joined with the inner part, it just disappears. If it continues into the outer part, the inner grows into the outer part (tags of the new area will also be placed on the inner part, but that's irrelevant to this ticket)

Please provide any additional information below. Attach a screenshot if possible.

Before:

After:

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-09-29 22:12:08
Last Changed Author: Don-vip
Revision: 7588
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-09-29 23:52:43 +0200 (Mon, 29 Sep 2014)
Last Changed Rev: 7588

Identification: JOSM/1.5 (7588 sv) Windows 8 64-Bit
Memory Usage: 339 MB / 3641 MB (82 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- AddrInterpolation (30416)
- FixAddresses (30416)
- HouseNumberTaggingTool (30416)
- OpeningHoursEditor (30609)
- buildings_tools (30485)
- download_along (30416)
- imagery_offset_db (30534)
- imageryadjust (30416)
- measurement (30641)
- notes (v0.9.4)
- photo_geotagging (30462)
- terracer (30643)
- turnrestrictions (30651)
- undelete (30416)
- utilsplugin2 (30460)

Last errors/warnings:
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker$MapCSSTagCheckerAndRule@145ee49a, code=3000]
- W: Unable to remove primitives from TestError [tester=org.openstreetmap.josm.data.validation.tests.MapCSSTagChecker$MapCSSTagCheckerAndRule@145ee49a, code=3000]

Attachments (3)

multipoly.osm (2.9 KB) - added by Grillo 4 years ago.
Basic file with data seen in screenshots
before.png (725.5 KB) - added by Don-vip 4 years ago.
after.png (709.8 KB) - added by Don-vip 4 years ago.

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by Grillo

Attachment: multipoly.osm added

Basic file with data seen in screenshots

Changed 4 years ago by Don-vip

Attachment: before.png added

Changed 4 years ago by Don-vip

Attachment: after.png added

comment:1 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:2 Changed 4 years ago by stoecker

Hmm, actually this is what I would expect. When you join it with the inner part, then the inner is expanded.

The outer way or the multipolygon should be selected to expand it into the inner. I think the issue is, that both of these options don't work.

comment:3 in reply to:  2 Changed 4 years ago by Grillo

Replying to stoecker:

Hmm, actually this is what I would expect. When you join it with the inner part, then the inner is expanded.

The outer way or the multipolygon should be selected to expand it into the inner. I think the issue is, that both of these options don't work.

A fair point. Currently, the only way to expand into the inner is to make new nodes out of the inner and pull them to the new extent, which is pretty cumbersome.

comment:4 Changed 4 years ago by bastiK

The correct way would be to select multipolygon relation and the closed way, but this isn't implemented yet.

comment:5 Changed 13 months ago by Don-vip

Keywords: multipolygon added; multipolygons removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to Grillo
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.