#10358 closed enhancement (fixed)
[patch] presets added translation links to missing items
| Reported by: | frankthetankk | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.08 |
| Component: | Internal preset | Version: | tested |
| Keywords: | translations | Cc: |
Description
With my attempt to clean up the internal presets code and make it easier to read #10351 I noticed a lot of items with errors and/or missing href links. I made a patch that only focuses on fixing/adding href links.
I understand about adding links to presets with only key/values doesn't help with 'getting more information' since there is no other values to change, for example highway=stop and highway=give_way. I feel since adding the translations in anyways is always beneficial in later use. For example with the highway=stop(which should have direction and maybe other key added). One way it helps by displaying the icon and preset path under the 'Tags/Membership' window to make it easier to see. I tested the match with different values without any difference for showing up in the 'Tags/Membership' window. There is also numerous item already in place that is similar, for example Groyne.
Below are a brief list of changes.
-
highway=construction- Changed the english link. I was told the link may be wiped here. highway=stop- Added full linkshighway=give_way- Added full linksbarrier=spikes- Added full linksbarrier=hampshire_gate- Added full linkscovered=colonnade- Added missing linksfr,plbarrier=bump_gate- Added full linksbarrier=hampshire_gate- Added full linksbarrier=stile- Fixed linkbarrier=sally_port- Fixed/Added linkswaterway=waterfall- Added linklanduse=basin- Added full linksman_made=reservoir_covered- Added full linksnatural=land- Added link (itemshould be deleted entirely)natural=mud- Added full linksnatural=bay- Added full linksleisure=marina- Added full linksaerialway=gondola- Fixed linkaerialway=t-bar- Fixed linkaerialway=j-bar- Fixed linkaerialway=platter- Fixed linkaerialway=rope_tow- Fixed linkaerialway=magic_carpet- Fixed linkaerialway=goods- Added linkaerialway=station- Fixed linkaerialway=pylon- Fixed linkamenity=car_wash- Added full linksshop=car_repair- Added full linksshop=tyres- Added full linksamenity=motorcycle_parking- Added full linkspublic_transport=platform- Added full links.highway=platformwas old and replaced.tourism=attraction- Added full linksinformation=map- Added full linksinformation=board- Added full linksinformation=terminal- Added full linksinformation=audioguide- Added full linkstourism=picnic_site- Added full linksleisure=swimming_pool- Added full linksamenity=kindergarten- Added full linksamenity=driving_school- Fixed link, added linksamenity=nursing_home- Added full linksamenity=shelter- Added full linksamenity=hunting_stand- Added full linksleisure=stadium- Added full linksleisure=sports_centre- Added full linksleisure=track- Added full linksleisure=pitch- Added full linksleisure=golf_course- Added full linkssport=motor- Added full linkssport=karting- Added full linkssport=motocross- Added full linkssport=safety_training- Added full linkssport=model_aerodrome- Added full linkssport=rc_car- Added full linksbuilding- Added links forResidential Buildingman_made=tower- Added full linksman_made=works- Added full linksman_made=chimney- Fixed linkman_made=gasometer- Added full linksman_made=water_tower- Added full linkshistoric=ruins- Added full linksgeological=palaeontological_site- Fixed linkhistoric=monument- Added full linkshistoric=wayside_cross- Added full linkshistoric=wayside_shrine- Added full linkshistoric=boundary_stone- Added full linksshop=tailor- Added full linksshop=furniture- Added full linksboundary=national- Added full links (itemshould be removed. useboundary=instead)place=continent- Added full links (itemshould be removed. There is only 7 continents on earth. No need to add more.)place=country- Added full linksplace=state- Added full linksplace=region- Added full links (itemshould be removed. useplace=instead)place=county- Added full linksplace=city- Added full linksplace=village- Added full linksplace=hamlet- Added full linksplace=isolated_dwelling- Added full linksleisure=nature_reserve- Added full linksnatural=scree- Added full linksnatural=scrub- Added full linkslanduse=farmland- Added full linkslanduse=meadow- Added full linkslanduse=vineyard- Added full linkslanduse=allotments- Added full linksleisure=garden- Added full linkslanduse=grass- Added full linksleisure=park- Added full linkslanduse=residential- Added full linksContact (common schema)- Added full linksroute=power- Added full links
Attachments (1)
Change History (10)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
disappointing that I can't upload this patch file, cause it's labeled as spam I think. Could someone attach the file for me, please? Thanks
comment:3 by , 10 years ago
| Version: | → latest |
|---|
comment:4 by , 10 years ago
| Version: | latest → tested |
|---|
by , 10 years ago
| Attachment: | translations_7363_v1.diff added |
|---|
comment:5 by , 10 years ago
| Milestone: | → 14.08 |
|---|
follow-ups: 8 9 comment:7 by , 10 years ago
Replying to frankthetankk:
public_transport=platform- Added full links.highway=platformwas old and replaced.
Thanks for the patch :) This is the only thing I did not take into account. We support the two tagging schemas, this is intended. I also performed the "classic" links update which is run by a script for adding missing languages (we do this update at least once per stable release).
comment:8 by , 10 years ago
Replying to Don-vip:
Replying to frankthetankk:
public_transport=platform- Added full links.highway=platformwas old and replaced.Thanks for the patch :) This is the only thing I did not take into account. We support the two tagging schemas, this is intended. I also performed the "classic" links update which is run by a script for adding missing languages (we do this update at least once per stable release).
Okay I understand, that's no problem. Thank you, and glad I could help. Took a while to create it. :)
comment:9 by , 10 years ago
Replying to Don-vip:
Replying to frankthetankk:
public_transport=platform- Added full links.highway=platformwas old and replaced.Thanks for the patch :) This is the only thing I did not take into account. We support the two tagging schemas, this is intended. I also performed the "classic" links update which is run by a script for adding missing languages (we do this update at least once per stable release).
I was reviewing the patch. The patch looks great. I noticed one tiny mistake with spacing. At line 6642 under <item name="Country". The line in question <space /> should have four more spaces added to the beginning of the line.
my patch upload keeps getting blocked by saying its spam cause it has href. Gonna try to upload elsewhere. Not sure what to do, can I email someone the file?