Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10358 closed enhancement (fixed)

[patch] presets added translation links to missing items

Reported by: frankthetankk Owned by: team
Priority: normal Milestone: 14.08
Component: Internal preset Version: tested
Keywords: translations Cc:

Description

With my attempt to clean up the internal presets code and make it easier to read #10351 I noticed a lot of items with errors and/or missing href links. I made a patch that only focuses on fixing/adding href links.

I understand about adding links to presets with only key/values doesn't help with 'getting more information' since there is no other values to change, for example highway=stop and highway=give_way. I feel since adding the translations in anyways is always beneficial in later use. For example with the highway=stop(which should have direction and maybe other key added). One way it helps by displaying the icon and preset path under the 'Tags/Membership' window to make it easier to see. I tested the match with different values without any difference for showing up in the 'Tags/Membership' window. There is also numerous item already in place that is similar, for example Groyne.

Below are a brief list of changes.

  • highway=construction - Changed the english link. I was told the link may be wiped here.
  • highway=stop - Added full links
  • highway=give_way - Added full links
  • barrier=spikes - Added full links
  • barrier=hampshire_gate - Added full links
  • covered=colonnade - Added missing links fr, pl
  • barrier=bump_gate - Added full links
  • barrier=hampshire_gate - Added full links
  • barrier=stile - Fixed link
  • barrier=sally_port - Fixed/Added links
  • waterway=waterfall - Added link
  • landuse=basin - Added full links
  • man_made=reservoir_covered - Added full links
  • natural=land - Added link (item should be deleted entirely)
  • natural=mud - Added full links
  • natural=bay - Added full links
  • leisure=marina - Added full links
  • aerialway=gondola - Fixed link
  • aerialway=t-bar - Fixed link
  • aerialway=j-bar - Fixed link
  • aerialway=platter - Fixed link
  • aerialway=rope_tow - Fixed link
  • aerialway=magic_carpet - Fixed link
  • aerialway=goods - Added link
  • aerialway=station - Fixed link
  • aerialway=pylon - Fixed link
  • amenity=car_wash - Added full links
  • shop=car_repair - Added full links
  • shop=tyres - Added full links
  • amenity=motorcycle_parking - Added full links
  • public_transport=platform - Added full links. highway=platform was old and replaced.
  • tourism=attraction - Added full links
  • information=map - Added full links
  • information=board - Added full links
  • information=terminal - Added full links
  • information=audioguide - Added full links
  • tourism=picnic_site - Added full links
  • leisure=swimming_pool - Added full links
  • amenity=kindergarten - Added full links
  • amenity=driving_school - Fixed link, added links
  • amenity=nursing_home - Added full links
  • amenity=shelter - Added full links
  • amenity=hunting_stand - Added full links
  • leisure=stadium - Added full links
  • leisure=sports_centre - Added full links
  • leisure=track - Added full links
  • leisure=pitch - Added full links
  • leisure=golf_course - Added full links
  • sport=motor - Added full links
  • sport=karting - Added full links
  • sport=motocross - Added full links
  • sport=safety_training - Added full links
  • sport=model_aerodrome - Added full links
  • sport=rc_car - Added full links
  • building - Added links for Residential Building
  • man_made=tower - Added full links
  • man_made=works - Added full links
  • man_made=chimney - Fixed link
  • man_made=gasometer - Added full links
  • man_made=water_tower - Added full links
  • historic=ruins - Added full links
  • geological=palaeontological_site - Fixed link
  • historic=monument - Added full links
  • historic=wayside_cross - Added full links
  • historic=wayside_shrine - Added full links
  • historic=boundary_stone - Added full links
  • shop=tailor - Added full links
  • shop=furniture - Added full links
  • boundary=national - Added full links (item should be removed. use boundary= instead)
  • place=continent - Added full links (item should be removed. There is only 7 continents on earth. No need to add more.)
  • place=country - Added full links
  • place=state - Added full links
  • place=region - Added full links (item should be removed. use place= instead)
  • place=county - Added full links
  • place=city - Added full links
  • place=village - Added full links
  • place=hamlet - Added full links
  • place=isolated_dwelling - Added full links
  • leisure=nature_reserve - Added full links
  • natural=scree - Added full links
  • natural=scrub - Added full links
  • landuse=farmland - Added full links
  • landuse=meadow - Added full links
  • landuse=vineyard - Added full links
  • landuse=allotments - Added full links
  • leisure=garden - Added full links
  • landuse=grass - Added full links
  • leisure=park - Added full links
  • landuse=residential - Added full links
  • Contact (common schema) - Added full links
  • route=power - Added full links

Attachments (1)

translations_7363_v1.diff (74.6 KB) - added by Don-vip 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by frankthetankk

my patch upload keeps getting blocked by saying its spam cause it has href. Gonna try to upload elsewhere. Not sure what to do, can I email someone the file?

comment:2 Changed 5 years ago by frankthetankk

disappointing that I can't upload this patch file, cause it's labeled as spam I think. Could someone attach the file for me, please? Thanks

Here is a pastebin of my patch

Last edited 5 years ago by frankthetankk (previous) (diff)

comment:3 Changed 5 years ago by frankthetankk

Version: latest

comment:4 Changed 5 years ago by frankthetankk

Version: latesttested

Changed 5 years ago by Don-vip

Attachment: translations_7363_v1.diff added

comment:5 Changed 5 years ago by Don-vip

Milestone: 14.08

comment:6 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7372/josm:

fix #10358 - presets added translation links to missing items (modified patch by frankthetankk + classic link update)

comment:7 in reply to:  description ; Changed 5 years ago by Don-vip

Replying to frankthetankk:

  • public_transport=platform - Added full links. highway=platform was old and replaced.

Thanks for the patch :) This is the only thing I did not take into account. We support the two tagging schemas, this is intended. I also performed the "classic" links update which is run by a script for adding missing languages (we do this update at least once per stable release).

comment:8 in reply to:  7 Changed 5 years ago by frankthetankk

Replying to Don-vip:

Replying to frankthetankk:

  • public_transport=platform - Added full links. highway=platform was old and replaced.

Thanks for the patch :) This is the only thing I did not take into account. We support the two tagging schemas, this is intended. I also performed the "classic" links update which is run by a script for adding missing languages (we do this update at least once per stable release).

Okay I understand, that's no problem. Thank you, and glad I could help. Took a while to create it. :)

comment:9 in reply to:  7 Changed 5 years ago by frankthetankk

Replying to Don-vip:

Replying to frankthetankk:

  • public_transport=platform - Added full links. highway=platform was old and replaced.

Thanks for the patch :) This is the only thing I did not take into account. We support the two tagging schemas, this is intended. I also performed the "classic" links update which is run by a script for adding missing languages (we do this update at least once per stable release).

I was reviewing the patch. The patch looks great. I noticed one tiny mistake with spacing. At line 6642 under <item name="Country". The line in question <space /> should have four more spaces added to the beginning of the line.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.