[patch] default preset information=map values added

[frankthetankk]

I'm new to creating tickets so bare with me.

In the default preset 7328. Under Facilities/Tourism/Map @ 3239, I expanded the <link href to ​http://wiki.openstreetmap.org/wiki/Tag:information%3Dmap. map_type @ 3245 I added the value "image", map_size @ 3246 I added the value "building".

[frankthetankk]

Internal preset

[skyper]

Replying to frankthetankk:

I'm new to creating tickets so bare with me.

Welcome

In the default preset 7328. Under Facilities/Tourism/Map @ 3239, I expanded the <link href to ​http://wiki.openstreetmap.org/wiki/Tag:information%3Dmap. map_type @ 3245 I added the value "image", map_size @ 3246 I added the value "building".

Thanks for your effort but please notice:

• We usually only add established tags and values to the defaultpresets and taginfo only shows single digit values for your proposed ones (​[1],​[2]). Wounder why these values are listed on the wiki, by the way.
• A huge file with small changes does not help that much. Please, supply a proper .diff or .patch file. For simply changes an unified diff is enough.

Thanks and cheers

[frankthetankk]

Replying to skyper:

Thanks for your effort but please notice:

Thank you :)

• We usually only add established tags and values to the defaultpresets and taginfo only shows single digit values for your proposed ones (​[1],​[2]). Wounder why these values are listed on the wiki, by the way.

I understand now by established tags, I didn't know. I suppose my propose ones shouldn't be added at this time. Although the wiki href link may still apply. What do you think?

I apologise if I am asking questions within a ticket. Where can I be directed to find information on the minimum requirements for tags and values to be added into defaultpresets?

• A huge file with small changes does not help that much. Please, supply a proper .diff or .patch file. For simply changes an unified diff is enough.

I am new to creating a .diff or .patch file. Do you recommend any tools or software that could help me? Thanks

[Don-vip]

Welcome :) Another point: please don't fill in milestone field, this choice is entirely ours.

[skyper]

Replying to frankthetankk:

Replying to skyper:

• We usually only add established tags and values to the defaultpresets and taginfo only shows single digit values for your proposed ones (​[1],​[2]). Wounder why these values are listed on the wiki, by the way.

I understand now by established tags, I didn't know. I suppose my propose ones shouldn't be added at this time. Although the wiki href link may still apply. What do you think?

Sure, updating the links is always an issue. Thought there exist a script for that but it has to be run manually and has not been run for some time.

I apologise if I am asking questions within a ticket. Where can I be directed to find information on the minimum requirements for tags and values to be added into defaultpresets?

This is not written down anywhere, so far, but definitely a ToDo. See bastiK's comment on #10246 two weeks ago.
Note: You can always create an external preset and are invited to make it available within JOSM's infrastructure. See wiki:Presets#Createnewpresets and follow the two links there.

• A huge file with small changes does not help that much. Please, supply a proper .diff or .patch file. For simply changes an unified diff is enough.

I am new to creating a .diff or .patch file. Do you recommend any tools or software that could help me? Thanks

Well, you already found an answer. Myself is using the standard command line tool diff on Linux and BSD-like machines.

[skyper]

Replying to Don-vip:

Welcome :) Another point: please don't fill in milestone field, this choice is entirely ours.

Then you can restrict it and make it only available for certain user groups and/or individual users.

[frankthetankk]

Replying to skyper:

Replying to Don-vip:

Welcome :) Another point: please don't fill in milestone field, this choice is entirely ours.

Then you can restrict it and make it only available for certain user groups and/or individual users.

Okay I understand I wont do that again. I was following a similar ticket and used it as a template on creating this ticket.

[Don-vip]

Replying to skyper:

Then you can restrict it and make it only available for certain user groups and/or individual users.

I'd like to but we can't. Trac sucks on this point.

[skyper]

Replying to Don-vip:

Replying to skyper:

Then you can restrict it and make it only available for certain user groups and/or individual users.

I'd like to but we can't. Trac sucks on this point.

Ok, I see. There is one hack mentioned in the docs: TracTickets#HidingFieldsandAddingCustomFields

[Don-vip]

Replying to skyper:

Ok, I see. There is one hack mentioned in the docs: TracTickets#HidingFieldsandAddingCustomFields

It doesn't work, we use milestone feature so we won't remove all values :)

[skyper]

Replying to skyper:

Replying to frankthetankk:

I understand now by established tags, I didn't know. I suppose my propose ones shouldn't be added at this time. Although the wiki href link may still apply. What do you think?

Sure, updating the links is always an issue. Thought there exist a script for that but it has to be run manually and has not been run for some time.

Well, the script was run, thanks Vincent, but it does not cover checking the English link but only adding adding links for other languages. E.g. we still need to update the links for information=map.

[Don-vip]

The script is run once per development cycle. Sorry for this ticket it's too late for this release we'll see next month. I still have to work on #10033/#10230 and we still have i18n update to do.

[skyper]

patch

[skyper]

Replying to Don-vip:

The script is run once per development cycle. Sorry for this ticket it's too late for this release we'll see next month. I still have to work on #10033/#10230 and we still have i18n update to do.

Well, I thought that maybe frankthetankk will finish his work but it is only a one line change​.

[frankthetankk]

Replying to skyper:

Replying to Don-vip:

The script is run once per development cycle. Sorry for this ticket it's too late for this release we'll see next month. I still have to work on #10033/#10230 and we still have i18n update to do.

Well, I thought that maybe frankthetankk will finish his work but it is only a one line change​.

No problem being late. I'm a newbie here, just trying to help if I see it, also learning a lot as I go. Thanks for understanding.

As far as this ticket, I enjoyed reading the conversation. I suppose what is left of this ticket is the patch file what skyper already posted. Thanks.

[skyper]

Closed as duplicate of #10303.