add 10 shops [PATCH]

[Klumbumbus]

I created a ​patch, which adds the following shops to the internal presets and mappaint style.

Please use shops.3.diff! I messed up the two versions before.

Icon	tag	original source, license	modification comment, license	proposed icon location
	shop=ticket	​osm-icons CC0	modified by me, CC0	shop
	shop=interior_decoration	​osm-icons CC0	modified by me, CC0	shop
	shop=pet	​SSJB CC0		shop
	shop=car_parts	​commons CC0	self designed	vehicle
	shop=video_games	​commons CC0	self designed	shop
	shop=beauty	​openclipart PD		shop
	shop=tea	​commons CC0	self designed	shop/groceries
	shop=coffee	​openclipart PD	modified by me, PD	shop/groceries
	shop=bag	​openclipart PD		shop
	shop=bed	​openclipart PD	modified by me, PD	shop

[bastiK]

In 7296/josm:

applied #10246 - add 10 shops (patch by Klumbumbus)

[bastiK]

In [o30516] - add icons for shops (all PD or CC0) (patch by Klumbumbus)

Great, thanks!

[skyper]

Replying to bastiK:

In [o30516] - add icons for shops (all PD or CC0) (patch by Klumbumbus)

Great, thanks!

Thanks, too.

Just two remarks/questions in general:

• Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.
• I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

[Klumbumbus]

Replying to skyper:

Just two remarks/questions in general:

• Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.

I attatched .png because they are much smaller than .svg (e.g. 10361 bytes compared to 567 bytes for interior decoration icon, thats 18 times larger). If you want I can attach .svg files for most of the 10 icons.

• I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

Feel free to refuse my patches if you think a feature shouldn't be in default preset or mappaint. I think these 10 shops are all ok. I already mapped all of them myself. 7 of the 10 shops are in ​this single schopping mall, which I mapped. This is a reason why I choose these shops to add. I also checked wiki and taginfo before writing the patch, to ensure that there are no big inconsistencies.

[Don-vip]

Thanks for taking care of formatting your tickets in such a nice wiki-style, it's really appreciated :)

[Klumbumbus]

I want to upload the .svgs. There is one problem: if the .svg is not square then JOSM stretches it to square (in the preset menu and also on the mappaint). Is that a JOSM bug or do I need to upload square svgs?

edit:

example: results in

edit: note: svg image later replaced by working version

[skyper]

Replying to Klumbumbus:

Replying to skyper:

Just two remarks/questions in general:

• Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.

I attatched .png because they are much smaller than .svg (e.g. 10361 bytes compared to 567 bytes for interior decoration icon, thats 18 times larger). If you want I can attach .svg files for most of the 10 icons.

Good point. So the major disadvantage would be scaling.

• I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

Feel free to refuse my patches if you think a feature shouldn't be in default preset or mappaint. I think these 10 shops are all ok. I already mapped all of them myself. 7 of the 10 shops are in ​this single schopping mall, which I mapped. This is a reason why I choose these shops to add. I also checked wiki and taginfo before writing the patch, to ensure that there are no big inconsistencies.

This point was not at all about your patch and you do mention two guideline points above. Though with taginfo you sometimes need to take a closer look at eg. the amount of user who did add the tag. Maybe this would be nice to have in the wiki.

[Klumbumbus]

There is one more problem with .svg: #10250

[bastiK]

Replying to Klumbumbus:

I want to upload the .svgs. There is one problem: if the .svg is not square then JOSM stretches it to square (in the preset menu and also on the mappaint). Is that a JOSM bug or do I need to upload square svgs?

edit:

example: results in

Seems to be another problem of your svg library (for this specific image). Even if it is distributed as png, we also like to keep an svg version of each image in the repository for later editing.

[Klumbumbus]

I reworked the .svgs. They all now work and look fine in JOSM. Attached 9 of them before this comment.

(There is no .svg file for the video_games icon, because I edited single pixels of the 16px png.)

[mkoniecz]

Some ruff guideline might be useful to define a common understanding.

Maybe "documented on OSM wiki"?

[bastiK]

Replying to skyper:

I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

We like to support well established tagging schemes, that represent a community consensus. This means they should have a proper documentation in the wiki and decent usage numbers (absolute and by number of mappers). Controversial cases (like contact:phone=* vs. phone=*) need to be decided case by case.

If a features is only mapped by a handful of specialists, it is better suited for an external preset. Usually this includes tagging schemes restriced to one specific country, hobby, sport or profession. (There are exceptions like Tiger-highlight and hiking scale preset.)

Basically we have to make sure that the preset menu isn't too cluttered, because it would get hard to find the useful every-day stuff if we had too many exotic entries. Similarly, then there is a limit on how much information you can present in the map display. (E.g. its not practical to visualize lit=*, sidewalk=*, parking:lane=* and cycleway=* all at once.) Another issue is maintainability. At the end of the day, the JOSM core team is responsible for keeping the the core presets and map styles up to date and fix bugs. With external styles and presets, we get people who know a lot about a certain topic to actively care for and support their own work.

[bastiK]

In 7301/josm:

see #10246 - replace icons by svg version

[bastiK]

In [o30518] - replace images by svg source version (same license)

[bastiK]

Replying to Klumbumbus:

Replying to skyper:

Just two remarks/questions in general:

• Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.

I attatched .png because they are much smaller than .svg (e.g. 10361 bytes compared to 567 bytes for interior decoration icon, thats 18 times larger). If you want I can attach .svg files for most of the 10 icons.

Thanks for adding suitable svg versions! The difference in size is less dramatic when the files are zipped.

[skyper]

Replying to bastiK:

Replying to skyper:

I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

We like to support well established tagging schemes, that represent a community consensus. This means they should have a proper documentation in the wiki and decent usage numbers (absolute and by number of mappers). Controversial cases (like contact:phone=* vs. phone=*) need to be decided case by case.

If a features is only mapped by a handful of specialists, it is better suited for an external preset. Usually this includes tagging schemes restriced to one specific country, hobby, sport or profession. (There are exceptions like Tiger-highlight and hiking scale preset.)

Basically we have to make sure that the preset menu isn't too cluttered, because it would get hard to find the useful every-day stuff if we had too many exotic entries. Similarly, then there is a limit on how much information you can present in the map display. (E.g. its not practical to visualize lit=*, sidewalk=*, parking:lane=* and cycleway=* all at once.) Another issue is maintainability. At the end of the day, the JOSM core team is responsible for keeping the the core presets and map styles up to date and fix bugs. With external styles and presets, we get people who know a lot about a certain topic to actively care for and support their own work.

I started a new wiki page with you comments. Feel free to change/update/extend.

I am unsure about a general page in the ​OSM-wiki. Would this be an excepted solution to harmonize presets across editor software ?