Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10246 closed enhancement (fixed)

add 10 shops [PATCH]

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 14.07
Component: Internal mappaint style Version:
Keywords: mappaint, preset, shops Cc: frankthetankk

Description (last modified by Klumbumbus)

I created a patch, which adds the following shops to the internal presets and mappaint style.

Please use shops.3.diff! I messed up the two versions before.

Icontagoriginal source, licensemodification comment, licenseproposed icon location
shop=ticketosm-icons CC0modified by me, CC0shop
shop=interior_decorationosm-icons CC0modified by me, CC0shop
shop=petSSJB CC0 shop
shop=car_partscommons CC0self designedvehicle
shop=video_gamescommons CC0self designedshop
shop=beautyopenclipart PD shop
shop=teacommons CC0self designedshop/groceries
shop=coffeeopenclipart PDmodified by me, PDshop/groceries
shop=bagopenclipart PD shop
shop=bedopenclipart PDmodified by me, PDshop

Attachments (21)

bag.png (751 bytes) - added by Klumbumbus 5 years ago.
beauty.png (493 bytes) - added by Klumbumbus 5 years ago.
bed.png (407 bytes) - added by Klumbumbus 5 years ago.
car_parts.png (531 bytes) - added by Klumbumbus 5 years ago.
coffee.png (741 bytes) - added by Klumbumbus 5 years ago.
interior_decoration.png (567 bytes) - added by Klumbumbus 5 years ago.
pet.png (587 bytes) - added by Klumbumbus 5 years ago.
tea.png (351 bytes) - added by Klumbumbus 5 years ago.
ticket.png (623 bytes) - added by Klumbumbus 5 years ago.
video_games.png (438 bytes) - added by Klumbumbus 5 years ago.
shops.3.diff (9.0 KB) - added by Klumbumbus 5 years ago.
fat lipstick.png (725 bytes) - added by Klumbumbus 5 years ago.
bag.svg (15.6 KB) - added by Klumbumbus 5 years ago.
beauty.svg (12.7 KB) - added by Klumbumbus 5 years ago.
bed.svg (2.4 KB) - added by Klumbumbus 5 years ago.
car_parts.svg (6.0 KB) - added by Klumbumbus 5 years ago.
coffee.svg (5.8 KB) - added by Klumbumbus 5 years ago.
interior_decoration.svg (10.5 KB) - added by Klumbumbus 5 years ago.
pet.svg (32.1 KB) - added by Klumbumbus 5 years ago.
tea.svg (14.9 KB) - added by Klumbumbus 5 years ago.
ticket.svg (4.0 KB) - added by Klumbumbus 5 years ago.

Download all attachments as: .zip

Change History (39)

Changed 5 years ago by Klumbumbus

Attachment: bag.png added

Changed 5 years ago by Klumbumbus

Attachment: beauty.png added

Changed 5 years ago by Klumbumbus

Attachment: bed.png added

Changed 5 years ago by Klumbumbus

Attachment: car_parts.png added

Changed 5 years ago by Klumbumbus

Attachment: coffee.png added

Changed 5 years ago by Klumbumbus

Attachment: interior_decoration.png added

Changed 5 years ago by Klumbumbus

Attachment: pet.png added

Changed 5 years ago by Klumbumbus

Attachment: tea.png added

Changed 5 years ago by Klumbumbus

Attachment: ticket.png added

Changed 5 years ago by Klumbumbus

Attachment: video_games.png added

comment:1 Changed 5 years ago by Klumbumbus

Description: modified (diff)

Changed 5 years ago by Klumbumbus

Attachment: shops.3.diff added

comment:2 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:3 Changed 5 years ago by bastiK

Resolution: fixed
Status: newclosed

In 7296/josm:

applied #10246 - add 10 shops (patch by Klumbumbus)

comment:4 Changed 5 years ago by bastiK

In [o30516] - add icons for shops (all PD or CC0) (patch by Klumbumbus)

Great, thanks!

comment:5 in reply to:  4 ; Changed 5 years ago by skyper

Replying to bastiK:

In [o30516] - add icons for shops (all PD or CC0) (patch by Klumbumbus)

Great, thanks!

Thanks, too.

Just two remarks/questions in general:

  • Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.
  • I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

comment:6 in reply to:  5 ; Changed 5 years ago by Klumbumbus

Replying to skyper:

Just two remarks/questions in general:

  • Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.

I attatched .png because they are much smaller than .svg (e.g. 10361 bytes compared to 567 bytes for interior decoration icon, thats 18 times larger). If you want I can attach .svg files for most of the 10 icons.

  • I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

Feel free to refuse my patches if you think a feature shouldn't be in default preset or mappaint. I think these 10 shops are all ok. I already mapped all of them myself. 7 of the 10 shops are in this single schopping mall, which I mapped. This is a reason why I choose these shops to add. I also checked wiki and taginfo before writing the patch, to ensure that there are no big inconsistencies.

comment:7 Changed 5 years ago by Don-vip

Milestone: 14.07

Thanks for taking care of formatting your tickets in such a nice wiki-style, it's really appreciated :)

comment:8 Changed 5 years ago by Klumbumbus

I want to upload the .svgs. There is one problem: if the .svg is not square then JOSM stretches it to square (in the preset menu and also on the mappaint). Is that a JOSM bug or do I need to upload square svgs?

edit:

example: results in

edit: note: svg image later replaced by working version

Last edited 5 years ago by Klumbumbus (previous) (diff)

comment:9 Changed 5 years ago by skyper

Replying to Klumbumbus:

Replying to skyper:

Just two remarks/questions in general:

  • Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.

I attatched .png because they are much smaller than .svg (e.g. 10361 bytes compared to 567 bytes for interior decoration icon, thats 18 times larger). If you want I can attach .svg files for most of the 10 icons.

Good point. So the major disadvantage would be scaling.

  • I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

Feel free to refuse my patches if you think a feature shouldn't be in default preset or mappaint. I think these 10 shops are all ok. I already mapped all of them myself. 7 of the 10 shops are in this single schopping mall, which I mapped. This is a reason why I choose these shops to add. I also checked wiki and taginfo before writing the patch, to ensure that there are no big inconsistencies.

This point was not at all about your patch and you do mention two guideline points above. Though with taginfo you sometimes need to take a closer look at eg. the amount of user who did add the tag. Maybe this would be nice to have in the wiki.

comment:10 Changed 5 years ago by Klumbumbus

There is one more problem with .svg: #10250

Changed 5 years ago by Klumbumbus

Attachment: fat lipstick.png added

comment:11 in reply to:  8 Changed 5 years ago by bastiK

Replying to Klumbumbus:

I want to upload the .svgs. There is one problem: if the .svg is not square then JOSM stretches it to square (in the preset menu and also on the mappaint). Is that a JOSM bug or do I need to upload square svgs?

edit:

example: results in

Seems to be another problem of your svg library (for this specific image). Even if it is distributed as png, we also like to keep an svg version of each image in the repository for later editing.

Changed 5 years ago by Klumbumbus

Attachment: bag.svg added

Changed 5 years ago by Klumbumbus

Attachment: beauty.svg added

Changed 5 years ago by Klumbumbus

Attachment: bed.svg added

Changed 5 years ago by Klumbumbus

Attachment: car_parts.svg added

Changed 5 years ago by Klumbumbus

Attachment: coffee.svg added

Changed 5 years ago by Klumbumbus

Attachment: interior_decoration.svg added

Changed 5 years ago by Klumbumbus

Attachment: pet.svg added

Changed 5 years ago by Klumbumbus

Attachment: tea.svg added

Changed 5 years ago by Klumbumbus

Attachment: ticket.svg added

comment:12 Changed 5 years ago by Klumbumbus

I reworked the .svgs. They all now work and look fine in JOSM. Attached 9 of them before this comment.

(There is no .svg file for the video_games icon, because I edited single pixels of the 16px png.)

comment:13 Changed 5 years ago by mkoniecz

Some ruff guideline might be useful to define a common understanding.

Maybe "documented on OSM wiki"?

comment:14 in reply to:  5 ; Changed 5 years ago by bastiK

Replying to skyper:

I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

We like to support well established tagging schemes, that represent a community consensus. This means they should have a proper documentation in the wiki and decent usage numbers (absolute and by number of mappers). Controversial cases (like contact:phone=* vs. phone=*) need to be decided case by case.

If a features is only mapped by a handful of specialists, it is better suited for an external preset. Usually this includes tagging schemes restriced to one specific country, hobby, sport or profession. (There are exceptions like Tiger-highlight and hiking scale preset.)

Basically we have to make sure that the preset menu isn't too cluttered, because it would get hard to find the useful every-day stuff if we had too many exotic entries. Similarly, then there is a limit on how much information you can present in the map display. (E.g. its not practical to visualize lit=*, sidewalk=*, parking:lane=* and cycleway=* all at once.) Another issue is maintainability. At the end of the day, the JOSM core team is responsible for keeping the the core presets and map styles up to date and fix bugs. With external styles and presets, we get people who know a lot about a certain topic to actively care for and support their own work.

comment:15 Changed 5 years ago by bastiK

In 7301/josm:

see #10246 - replace icons by svg version

comment:16 Changed 5 years ago by bastiK

In [o30518] - replace images by svg source version (same license)

comment:17 in reply to:  6 Changed 5 years ago by bastiK

Replying to Klumbumbus:

Replying to skyper:

Just two remarks/questions in general:

  • Personally I prefer vector graphics over pixel graphics. If possible I would try to get .svgs as new icons.

I attatched .png because they are much smaller than .svg (e.g. 10361 bytes compared to 567 bytes for interior decoration icon, thats 18 times larger). If you want I can attach .svg files for most of the 10 icons.

Thanks for adding suitable svg versions! The difference in size is less dramatic when the files are zipped.

comment:18 in reply to:  14 Changed 5 years ago by skyper

Cc: frankthetankk added

Replying to bastiK:

Replying to skyper:

I always have/had difficulties to decide which new items are acceptable and which are better suited for external presets. Some ruff guideline might be useful to define a common understanding.

We like to support well established tagging schemes, that represent a community consensus. This means they should have a proper documentation in the wiki and decent usage numbers (absolute and by number of mappers). Controversial cases (like contact:phone=* vs. phone=*) need to be decided case by case.

If a features is only mapped by a handful of specialists, it is better suited for an external preset. Usually this includes tagging schemes restriced to one specific country, hobby, sport or profession. (There are exceptions like Tiger-highlight and hiking scale preset.)

Basically we have to make sure that the preset menu isn't too cluttered, because it would get hard to find the useful every-day stuff if we had too many exotic entries. Similarly, then there is a limit on how much information you can present in the map display. (E.g. its not practical to visualize lit=*, sidewalk=*, parking:lane=* and cycleway=* all at once.) Another issue is maintainability. At the end of the day, the JOSM core team is responsible for keeping the the core presets and map styles up to date and fix bugs. With external styles and presets, we get people who know a lot about a certain topic to actively care for and support their own work.

I started a new wiki page with you comments. Feel free to change/update/extend.

I am unsure about a general page in the OSM-wiki. Would this be an excepted solution to harmonize presets across editor software ?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.