#3393 closed defect (fixed)
loooong delay when using presets with a large osm file
| Reported by: | anonymous | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Component: | Core |
| Version: | latest | Keywords: | |
| Cc: |
Description
When selecting a preset while a large osm file (30 MB) is the active layer it takes several minutes for the preset dialog to come up. This happens with or without any objects selected. When the large layer is inactive there is no delay. JOSM uses all CPU during that time and produces no output on the console. However, JOSM can still be terminated with Ctrl-C.
This is JOSM r2052 started with -Xmx512M on WinXP with 2 GB of memory.
r2024 does not show this behavior.
Attachments (0)
Change History (7)
comment:1 Changed 4 years ago by Gubaer
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 4 years ago by mjulius
- Resolution fixed deleted
- Status changed from closed to reopened
This problem still exists in r2079. But, instead of taking minutes it only takes just under one minute to have the preset dialog show up for my example file.
So there is a noticeable improvement.
comment:3 Changed 4 years ago by Gubaer
- Resolution set to fixed
- Status changed from reopened to closed
(In [2081]) fixed #3393: loooong delay when using presets with a large osm file - further improvement; next step could be to turn UploadHooks into an asynchronous task; ApiPreconditionChecker loops over all keys in all upload primitives!
fixed #3435: Switching the changeset type deletes any changeset tags that have been set
fixed #3430: Entering comment=* manually in the changeset tags dialog gets ignored
fixed #3431: Upload dialog pops up again if no comment is provided
fixed #3429: created_by=* includes the wrong language when uploading from a new layer
comment:4 Changed 4 years ago by mjulius
- Resolution fixed deleted
- Status changed from closed to reopened
Sorry if I annoy you by reopening this ticket, but in r2083 this behavior has not changed compared to r2079.
The Add/Edit Property dialogs provide a similar functionality (auto-completion) without any noticeable delay. I am wondering whether it is possible to use the same routines for the preset dialog. I am guessing JOSM is maintaining a list of used key/value pairs somewhere.
It would also be helpful if auto-completion only offered values for the particular key that is being edited.
comment:5 Changed 4 years ago by Gubaer
comment:6 Changed 4 years ago by Gubaer
- Resolution set to fixed
- Status changed from reopened to closed
I've loaded a file 100'000 nodes. On my computer a preset dialog now pops up immediately. Could you please confirm?
comment:7 Changed 4 years ago by mjulius
Yes! This has helped.
Many thanks.
(In [2055]) fixed #3393: loooong delay when using presets with a large osm file
Initializing only one cache for autocompletion; now initializing in background thread, preset dialog should pop up immediately