Modify ↓

Opened 4 years ago

Closed 4 years ago

#3431 closed defect (fixed)

Upload dialog pops up again if no comment is provided

Reported by: avar Owned by: team
Priority: minor Component: Core
Version: latest Keywords:
Cc:

Description

  1. Make an edit
  2. Don't write a comment
  3. Click upload

The upload dialog will just pop up again in this case without any explanation.

If JOSM's developers want to force people to provide a changeset comment (that's optional in the spec) JOSM should pop up a dialog explaining that you're supposed to provide a comment in this case.

Otherwise confused users are bound to pound the upload button before closing the program in confusion.

Attachments (0)

Change History (1)

comment:1 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from new to closed

(In [2081]) fixed #3393: loooong delay when using presets with a large osm file - further improvement; next step could be to turn UploadHooks into an asynchronous task; ApiPreconditionChecker loops over all keys in all upload primitives!
fixed #3435: Switching the changeset type deletes any changeset tags that have been set
fixed #3430: Entering comment=* manually in the changeset tags dialog gets ignored
fixed #3431: Upload dialog pops up again if no comment is provided
fixed #3429: created_by=* includes the wrong language when uploading from a new layer

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.