Modify

Opened 4 years ago

Closed 4 years ago

#3429 closed defect (fixed)

created_by=* includes the wrong language when uploading from a new layer

Reported by: anonymous Owned by: team
Priority: critical Component: Core
Version: latest Keywords:
Cc:

Description

  1. Launch JOSM with --language=is
  2. Create new layer
  3. Create new data & upload

Now go to "Tags of new changeset" in the upload dialog. It will show:

created_by=JOSM/1.5 (2075 SVN en)

But should show:

created_by=JOSM/1.5 (2075 SVN is)

This happens intermittently. I managed to download data from the server, modify it and upload which resulted in a a broken changeset being uploaded. Then I resized the JOSM window, did further changes and uploaded again and that time the created_by=* string was correct.

See also attached screenshots. Both taken when doing the above.

Attachments (2)

created_by-wrong.png (96.3 KB) - added by avar 4 years ago.
"en" created_by under "is" locale
created_by-right-again.png (78.7 KB) - added by avar 4 years ago.
I resized the window and then I got "is" under "is"

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by avar

"en" created_by under "is" locale

Changed 4 years ago by avar

I resized the window and then I got "is" under "is"

comment:1 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from new to closed

(In [2081]) fixed #3393: loooong delay when using presets with a large osm file - further improvement; next step could be to turn UploadHooks into an asynchronous task; ApiPreconditionChecker loops over all keys in all upload primitives!
fixed #3435: Switching the changeset type deletes any changeset tags that have been set
fixed #3430: Entering comment=* manually in the changeset tags dialog gets ignored
fixed #3431: Upload dialog pops up again if no comment is provided
fixed #3429: created_by=* includes the wrong language when uploading from a new layer

comment:2 Changed 4 years ago by avar

  • Resolution fixed deleted
  • Status changed from closed to reopened

This is happening again on r2339 and I can consistently reproduce it using the steps outlined in the initial report.

comment:3 Changed 4 years ago by Gubaer

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2358]) fixed #3305: Version is UNKNOWN
fixed #3429: created_by=* includes the wrong language when uploading from a new layer

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed .
as The resolution will be set. Next status will be 'closed'.
The resolution will be deleted. Next status will be 'reopened'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.