Changeset 2055 in josm

Timestamp:

04.09.2009 19:47:18 (3 years ago)

Author:

Gubaer

Message:

fixed #3393: loooong delay when using presets with a large osm file
Initializing only one cache for autocompletion; now initializing in background thread, preset dialog should pop up immediately

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -68 +68 @@
     public String locale_name;
 
+    private static AutoCompletionList autoCompletionList;
+
+    public static AutoCompletionList getPresetAutocompletionList() {
+        if (autoCompletionList == null) {
+            autoCompletionList = new AutoCompletionList();
+        }
+        return autoCompletionList;
+    }
+
     public static abstract class Item {
         protected void initAutoCompletionField(AutoCompletingTextField field, String key) {
             OsmDataLayer layer = Main.main.getEditLayer();
             if (layer == null) return;
-            AutoCompletionCache cache = AutoCompletionCache.getCacheForLayer(layer);
-            AutoCompletionList list = new AutoCompletionList();
-            cache.populateWithValues(list, false /* don't append */);
-            field.setAutoCompletionList(list);
+            field.setAutoCompletionList(getPresetAutocompletionList());
         }
 
@@ -640 +646 @@
     }
 
+    protected void refreshAutocompletionList(final OsmDataLayer layer) {
+        Runnable task = new Runnable() {
+            public void run() {
+                System.out.print("refreshing preset auto completion list ...");
+                AutoCompletionCache.getCacheForLayer(layer).initFromDataSet();
+                AutoCompletionCache.getCacheForLayer(layer).populateWithValues( getPresetAutocompletionList(), false /* don't append */);
+                System.out.println("DONE");
+            }
+        };
+        new Thread(task).run();
+
+    }
     public PresetPanel createPanel(Collection<OsmPrimitive> selected) {
         if (data == null)
@@ -645 +663 @@
         OsmDataLayer layer = Main.main.getEditLayer();
         if (layer != null) {
-            AutoCompletionCache.getCacheForLayer(layer).initFromDataSet();
+            refreshAutocompletionList(layer);
         }
         PresetPanel p = new PresetPanel();