Modify

Opened 6 years ago

Last modified 6 years ago

#9857 new defect

Address Preset doesn't keep the entry from before

Reported by: mikecc Owned by: team
Priority: normal Milestone:
Component: Internal preset Version: latest
Keywords: template_report address prefill Cc: simon04

Description

What steps will reproduce the problem?

  1. Mark a node which is already an address or add address information with Presets/ Annotations/ Adresses (e.g. addr:street is filled) -> Apply Preset
  2. Mark the next node(s) which should get the same value (tag addr:street does not exist for these nodes resp. is still empty).

What is the expected result
Now I expect in Presets/ Annotations/ Adresses/ Street Name is filled with the same string as before.

What happens instead?
Presets/ Annotations/ Adresses/ Street Name is empty

Please provide any additional information below. Attach a screenshot if
possible.
Workaround could be the HouseNumberTaggingTool ("k"). That tool reacts as whished (the values used before are kept), but it's not useful for me, because I want to change multiple addresses at the same time. With HNTT you can only change one address once.

The address preset worked until about 8 weeks ago how I needed it. If multiple addresses are marked and I use the tool, already set tags with different values (e.g. addr:housenumber) are marked as "<different>", unset tags are filled with the value. After "Apply Preset" already set values are kept, new are added.

User: MikeCC

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-02-27 09:27:48
Last Changed Author: simon04
Revision: 6891
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-02-27 08:25:03 +0100 (Thu, 27 Feb 2014)
Last Changed Rev: 6891

Identification: JOSM/1.5 (6891 en) Linux Ubuntu 12.04.4 LTS
Memory Usage: 138 MB / 880 MB (56 MB allocated, but free)
Java version: 1.6.0_30, Sun Microsystems Inc., OpenJDK 64-Bit Server VM
Java package: openjdk-6-jre:amd64-6b30-1.13.1-1ubuntu2~0.12.04.1
WebStart package: icedtea-netx:amd64-1.2.3-0ubuntu0.12.04.4
VM arguments: [-Xbootclasspath/a:/usr/share/icedtea-web/netx.jar, -Xms8m, -Dicedtea-web.bin.name=javaws, -Dicedtea-web.bin.location=/usr/bin/javaws, -Djava.security.manager, -Djava.security.policy=/etc/icedtea-web/javaws.policy]
Dataset consistency test: No problems found

Plugin: HouseNumberTaggingTool (30277)
Plugin: RoadSigns (30277)
Plugin: colorscheme (27679)
Plugin: download_along (30277)
Plugin: reverter (30307)
Plugin: turnrestrictions (30307)

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by mikecc

Happily, I found an old josm.jar (5576) on my PC. With that Address Preset works fine. Would be great if it could be fixed in the newer versions.
Tested the behaviour additionally today with 6950 - doesn't work yet...

comment:2 in reply to:  1 ; Changed 6 years ago by skyper

Replying to mikecc:

Happily, I found an old josm.jar (5576) on my PC. With that Address Preset works fine. Would be great if it could be fixed in the newer versions.
Tested the behaviour additionally today with 6950 - doesn't work yet...

Please, could you try with some other versions ?
Have a look at download and the subfolder Archiv for older versions and start them on the terminal with java -jar josm-snapshot-XXXX.jar where XXXX is the version number.

Do not forget to add the plugin version.

Thanks

comment:3 Changed 6 years ago by skyper

By the way, you are still using openjdk-6 which will be only supported for the next two month. Try to use openjdk-7 if possible.

comment:4 in reply to:  2 ; Changed 6 years ago by mikecc

Replying to skyper:
Hi skyper,
thx for the response. In the meantime I did a look in the Archive and tried several snapshots. So I found out 6767 still works for me, 6780 not anymore. That helped me to narrow it down to r6772 which "fixed" ticket #8413 .
The feature with prefilled values has been declared there as a bug.
I would see me as a heavy address contributor. My workflow is to take over the housenumbers (not the streetname etc.) from released official sources. osmwiki:Maps4BW
I add the housenumbers for a certain area, go later to this area and check and add/correct them on the tablet (offline) if
I see conflicts to the reality. Then at home I add my observations and complete the addresses (incl. streetname, place, zipcode etc.) in interaction with mappaint styles (colored addresses etc.) There is the prefilled data extremly helpful and efficient.
I can imagine this is a tricky situation. I don't expect 2 presets, but would really like to be able to switch on the old behaviour (eg. in Advanced Prefs or as an extra downloadable Preset or whatever). In the meantime I can use the current JOSM for standard work and 6767 (how long?) for address completion.
With the Java thing: I've seen this too and have updated already.

Replying to mikecc:

Happily, I found an old josm.jar (5576) on my PC. With that Address Preset works fine. Would be great if it could be fixed in the newer versions.
Tested the behaviour additionally today with 6950 - doesn't work yet...

Please, could you try with some other versions ?
Have a look at download and the subfolder Archiv for older versions and start them on the terminal with java -jar josm-snapshot-XXXX.jar where XXXX is the version number.

Do not forget to add the plugin version.

Thanks

Last edited 6 years ago by skyper (previous) (diff)

comment:5 in reply to:  4 ; Changed 6 years ago by skyper

Cc: simon04 added
Keywords: address prefill added
Reporter: changed from anonymous to mikecc
Version: latest

Replying to mikecc:

Replying to skyper:

thx for the response. In the meantime I did a look in the Archive and tried several snapshots. So I found out 6767 still works for me, 6780 not anymore. That helped me to narrow it down to r6772 which "fixed" ticket #8413 .

Thanks for investigating. Is it now a feature or a bug ?

Clean solution is to make it configurable, you are right.

The feature with prefilled values has been declared there as a bug.
I would see me as a heavy address contributor. My workflow is to take over the housenumbers (not the streetname etc.) from released official sources. osmwiki:Maps4BW
I add the housenumbers for a certain area, go later to this area and check and add/correct them on the tablet (offline) if
I see conflicts to the reality. Then at home I add my observations and complete the addresses (incl. streetname, place, zipcode etc.) in interaction with mappaint styles (colored addresses etc.) There is the prefilled data extremly helpful and efficient.
I can imagine this is a tricky situation. I don't expect 2 presets, but would really like to be able to switch on the old behaviour (eg. in Advanced Prefs or as an extra downloadable Preset or whatever).

The preset will not work. See simon04's comment on #8413.

In the meantime I can use the current JOSM for standard work and 6767 (how long?) for address completion.

As long as you only use it offline for your address maybe for a life time or longer. Problems usually arise if something on the server (OSM) changes, like paths and API, e.g. you could still use a new version to download/upload but for sure no bugs will be fixed as it is only a snapshot.

With the Java thing: I've seen this too and have updated already.

Nice

comment:6 in reply to:  5 ; Changed 6 years ago by mikecc

Replying to skyper:

Replying to mikecc:

Replying to skyper:

thx for the response. In the meantime I did a look in the Archive and tried several snapshots. So I found out 6767 still works for me, 6780 not anymore. That helped me to narrow it down to r6772 which "fixed" ticket #8413 .

Thanks for investigating. Is it now a feature or a bug ?

Maybe it's philosophy :-)
For me it's a bug - something what worked fine before does not work anymore. I think the original setting use_last_as_default was done by purpose. The discussion in #8413 shows me that there was an uncertainty in the beginning (before the change). On the other handside I have a certain understanding that it can be confusing for beginners.

Clean solution is to make it configurable, you are right.

Would be great. Standard can be as it is now, so beginners are not confused. But an option for "power address mappers" should be there to make the prefill available again.

The feature with prefilled values has been declared there as a bug.
I would see me as a heavy address contributor. My workflow is to take over the housenumbers (not the streetname etc.) from released official sources. osmwiki:Maps4BW
I add the housenumbers for a certain area, go later to this area and check and add/correct them on the tablet (offline) if
I see conflicts to the reality. Then at home I add my observations and complete the addresses (incl. streetname, place, zipcode etc.) in interaction with mappaint styles (colored addresses etc.) There is the prefilled data extremly helpful and efficient.
I can imagine this is a tricky situation. I don't expect 2 presets, but would really like to be able to switch on the old behaviour (eg. in Advanced Prefs or as an extra downloadable Preset or whatever).

The preset will not work. See simon04's comment on #8413.

In the meantime I can use the current JOSM for standard work and 6767 (how long?) for address completion.

As long as you only use it offline for your address maybe for a life time or longer. Problems usually arise if something on the server (OSM) changes, like paths and API, e.g. you could still use a new version to download/upload but for sure no bugs will be fixed as it is only a snapshot.

With the Java thing: I've seen this too and have updated already.

Nice

comment:7 in reply to:  6 Changed 6 years ago by simon04

Replying to mikecc:

Clean solution is to make it configurable, you are right.

Would be great. Standard can be as it is now, so beginners are not confused. But an option for "power address mappers" should be there to make the prefill available again.

Having a flag in the advanced preferences would be easy to implement (at the location of !presetInitiallyMatches in TaggingPresetItems.java in the source code). However, also a "power address mapper" might then enter unwanted address tags when using the preset for updating/correcting objects.

I don't see a way how JOSM could distinguish the "mapping many new addresses" from "updating a few addresses" use-case. Does anyone?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to mikecc
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.