Modify

Opened 10 years ago

Closed 4 years ago

Last modified 4 years ago

#9836 closed defect (fixed)

crossing barrier and highway is not reported

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 20.01
Component: Core validator Version:
Keywords: barrier highway crossing regression Cc:

Description (last modified by skyper)

According to Barriers "If a linear barrier crosses a highway, they must connect with a node at intersection. Always tag this node with the appropriate node-barrier tag" but this is currently not reported. I attach osm testcase.

Attachments (4)

testcase.osm (804 bytes ) - added by mkoniecz 10 years ago.
9836.patch (13.2 KB ) - added by GerdP 4 years ago.
detect crossings barrier/building, barrier/highway, barrier/railway, barrier/waterway, and barrier/way
9836-v2.patch (11.9 KB ) - added by GerdP 4 years ago.
cleaned patch
9836-v3.patch (12.7 KB ) - added by GerdP 4 years ago.
improved unit test

Download all attachments as: .zip

Change History (20)

by mkoniecz, 10 years ago

Attachment: testcase.osm added

comment:1 by skyper, 10 years ago

Of course, they need to have the same layer value.

comment:2 by Don-vip, 10 years ago

Component: CoreCore validator
Summary: crossing barrier and highway is not reported by validatorcrossing barrier and highway is not reported

comment:3 by skyper, 4 years ago

Description: modified (diff)
Keywords: barrier highway crossing added
Version: tested

comment:4 by skyper, 4 years ago

Version: tested

Still reproducible

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-01-13 00:44:06 +0100 (Mon, 13 Jan 2020)
Revision:15697
Build-Date:2020-01-13 02:30:54
URL:https://josm.openstreetmap.de/svn/trunk

comment:5 by GerdP, 4 years ago

I think there is actually no code to detect this case. We report crossing barriers and crossing highways but not a mix of both.
@Dirk: Maybe it was reported before r6581. Do you remember why you added a special test for barriers?

comment:6 by stoecker, 4 years ago

#8220. ;-)

Highway and barrier was not asked for yet I'd say :-)

in reply to:  6 comment:7 by stoecker, 4 years ago

Replying to stoecker:

#8220. ;-)

Highway and barrier was not asked for yet I'd say :-)

Well, as this ticket is 6 years old I'd reword this to "was not implemented yet".

comment:8 by GerdP, 4 years ago

I think it was implemented before r6581, but probably the old implementation caused too many false positives?

by GerdP, 4 years ago

Attachment: 9836.patch added

detect crossings barrier/building, barrier/highway, barrier/railway, barrier/waterway, and barrier/way

comment:9 by GerdP, 4 years ago

Hmm, not sure about barrier/way. Probably never happens because of the filter implemented with ignoreWaySegmentCombination()

comment:10 by GerdP, 4 years ago

Milestone: 20.01

in reply to:  8 comment:11 by skyper, 4 years ago

Should the changes on src/org/openstreetmap/josm/gui/NavigatableComponent.java be part of the patch ?

Replying to GerdP:

I think it was implemented before r6581, but probably the old implementation caused too many false positives?

Yes, was implemented years ago.

by GerdP, 4 years ago

Attachment: 9836-v2.patch added

cleaned patch

comment:12 by stoecker, 4 years ago

Hmm. Isn't the idea of unit tests that you expand them when changing code instead of reducing them?

Last edited 4 years ago by stoecker (previous) (diff)

by GerdP, 4 years ago

Attachment: 9836-v3.patch added

improved unit test

comment:13 by GerdP, 4 years ago

Not sure if this is a false positive? way 617592269 & way 617380123 give Crossing barrier/highway
barrier=retaining_wall / highway=steps

I see a lot of new crossing warnings in Genua.

in reply to:  13 comment:14 by skyper, 4 years ago

Replying to GerdP:

Not sure if this is a false positive? way 617592269 & way 617380123 give Crossing barrier/highway
barrier=retaining_wall / highway=steps

I would say no. Either a common node with barrier=entrance or a spit of the barrier=* in two pieces is needed.
Alternativly, layer=*could be used.

I see a lot of new crossing warnings in Genua.

The test was silent for years!

comment:15 by GerdP, 4 years ago

Resolution: fixed
Status: newclosed

In 15704/josm:

fix #9836: crossing barrier and highway is not reported (regressin of r6581)

  • detect crossings between barrier/building, barrier/highway, barrier/railway, and barrier/waterway
  • remove CrossingWays.Barrier class and add check barrier in standard test CrossingWays.Ways

comment:16 by GerdP, 4 years ago

Keywords: regression added

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.