crossing barrier and highway is not reported

[mkoniecz]

According to ​Barriers "If a linear barrier crosses a highway, they must connect with a node at intersection. Always tag this node with the appropriate node-barrier tag" but this is currently not reported. I attach osm testcase.

[skyper]

Of course, they need to have the same layer value.

[skyper]

Still reproducible

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-01-13 00:44:06 +0100 (Mon, 13 Jan 2020)
Revision:15697
Build-Date:2020-01-13 02:30:54
URL:https://josm.openstreetmap.de/svn/trunk

[GerdP]

I think there is actually no code to detect this case. We report crossing barriers and crossing highways but not a mix of both.
@Dirk: Maybe it was reported before r6581. Do you remember why you added a special test for barriers?

[stoecker]

#8220. ;-)

Highway and barrier was not asked for yet I'd say :-)

[stoecker]

Replying to stoecker:

#8220. ;-)

Highway and barrier was not asked for yet I'd say :-)

Well, as this ticket is 6 years old I'd reword this to "was not implemented yet".

[GerdP]

I think it was implemented before r6581, but probably the old implementation caused too many false positives?

[GerdP]

detect crossings barrier/building, barrier/highway, barrier/railway, barrier/waterway, and barrier/way

[GerdP]

Hmm, not sure about barrier/way. Probably never happens because of the filter implemented with ignoreWaySegmentCombination()

[skyper]

Should the changes on src/org/openstreetmap/josm/gui/NavigatableComponent.java​ be part of the patch ?

Replying to GerdP:

I think it was implemented before r6581, but probably the old implementation caused too many false positives?

Yes, was implemented years ago.

[GerdP]

cleaned patch

[stoecker]

Hmm. Isn't the idea of unit tests that you expand them when changing code instead of reducing them?

[GerdP]

improved unit test

[GerdP]

Not sure if this is a false positive? way 617592269 & way 617380123 give Crossing barrier/highway
barrier=retaining_wall / highway=steps

I see a lot of new crossing warnings in Genua.

[skyper]

Replying to GerdP:

Not sure if this is a false positive? way 617592269 & way 617380123 give Crossing barrier/highway
barrier=retaining_wall / highway=steps

I would say no. Either a common node with barrier=entrance or a spit of the barrier=* in two pieces is needed.
Alternativly, layer=*could be used.

I see a lot of new crossing warnings in Genua.

The test was silent for years!

[GerdP]

In 15704/josm:

fix #9836: crossing barrier and highway is not reported (regressin of r6581)

• detect crossings between barrier/building, barrier/highway, barrier/railway, and barrier/waterway
• remove CrossingWays.Barrier class and add check barrier in standard test CrossingWays.Ways