Modify

Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#9307 closed enhancement (fixed)

[patch] Stop listing maxspeed values in "Presets do not contain property value"

Reported by: mkoniecz Owned by: team
Priority: minor Milestone: 13.11
Component: Core validator Version:
Keywords: Cc:

Description

Maxspeed values are already verified by "unusual maxspeed format - Suspicious tag/value combinations" test.

Related to #9280 (the same situation but with height)

osmwww:browse/way/126106953

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-11-09 02:35:12
Last Changed Author: Don-vip
Revision: 6381
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-11-08 14:41:01 +0100 (Fri, 08 Nov 2013)
Last Changed Rev: 6381

Identification: JOSM/1.5 (6381 en_GB) Windows 7 32-Bit
Memory Usage: 80 MB / 247 MB (23 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: notes (v0.6)

Change History (8)

comment:1 by skyper, 11 years ago

Do not really understand where and how ignoretags.cfg is used.

  • is it only used for the test which are run against the preset data
  • are these tags complete excluded from the test defined in tagchecker.cfg

Note: We have a test for maxspeed to look for an appropriate "major" key in tagchecker.cfg which I would like to keep.

comment:2 by mkoniecz, 11 years ago

Invalid height value is detected in osmwww:browse/way/239802684 after r6369 (fixing #9280)

by skyper, 11 years ago

Attachment: josm_9307.diff added

patch

in reply to:  2 comment:3 by skyper, 11 years ago

Replying to Bulwersator:

Invalid height value is detected in osmwww:browse/way/239802684 after r6369 (fixing #9280)

Well, then it is only an one line patch. Please find it attached.
Did not add it to #8966 as not translations are needed.

comment:4 by skyper, 11 years ago

Priority: normalminor
Summary: Stop listing maxspeed values in "Presets do not contain property value"[patch] Stop listing maxspeed values in "Presets do not contain property value"

comment:5 by Don-vip, 11 years ago

Resolution: fixed
Status: newclosed

In 6382/josm:

fix #9307 - ignore maxspeed in tagchecker (patch by skyper)

comment:6 by Don-vip, 11 years ago

Milestone: 13.11 (6383)

comment:7 by stoecker, 8 years ago

Milestone: 13.11 (6383)13.11

Milestone renamed

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.