Modify

Opened 11 years ago

Closed 8 months ago

#9296 closed enhancement (fixed)

report missing (oneway:bicycle) for ways with (oneway=yes) and ((cycleway=opposite_lane) or (cycleway=opposite))

Reported by: mkoniecz Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: cycleway, opposite, oneway, bicycle Cc:

Description (last modified by skyper)

Example of edit fixing this problem: osmwww:browse/changeset/18794423

This condition was tested in my personal validator (see https://github.com/Bulwersator/bicycle_map_of_Krakow/blob/0571ff154f5093c4fba25b62374e867bb738a98d/generate.rb#L65)

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2013-11-09 02:35:12
Last Changed Author: Don-vip
Revision: 6381
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2013-11-08 14:41:01 +0100 (Fri, 08 Nov 2013)
Last Changed Rev: 6381

Identification: JOSM/1.5 (6381 en_GB) Windows 7 32-Bit
Memory Usage: 247 MB / 247 MB (62 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugin: OpeningHoursEditor (29854)
Plugin: notes (v0.6)

Change History (9)

comment:1 by mkoniecz, 11 years ago

Additional note: it should expect "oneway:bicycle" not just "oneway:bicycle=no" as there is possibility for degenerate situation where way is oneway in one direction and there is opposite/opposite_lane for bicycles - but way is oneway also for bicycle in opposite direction (AFAIK - this would be tagged with oneway:bicycle=-1). In my linked test I check only oneway:bicycle=no as I know that there is no example of something like this in my city.

comment:2 by skyper, 11 years ago

Description: modified (diff)
Keywords: cycleway opposite oneway bicycle added

comment:3 by skyper, 11 years ago

Description: modified (diff)

comment:4 by mkoniecz, 11 years ago

Another edit adding missing oneway:bicycle=no - https://www.openstreetmap.org/changeset/26218267

User who added contraflow tag was using JOSM - see https://www.openstreetmap.org/way/47384265/history (edit: https://www.openstreetmap.org/changeset/26029478 )

comment:5 by Don-vip, 6 years ago

Keywords: cycleway opposite oneway bicycle → cycleway, opposite, oneway, bicycle

comment:6 by anonymous, 6 years ago

mkoniecz can you make a patch? It looks easy to fix.

comment:7 by skyper, 5 years ago

Ticket #17590 has been marked as a duplicate of this ticket.

comment:8 by skyper, 4 years ago

See also #17488.

comment:9 by Famlam, 8 months ago

Resolution: fixed
Status: newclosed

As of r19212 JOSM will issue a warning and add oneway:bicycle=no (if not present yet) for ways with cycleway=opposite*, so I guess this is fixed?

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.