[patch] New power substations specifications

[francois.lacombe@…]

Hello,

The power substations refinement proposal had been accepted. Some presets in JOSM need to be edited or enhanced.

First of all, power=sub_station and power=station are fully deprecated. Warnings are needed.
power=substation (full replacement of power=sub_station) is introduced to map sites where power is transformed. It includes large areas where high voltage power stuff can be found or even small cabinets with local transformers inside.
​http://wiki.openstreetmap.org/wiki/Proposed_features/Substation_refinement

Additional things like switches, converters, compensators or even special tag for power lines inside substation are now described.
If wished, I can help to find a good way to have presets in JOSM for these features. Let me know.
voltage=* values are the same as fixed previously in #8847

Mappaint style, especially with power need to be updated.

Polderruner and I are available to answer any questions.

Thanks in advance to support theses changes.

[skyper]

I try to find some time to look into it.

One thing we often miss are nice icons. Do you have any or know where to find them ?

[francois.lacombe]

I've just written a mail on @talk mailing-list to find someone who can draw a set of consistent icons to identify all features the same way once and for all.

I'll let you know if it's possible to do so or not.

[Don-vip]

​http://mapicons.nicolasmollet.com/category/markers/industry/electric-power/

[francois.lacombe]

I've mailed Nicolas Mollet with a list of icons which can complete its "power" collection.

Then, JOSM, wiki, renders and other tools will use the same.

Wait & see for availability.

[Don-vip]

Ticket #9236 has been marked as a duplicate of this ticket.

[skyper]

Replying to francois.lacombe@…:

I've mailed Nicolas Mollet with a list of icons which can complete its "power" collection.

Sadly they are only available as png and not as svg.

[francois.lacombe]

Good point.

I'm going to ask him if he can produce them in svg instead of bitmap.

He just sent me a set of new items and they suit our needs for now.

I'll let you know when this fresh stuff is available.

[francois.lacombe]

He can't produce those icons in svg, there are only available as bitmap.

Is SVG mandatory ?

[skyper]

Replying to francois.lacombe@…:

He can't produce those icons in svg, there are only available as bitmap.

Is SVG mandatory ?

Not that I know, but I try to use SVG if possible and considering usability it would be easier no matter what size you need.

[francois.lacombe]

Understood.
Having different styles and redraw icons with different colors on the fly is a great thing here.
If you don't mind we'll go on with this set. Icons are the same style, can be and actually already used on some renders.

Do you need some extra hints to update presets ?

[Don-vip]

These icons are really great, PNG is fine :)

[skyper]

Replying to francois.lacombe@…:

Understood.
Having different styles and redraw icons with different colors on the fly is a great thing here.
If you don't mind we'll go on with this set. Icons are the same style, can be and actually already used on some renders.

Well, as long as we do not find better suited ones.

Do you need some extra hints to update presets ?

Actually, I was gonna ask on tagging@osm about substation=*. We need some pictures to better illustrate the different values.

[skyper]

Replying to Don-vip:

These icons are really great, PNG is fine :)

Well, wich colour and which style then ?

[Don-vip]

Style: simple (the last one).
Colour: The one you prefer :) I trust you :)

[francois.lacombe]

We'll have to wait a little more time since all icons aren't drawn yet.

I'm working on this point with Nicolas Mollet directly and let you know when all be ready.

The look and feel is definitely up to JOSM team.

[skyper]

Grrr the simple style png contain transparent space one the edges. Gonna have to use imagemagick to cut it off.

I had a look at them with gimp and they are really tiny. Upscaling gets quite fast ugly.

[skyper]

trimmed icons

[skyper]

Replying to skyper:

Grrr the simple style png contain transparent space one the edges. Gonna have to use imagemagick to cut it off.

Well convert -trim works but now all images have an individual size. Have a look at the attached archive​

[skyper]

patch

[skyper]

I did upload a first patch​.

I did update substation plus added transformer and switchgear + details. I played a bit with icons, though I do not know which tags will get their own new icon.

Please, have a look at it.

Thought we already have icons for power=plant and power=generator in the default style, but did not find them.

[Don-vip]

You should rename "Sub Station" to substation ;)

[skyper]

I found the icons and did change two more. Overall we could use a lot of icons (generator:method, generator:source ...) if we want to add them to the value list.

Find version 2​ with small updates.

[skyper]

patch version 2

[skyper]

Think we can apply the patch and update the icons later (one by one).

There are some SVG icons available on the web but no complete set. So no proper solution either.

• Validator needs to be adjusted along
• Style needs to be enhanced/updated

[francois.lacombe]

Hi skyper, thank you for the presets update. I'm ok with it.

Regarding icons, Nicolas Mollet and I didn't agree on the right price to pay for some additional icons. We (OSM) should look for another collection since he doesn't want to finalize the project (a bit shame cause the icons had a good looking in previews).

I can help on validator if you want :

• Warn about station, sub_station deprecation
• Warn about substation/transformer without operator=*

Anything else ?

For styles, I don't use them so much, maybe others would have useful comments.

[Don-vip]

It's a shame we don't deserve some free icons as a well known open source project. Hopefully we don't ask money each time we write some code :D

[simon04]

Concerning icons: did you check ​http://thenounproject.com/en-us/search/?q=power?

[skyper]

We can always add better icons later. I am in favour of adding these new presets without new icons.

[skyper]

Replying to francois.lacombe@…:

I can help on validator if you want :

• Warn about station, sub_station deprecation
• Warn about substation/transformer without operator=*

Patches are always welcome but probably better suited in an own ticket.

[simon04]

Is the patch ready for inclusion (minus the icons)?

One remark: match="keyvalue" is default for <key> (so <key key="line" value="bay" match="keyvalue" /> is conciser written as <key key="line" value="bay" />).

I'll attach attachment:josm_9169_v3.diff​ with with the rejected patch hunk manually applied and some minor changes.

[Don-vip]

In 6657/josm:

fix #9553, see #9169 - display power=substation

[skyper]

Replying to simon04:

Is the patch ready for inclusion (minus the icons)?

All approved and used tags are included. - Yes.

One remark: match="keyvalue" is default for <key> (so <key key="line" value="bay" match="keyvalue" /> is conciser written as <key key="line" value="bay" />).

I'll attach attachment:josm_9169_v3.diff​ with the rejected patch hunk manually applied and some minor changes.

Thanks, still not expert with "match".

At least validator needs to accept the new values. I did create #9555 for this.

[Don-vip]

In 6659/josm:

fix #9555, see #9169 - take into account power=substation into power lines validator test

[simon04]

In 6662/josm:

fix #9169 - New power substations presets - patch by skyper

[Don-vip]

In 6664/josm:

see #9169 - fix wiki links

[aceman]

Please add context to the combo values in the new presets for proper translation.

[simon04]

To which ones exactly?

[aceman]

<combo key="substation"
<combo key="location"
<combo key="transformer"

[simon04]

In 6673/josm:

see #9169 - Add i18n context to power preset strings

[Don-vip]

In 6688/josm:

see #9169, fix #9579 - power=substation in deprecated.mapcss

[bastiK]

ref #9766