Modify

Opened 6 years ago

Closed 6 years ago

Last modified 22 months ago

#9166 closed enhancement (fixed)

[patch] add official_name key to presets

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 13.12
Component: Internal preset Version:
Keywords: Cc:

Attachments (4)

josm_9166.diff (12.6 KB) - added by skyper 6 years ago.
patch
font.svg (10.2 KB) - added by skyper 6 years ago.
icon from www.wowwiki.com/File:Icon-font.svg (License CC-BY-SA)
josm_9166_v2.diff (12.6 KB) - added by skyper 6 years ago.
patch version 2
josm_9166_v3.diff (11.9 KB) - added by skyper 6 years ago.
patch version 3

Download all attachments as: .zip

Change History (25)

comment:1 Changed 6 years ago by Don-vip

Component: CoreInternal preset

comment:2 Changed 6 years ago by skyper

Where is it needed ? In all presets with name=* or only in some ?

What about short_name ? (taginfo)

comment:3 Changed 6 years ago by mkoniecz

In all presets, everywhere there is a risk of obnoxiously long and unused official names. short_name also seems to be OK and usable everywhere where name would be used.

comment:4 in reply to:  3 Changed 6 years ago by skyper

Replying to Bulwersator:

In all presets, everywhere there is a risk of obnoxiously long and unused official names. short_name also seems to be OK and usable everywhere where name would be used.

This would blow up the preset. Looking at the combinations the tags are used with highway, amenity and place.

I really look forward to have grouping within preset syntax and some system to hide/unhide or even link to other preset.

Only looking at *name* we have:

  1. name
  2. name:[LC]
  3. int_name
  4. old_name
  5. official_name
  6. loc_name
  7. reg_name
  8. short_name
  9. nat_name

Think the best we for now would be an new preset item name with all the variants and match=key set.

comment:5 Changed 6 years ago by skyper

I would suggest to create an own "name" preset with all the variants which could be link in future from every other preset and which have a link from tag dialog once *name* exists.

Does the function for LC in addr:country also work for name:LC , guess not ?
A variable tag seems not to be supported so far.

Changed 6 years ago by skyper

Attachment: josm_9166.diff added

patch

comment:6 Changed 6 years ago by skyper

Summary: add official_name key to presets[Draft patch] add official_name key to presets

Please find attached draft patch which adds all the above mentioned names except of the language code example plus adds a lot of wiki links and removes roof from "residential buildings".

  • Did not solve the language code problem
  • an icon is missing so far

Changed 6 years ago by skyper

Attachment: font.svg added

icon from www.wowwiki.com/File:Icon-font.svg (License CC-BY-SA)

Changed 6 years ago by skyper

Attachment: josm_9166_v2.diff added

patch version 2

comment:7 Changed 6 years ago by skyper

Summary: [Draft patch] add official_name key to presets[patch] add official_name key to presets

I did find an icon and update the patch.

Think it can be applied as including name:<lc> is out of scope and needs deeper changes/enhancements.

Please find version 2.

comment:8 Changed 6 years ago by simon04

Some thoughts:

  • is line 6884, <label text="Edit Garages" /> intended?
  • the "Name" presets is then displayed in the tag togging dialog for every objects with a name set. Do we want this? Alternatively, we could display this preset only if an additional *_name is set (using the match attribute in the XML).

comment:9 in reply to:  8 Changed 6 years ago by skyper

Replying to simon04:

Some thoughts:

  • is line 6884, <label text="Edit Garages" /> intended?

Surely not, thanks for mentioning.

  • the "Name" presets is then displayed in the tag togging dialog for every objects with a name set. Do we want this? Alternatively, we could display this preset only if an additional *_name is set (using the match attribute in the XML).

It would be much nicer, if we had e.g. folding to hide/unhide parts of preset. I did not want to add these lines to all preset containing name, that's the reason I did use the matching. Once name is added you will have the link to add more names. If you drop the match from name the new preset probably won't be noticed by a lot of users.

comment:10 Changed 6 years ago by simon04

I guess, in 90% of the time you won't need an additional *_name, e.g., most of the streets, shops, etc., only have one name. Thus, I wouldn't list the "Name" preset in those cases, but only if a special *_name is set.

Changed 6 years ago by skyper

Attachment: josm_9166_v3.diff added

patch version 3

comment:11 in reply to:  10 Changed 6 years ago by skyper

Replying to simon04:

I guess, in 90% of the time you won't need an additional *_name, e.g., most of the streets, shops, etc., only have one name. Thus, I wouldn't list the "Name" preset in those cases, but only if a special *_name is set.

Best would be to have #8959 implemented that I could add a link next to name on every preset to have this extra preset opened. That is why I did first add the "match" but you are right, it was a bad hack.

Please, find attached version 3, which fixes the two issues mentioned above.

comment:12 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6464/josm:

fix #9166 - new *name preset + add missing links (patch by skyper)

comment:13 Changed 6 years ago by skyper

Resolution: fixed
Status: closedreopened

@Don-vip:
You forgot to add the icon !

comment:14 Changed 6 years ago by simon04

How to correctly attribute the icon (CC-BY-SA)? Or should we use e.g. http://thenounproject.com/term/comment/17394/ instead which is licensed public domain?

comment:15 Changed 6 years ago by simon04

Resolution: fixed
Status: reopenedclosed

In 6470/josm:

fix #9166 - add icon to *name preset

Icon is taken from http://thenounproject.com/term/comment/17394/ (public domain).

comment:16 in reply to:  14 Changed 6 years ago by skyper

Replying to simon04:

How to correctly attribute the icon (CC-BY-SA)? Or should we use e.g. http://thenounproject.com/term/comment/17394/ instead which is licensed public domain?

I am not that familiar with the legal situation but we could simply link to the icon and not include it.

I was looking for a SVG and not for a PNG otherwise I would have had plenty options (this is also true for the power icons). Gonna try to look, once more, through the icons included in debian to find an appropriate one.

Actually, I do not like this icon as it looks more like an icon for "description" or "note" but not for "name".

comment:17 Changed 6 years ago by Don-vip

Maybe we can find a better one, but I didn't like the other one neither.

comment:18 in reply to:  17 ; Changed 6 years ago by skyper

Replying to Don-vip:

Maybe we can find a better one, but I didn't like the other one neither.

Ok, next time just comment, please.

What kind of icon do you have in mind ? More like an icon for fonts selection ?

It is not that easy to find an icon which scops with "name".

comment:19 in reply to:  18 Changed 6 years ago by Don-vip

Replying to skyper:

Ok, next time just comment, please.

The missing icon was not intentional I just didn't see it, sorry. Just to say I prefer simon's one, but I agree it is not perfect, there's surely another one :) Otr if it's too difficult to find a good one, we can also have no icon, I don't see this as a problem if the concept cannot be easily illustrated. It's better than a confusing icon.

comment:20 Changed 6 years ago by Don-vip

Milestone: 13.12 (6502)

comment:21 Changed 22 months ago by stoecker

Milestone: 13.12 (6502)13.12

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.