"building_type without building" warning is strange

[aceman]

In the josm.po file there seems to be a "building_type without building" check in the validator. However there is no mention of this tag on the wiki. There is a "building:type", which just redirects to "building".

So I think check should be changed to "building:type without building" and a new check for "building_type=V is undefined, use building=V".
There is also another key that uses the ":type" schema and that is "generator". So you may want to add a new class of checks for these (similarly to *_type).

Also I would propose to make a generic check for "K:V without K", where K is any key.

I propose all this based on reading the josm.po file. If any of these checks are already implemented then I apologize for the duplicate ticket.

[Don-vip]

Replying to aceman:

Also I would propose to make a generic check for "K:V without K", where K is any key.

Doesn't work for all tags, see generator as example.

[aceman]

Yeah right, those are cases of "K:V=* without X=K". Currently you have "K_type=V without X=K" checks, but only for specific values of X and K. This would probably need data analysis if the rules can be generalized in some way.

[aceman]

What about "K:Y=* AND (X=K OR K=*)" then OK, otherwise warn?

[skyper]

Some numbers for building type (​taginfo).

We should warn about both types. There are no wiki pages for both tags (building:type=* redirects to building=*).

[skyper]

My patch for #8966 disables the check for building_types.

[Don-vip]

In 6384/josm:

fix #8966, fix #9106, fix #9289, fix #9301, fix #9302 - validator/tagchecker: fix various tests (modified patch by skyper)

[stoecker]

Milestone renamed