some color keywords are not translated in Preferences -> Colors (e.g. piste.*)

[aceman]

Most of the color names in Preferences -> Display settings -> Colors are translatable. But there are some special color names that are not. See e.g. piste.*, highway.*, aeroway.*, amenity.*, light.water or emergency.access.point . These are nowhere to be found in the strings to be translated. There are only versions with dot (.) replaced with (underscore). E.g. light_water. Something seems to be wrong here and these strings are differing in the display and the backend.

[stoecker]

I assume these are from external styles. Can you confirm?

[aceman]

I don't think I use any external styles (only some addons). The line is displayed as "Paint style standard: piste.easy |<colorcode>|" .

[AlfonZ]

They are from the internal style:

• piste_easy
• highway_track
• aeroway_dark
• amenity_traffic
• light_water
• emergency_access

It might to do something with ColorProperty.getColorKey.
I tried

src/org/openstreetmap/josm/data/preferences/ColorProperty.java

@@ -40 +40 @@
      * @return The color key for this property
      */
     public static String getColorKey(String colName) {
-        return colName == null ? null : colName.toLowerCase().replaceAll("[^a-z0-9]+",".");
+        return colName == null ? null : colName.toLowerCase().replaceAll("[^a-z0-9_]+",".");
     }
 
     @Override

and it seemed to fix it - names in Color preferences were translated.
However, I haven't looked in depth, and I suspect such change will have consequences.

[stoecker]

In [o29954] I fixed the i18n extraction to match the color code restrictions.

[aceman]

Thanks, so will you summarize here whether the dot form or the underscore form will be valid for translation?

[stoecker]

The variant with dot will be correct, but translator should translate it into human readable format, neither using dot, nor underscore.

[stoecker]

Milestone renamed