Modify

Opened 9 years ago

Closed 8 years ago

#9104 closed enhancement (fixed)

Better handling of semicolon in values: make it harder to add such values

Reported by: skyper Owned by: team
Priority: normal Milestone: 14.02
Component: Core Version:
Keywords: semicolon value Cc:

Description (last modified by Don-vip)

The handling of semicolons could be enhanced. For background please have a look at:

Two points came to my mind:

  1. make it harder to add semicolon separated values when combining by asking the user for interaction for each value with conflict and not automatically adding both values with semicolon as separator.
  2. Validator warnings/errors about semicolons in values where it makes no sense as many keys need single value to work.

Attachments (1)

9104_1.patch (2.1 KB) - added by simon04 8 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 8 years ago by Don-vip

Description: modified (diff)

comment:2 Changed 8 years ago by simon04

Milestone: 14.02
Owner: changed from team to simon04
Summary: Better handling of semicolon in values[Patch] Better handling of semicolon in values

For item 1, the attached patch drops any default tag combining decision. The contained comment states:

// Do not suggest to keep all values in order to reduce the wrong usage of semicolon values, see #9104!
// Do not suggest to keep the single value in order to avoid long highways to become tunnels+bridges+...

For item 2, I would suggest to have a blacklist of keys resulting in a validation warning (like for amenity, …). For all other keys (except for a few whitelisted ones as ref, source) a validation information should be generated.

Since I do expect some discussion for both items, lets keep it for the 14.02 release.

Please assist in providing blacklist+whitelist keys.

Changed 8 years ago by simon04

Attachment: 9104_1.patch added

comment:3 Changed 8 years ago by simon04

In 6770/josm:

see #9104 - Do not suggest to combine conflicting values in order to reduce the wrong usage of semicolon values

comment:4 Changed 8 years ago by simon04

Summary: [Patch] Better handling of semicolon in valuesBetter handling of semicolon in values

comment:5 Changed 8 years ago by simon04

Owner: changed from simon04 to team

comment:6 Changed 8 years ago by simon04

For item 2, here's an analysis based on the TagInfo database: https://gist.github.com/anonymous/9058556

select key, sum(count_all), min(value), max(value) from tags 
where value like '%;%'
group by key
having sum(count_all) > 100

Using this list, we can identify some keys to whitelist.

comment:7 Changed 8 years ago by Don-vip

That's a huge list. Can we sort it by number of total occurrences for each key?

comment:8 Changed 8 years ago by simon04

Here you are: https://gist.github.com/9076516

This has been sorted with the very intuitive command sort --numeric-sort --key 4,4 --field-separator='"' --reverse semicolon.csv ;-)

comment:9 Changed 8 years ago by Don-vip

Summary: Better handling of semicolon in valuesBetter handling of semicolon in values: make it harder to add such values

Point 1 fixed. See #9757 for point 2 in next milestone.

comment:10 Changed 8 years ago by Don-vip

Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.