Ticket #9104: 9104_1.patch

File 9104_1.patch, 2.1 KB (added by simon04, 12 years ago)
  • src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java

    diff --git a/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java b/src/org/openstreetmap/josm/gui/conflict/tags/CombinePrimitiveResolverDialog.java
    index 283a3a6..574747d 100644
    a b public class CombinePrimitiveResolverDialog extends JDialog {  
    281281
    282282    protected void prepareDefaultTagDecisions() {
    283283        TagConflictResolverModel model = getTagConflictResolverModel();
    284         for (int i = 0; i < model.getRowCount(); i++) {
    285             MultiValueResolutionDecision decision = model.getDecision(i);
    286             List<String> values = decision.getValues();
    287             values.remove("");
    288             if (values.size() == 1) {
    289                 decision.keepOne(values.get(0));
    290             } else {
    291                 decision.keepAll();
    292             }
    293         }
     284        model.prepareDefaultTagDecisions();
    294285        model.rebuild();
    295286    }
    296287
  • src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java

    diff --git a/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java b/src/org/openstreetmap/josm/gui/conflict/tags/TagConflictResolverModel.java
    index 924adee..3c0e4fc 100644
    a b public class TagConflictResolverModel extends DefaultTableModel {  
    257257     *
    258258     */
    259259    public void prepareDefaultTagDecisions() {
     260        // Do not suggest to keep all values in order to reduce the wrong usage of semicolon values, see #9104!
     261        // Do not suggest to keep the single value in order to avoid long highways to become tunnels+bridges+...
     262
     263        /*
    260264        for (MultiValueResolutionDecision decision: decisions.values()) {
    261265            List<String> values = decision.getValues();
    262266            values.remove("");
    public class TagConflictResolverModel extends DefaultTableModel {  
    266270                decision.keepAll();
    267271            }
    268272        }
     273        */
    269274        rebuild();
    270275    }
    271276