#9081 closed enhancement (fixed)
[patch] "L" shortcut to nodes
| Reported by: | Owned by: | team | |
|---|---|---|---|
| Priority: | normal | Milestone: | 14.04 |
| Component: | Core | Version: | tested |
| Keywords: | align | Cc: |
Description
L shortcut (align) applied to nodes is great (aligns one node with its neighbours in a way).
It seems acceptable that it does not work when the node is part of 2 ways.
However, when selecting a node that is in two ways, but the last (or first) of one and not the last (or first) of the other, I guess it should align whithin the second, as it cannot be within the first.
A picture may be clearer: the selected node (red one) should be aligned within the lightgray (vertical) way, even if it is also part, but end node, of the green (horizontal) way. Currently, "L" shortcut has no effect.
Attachments (7)
Change History (15)
by , 11 years ago
| Attachment: | josm-align.png added |
|---|
comment:1 by , 11 years ago
by , 10 years ago
| Attachment: | bug9081.patch added |
|---|
by , 10 years ago
| Attachment: | align_single_node_before.jpg added |
|---|
by , 10 years ago
| Attachment: | align_single_node_after.jpg added |
|---|
comment:3 by , 10 years ago
| Summary: | "L" shortcut to nodes → [patch] "L" shortcut to nodes |
|---|
Patch that allow align a single nodes relative to its neighbours.
Before AlignInLineAction:
After:
by , 10 years ago
| Attachment: | bug9081_v2.patch added |
|---|
new version of the patch: little improuvment for prevent stange phenomena with self crossing way
comment:4 by , 10 years ago
If you do a next little improvement, please fix javadoc - there is an empty "@param way" :-) Otherwise we'll do it when applying.
comment:5 by , 10 years ago
| Milestone: | → 14.04 |
|---|
by , 10 years ago
| Attachment: | 9081-self_crossing_way.png added |
|---|
comment:6 by , 10 years ago
The last problem was for self crossing way.
On the picture you can see 2 cases.
At the left, the node must be put at intersection of (AB) abd (CD)
At the right, at the intersection of (AC) and (BD)
I think it is solved in the 3th version of the patch.
by , 10 years ago
| Attachment: | bug9081_v3.patch added |
|---|
This patch is made with git, tell me if it is OK
follow-up: 9 comment:8 by , 10 years ago
BTW: Self-crossing ways are always considered an error. Probably spending much time with them is wasted, a simple error output would be enough (e.g. "This way is self-crossing, fix that first").
If you want - #9873 has another case where a self-overlapping way causes an error.
comment:9 by , 10 years ago
Replying to stoecker:
BTW: Self-crossing ways are always considered an error. Probably spending much time with them is wasted, a simple error output would be enough (e.g. "This way is self-crossing, fix that first").
Why is self crossing way an error? Also when it does have a crossing node? JOSM only warns about such ways so it is not a fatal error yet.
I always use the "select child nodes" function (utils2plugin) but I would prefer to also align several ways and a mix of nodes and ways.