Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#9007 closed defect (fixed)

[patch] possible error in presets for Bridge relation

Reported by: aceman Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: Cc:

Description

http://wiki.openstreetmap.org/wiki/Relations/Proposed/Bridges_and_Tunnels#Members
Way edge :
zero or more alternative to outline, a set of ways which form the edges. Rather than drawing an area, a renderer could then draw the parapet marks as now along these ways. The interior of the bridge should be on the right of these ways (so if we were modelling a simple bridge using this technique, there would be two ways running in opposite directions parallel to and either side of the road-way which passes across the bridge; but this is generalisable to more complex cases: for example, consider a bridge which has a meeting of three ways on top). If neither outline nor edge is given, the "across"/"through" ways would be used to derive a nominal outline for rendering purposes for example.

If I read the presets file correctly, it expects a node, not a way:
<role key="edge" text="nodes forming the outline" requisite="optional" type="node" />

Is that a bug or is the wiki wrong? If a bug then please also correct the text and type.

Attachments (2)

josm_9007.diff (1.8 KB) - added by skyper 7 years ago.
patch update
josm_9007_v2.diff (1.8 KB) - added by skyper 7 years ago.
patch version 2

Download all attachments as: .zip

Change History (10)

comment:1 Changed 7 years ago by Don-vip

Summary: possible error in presets for Bridge relation[patch] possible error in presets for Bridge relation

comment:2 in reply to:  description Changed 7 years ago by skyper

Replying to aceman:

If I read the presets file correctly, it expects a node, not a way:
<role key="edge" text="nodes forming the outline" requisite="optional" type="node" />

Is that a bug or is the wiki wrong? If a bug then please also correct the text and type.

A bug !

Find attached patch to fix it.

Changed 7 years ago by skyper

Attachment: josm_9007.diff added

patch update

comment:3 Changed 7 years ago by skyper

Did change the patch as only using highway as some members is far to restrictive (think about river, pipeline, railway ...)

comment:4 Changed 7 years ago by aceman

Yes, railway must be allowed as the minimum.

comment:5 Changed 7 years ago by Don-vip

what about the wording ? The new patch talks only about "highways" ?

Changed 7 years ago by skyper

Attachment: josm_9007_v2.diff added

patch version 2

comment:6 in reply to:  5 Changed 7 years ago by skyper

Replying to Don-vip:

what about the wording ? The new patch talks only about "highways" ?

Find attached version 2 with fixed wording.

EDT: Validator should warn about nodes as member of type=bridge/tunnel

Last edited 7 years ago by skyper (previous) (diff)

comment:7 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6197/josm:

fix #9007 - fix bridge preset (patch by skyper)

comment:8 Changed 7 years ago by aceman

Looks fine to me, thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.