Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8962 closed enhancement (fixed)

[PATCH] fence_type=chain should be changed to "chain_link"

Reported by: skyper Owned by: team
Priority: minor Milestone:
Component: Internal preset Version:
Keywords: fence type chain Cc:

Description

fence_type=chain is unclear and should be change to chain_link as documented in the wiki

r6135

Attachments (1)

patch_8962_1.diff (801 bytes) - added by dommage 7 years ago.
Proposed diff.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by dommage

Attachment: patch_8962_1.diff added

Proposed diff.

comment:1 Changed 7 years ago by dommage

It looks like chain_link was added to fence_type in data/defaultpresets.xml but in commented out form (r5941).
Taginfo shows that fence_type=chain is still popular (11k), but barrier=chain (2k) and fence_type=chain_link (1k) are definitely being used.

Hedge and chain are full-fledged barrier types and should probably not be in this list.

I have attached a diff that tries to merge the state of the wiki and taginfo for consideration.

wiki: barbed_wire, chain_link, electric, railing, roundpole, split_rail, wood, wire, metal, pole
taginfo: chain, wood, split_rail, barbed_wire, pole, wire, hedge, chain_link, metal...

combined: barbed_wire, chain_link, electric, metal, pole, split_rail, wire, wood

comment:2 Changed 7 years ago by dommage

Summary: fence_type=chain should be changed to "chain_link"[PATCH] fence_type=chain should be changed to "chain_link"

comment:3 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 6157/josm:

fix #8962 - Deprecate fence_type=chain + new validator tests for *_type tags without main tag

comment:4 Changed 7 years ago by aceman

So why do we not support all the values from the wiki? E.g. in our city suburb, most fences I need to tag are 'railing'...

comment:5 Changed 7 years ago by Don-vip

We like to see tags being used a bit before integrating them into internal presets. How often is it used ?

comment:6 Changed 7 years ago by aceman

About 140 times (counting all typos) out of 41 654.
http://taginfo.openstreetmap.org/keys/?key=fence_type#values

I wonder why that is as no other type describes that fence type well. Maybe people just don't set any fence_type in that case. There are 834 364 uses of barrier=fence, so that means people do not add the fence_type in most cases. The high number of wood and split_rail indicates that mostly fences in forests/villages were tagged with the proper type. I think adding the more "city" types would promote the use of the fence_type tag.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.