Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#8556 closed enhancement (fixed)

[PATCH] Added the new layer option in the import remote control handler.

Reported by: ben.abelshausen@… Owned by: team
Priority: normal Milestone:
Component: Core remotecontrol Version: latest
Keywords: Cc:

Description

Added the new layer option in the import remote control handler.

This feature is needed for a new way of working with the HOT tasking manager to provide extra data when editing a task and it was a TODO in the code anyway.

Attachments (2)

import_patch.diff (3.7 KB) - added by ben.abelshausen@… 7 years ago.
ImportHandler.java.patch (1.6 KB) - added by xivk 7 years ago.
New patch!

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by ben.abelshausen@…

Attachment: import_patch.diff added

comment:1 Changed 7 years ago by bastiK

You deleted some code in your patch, please describe why.

comment:2 Changed 7 years ago by anonymous

Hi,

Because i believe the code could be shorter/better specifically in this case when one or more parameters need to be parsed instead of just one. But it's possible i'm wrong.

I'm not an expert when it comes to java but was thinking this contribution was pretty simple.

comment:3 Changed 7 years ago by bastiK

I think the idea is that everything after url= is interpreted as URL, even if it contains & characters. Like for the imagery handler: Help/Preferences/RemoteControl.

comment:4 Changed 7 years ago by anonymous

Yes, the imagery handler does the same: The Request URL, including patterns. Must be the last parameter, everything after "&url=" is interpreted as URL, even if it contains "&" characters.

Thanks for the feedback, will re-implement and re-submit the patch.

comment:5 Changed 7 years ago by Don-vip

Owner: changed from team to ben.abelshausen@…
Status: newneedinfo

Waiting for your new patch

Changed 7 years ago by xivk

Attachment: ImportHandler.java.patch added

New patch!

comment:6 Changed 7 years ago by xivk

Patch is updated now, sorry for the delay, almost forgot about this!

comment:7 Changed 7 years ago by Don-vip

Owner: changed from ben.abelshausen@… to team
Status: needinfonew

Thanks :)

comment:8 Changed 7 years ago by Don-vip

In fact there's a method in super class that can be called as it: isLoadInNewLayer().

comment:9 Changed 7 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 5872/josm:

fix #8556 - Remote Control: add new_layer parameter to import handler

comment:10 Changed 7 years ago by xivk

Nice one! Thanks for fixing this...

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.