#8556 closed enhancement (fixed)
[PATCH] Added the new layer option in the import remote control handler.
| Reported by: | Owned by: | team | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core remotecontrol | Version: | latest |
| Keywords: | Cc: |
Description
Added the new layer option in the import remote control handler.
This feature is needed for a new way of working with the HOT tasking manager to provide extra data when editing a task and it was a TODO in the code anyway.
Attachments (2)
Change History (12)
by , 13 years ago
| Attachment: | import_patch.diff added |
|---|
comment:1 by , 13 years ago
comment:2 by , 13 years ago
Hi,
Because i believe the code could be shorter/better specifically in this case when one or more parameters need to be parsed instead of just one. But it's possible i'm wrong.
I'm not an expert when it comes to java but was thinking this contribution was pretty simple.
comment:3 by , 13 years ago
I think the idea is that everything after url= is interpreted as URL, even if it contains & characters. Like for the imagery handler: Help/Preferences/RemoteControl.
comment:4 by , 13 years ago
Yes, the imagery handler does the same: The Request URL, including patterns. Must be the last parameter, everything after "&url=" is interpreted as URL, even if it contains "&" characters.
Thanks for the feedback, will re-implement and re-submit the patch.
comment:5 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → needinfo |
Waiting for your new patch
comment:8 by , 13 years ago
In fact there's a method in super class that can be called as it: isLoadInNewLayer().
You deleted some code in your patch, please describe why.