Modify

Opened 12 years ago

Closed 12 years ago

#8426 closed enhancement (fixed)

Update version of remote protocol

Reported by: akks Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: remote control Cc: Don-vip

Description (last modified by akks)

I have added empty-value support for load_and_zoom addtags functionality. Tags and values are trimmed now to avoid problems with space-starting tags. = is supported in the value,
Add add tags button (without confirmation) was added.

Empty values leads to deletion of the tag, warning is shown in the confirmation table.
(idea by CupIvan, Russian forum)

New requests are more general, and older JOSM give exceptions:
http://localhost:8111/load_and_zoom?addtags=wikipedia:de=Wei%C3%9Fe_Gasse===|maxspeed%20%20%20=%20%20&select=way23071688,way23076176,way23076177,&left=13.739727546842&right=13.740890970188&top=51.049987191025&bottom=51.048466954325
(maxspeed will be deleted, if exists)

Do we need to increase RemoteControl.protocolMinorVersion or add some extra changes to remote control (maybe fix something) before it?

Attachments (1)

addtags.patch (977 bytes ) - added by akks 12 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 by akks, 12 years ago

Description: modified (diff)

comment:2 by akks, 12 years ago

Summary: Update vaersion of remote protocolUpdate version of remote protocol

comment:3 by akks, 12 years ago

I had one more request from local validator author (CupIvan).
Idea is extremely simple - why does not we have addtags parameter in add_node and add_way parameters?

I noticed that with current code base (thanks to the team!) adding the support is extremely simple, see the patch.

http://localhost:8111/add_node?lon=13.3&lat=53.2&addtags=natrural=tree|name=Great%20Oak

What do you think about it?

Last edited 12 years ago by akks (previous) (diff)

by akks, 12 years ago

Attachment: addtags.patch added

comment:4 by bastiK, 12 years ago

Suggested extension sounds good.

Yes, please increase minor version, whenever you add a new remote control feature and document it in the protocol specification.

We cannot expect remote control users to dig through the code or trac tickets before they can start using it. ;)

comment:5 by Don-vip, 12 years ago

Nice :)

comment:6 by akks, 12 years ago

Ok then, commited. (forgot to add see ...)
I'll edit the wiki too.

In 5659/josm:
RemoteControl API version 1.5: addtags supported by add_node, add_way commands

comment:7 by akks, 12 years ago

Wiki is updated: RemoteControl

Feel free to check and rework functionality or make wiki better (and then close the ticket).

By the way, I noticed multiple EDT violations warning - do not know how to fix it (if needed). Leaving this to authors :)
Code was easy to check and edit, thank you all for good work!

comment:8 by akks, 12 years ago

Resolution: fixed
Status: newclosed

In 5790/josm:

fix #8426: add_tags in remote control: better changed tags detection,
fix EDT violations and NPE when layer is closed while adding tags
added GuiHelper.executeByMainWorkerInEDT to execute GUI-related tasks sequentially from non-EDT threads

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.