Modify ↓

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#8425 closed defect (fixed)

"align in circle" doesn't work as per code comments

Reported by: richlv Owned by: team
Priority: normal Milestone: 14.03
Component: Core Version: tested
Keywords: align node circle Cc:

Description (last modified by Don-vip)

AlignInCircleAction.java comment says :

When is selected node that is part of the way, then make a regular polygon, selected
 node doesn't move.

this currently doesn't work that way, selected node moves as well.

I would also suggest to change some of the comments :

a) "special case if no single nodes are selected and exactly one way is" to
"special case if no nodes are selected and exactly one way is"

b) "When is selected node that is part of the way, then make" to
"When a single node that is part of the way is selected, make"

Attachments (0)

Change History (7)

comment:1 by Don-vip, 12 years ago

see also #8431

comment:2 by richlv, 12 years ago

hmm, my original comment got mutilated a bit :)

"come of the comments :"
was supposed to be
"i would also suggest to change some of the comments :"

comment:3 by Don-vip, 12 years ago

Description: modified (diff)

comment:4 by skyper, 11 years ago

Keywords: align node circle added

comment:5 by Balaitous, 11 years ago

Can be closed due to changes in #8431 .

in reply to:  5 comment:6 by skyper, 11 years ago

Resolution: → fixed
Status: new → closed

fixed in the progress of #8431

Replying to Balaitous:

Can be closed due to changes in #8431 .

You are welcome to close it yourself the next time (it is a wiki).

comment:7 by Don-vip, 11 years ago

Milestone: → 14.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.