Modify

Opened 9 years ago

Closed 8 years ago

#8422 closed defect (fixed)

Role checks in Public Traffic Relations

Reported by: Weide Owned by: team
Priority: normal Milestone: 14.02
Component: Core validator Version:
Keywords: public_transport role check Cc:

Description

Public_transport=platform on a node is ONLY for stops without infrastructure(, except for a pole): No platform, no shelter, no bench, no tactile paving. A platform with infrastructure cannot be expressed as a node using the public traffic proposal and it should not be marked with "wrong type", if it only has highway=bus_stop.

Just the opposite is correct: It's wrong, if a node with public_transport=platform has shelter=yes, bench=yes or tactile_paving=yes.

Attachments (0)

Change History (7)

comment:1 Changed 9 years ago by Weide

I'll try to express it more clearly:

The validation/upload error message "Member for role platform of wrong type (1)" is misleading and often plainly wrong:

It's misleading as the old style tagging of stops is not wrong -- not even deprecated -- and completely compatible with routes of the public traffic proposal.

It's wrong where it refers to a node. A platform with no known details or a platform having some infrastructure cannot be expressed as a node using the public traffic proposal. Node platforms in the public traffic proposal may only be used for waiting position with no reserved waiting place for passengers. The mapper has no choice but to use highway=platform or railway=platform and to leave the public_traffic tag out in this case.

Just the other way round: a node with public_transport=platform combined with tactile_paving=yes or bench=yes is erroneous and should give an error message.

It would be a valuable addon, if just adding a public_transport=platform to a node with *way=platform would result in a message "are you sure, that there is no infrastructure at the platform?" or something like that.

The validation/upload error message "Member for role stop of wrong type (1)" is misleading for the same reason as given above.

comment:2 Changed 9 years ago by Weide

As a workaround, please remove the warnings "Member for role platform of wrong type" and ""Member for role stop of wrong type" completely until the problem can be addressed. Mappers are changing objects from good to bad to get rid of the messages.

comment:3 Changed 8 years ago by Chaos99

Check is still present and also still misleading. Getting errors for highway=bus_stop nodes with role 'stop' in a route relation. If anything, the error should be "wrong tag" and not "wrong type".

comment:4 Changed 8 years ago by skyper

Keywords: public_transport role check added

See also #8266 and #8460

comment:5 Changed 8 years ago by simon04

I agree that this warning is unwanted. Reason: relation is validated also according to new public transport scheme – see also my comment:6:ticket:8255:

For the validation part, I'm currently struggling on the following: We probably shouldn't validate a route relation wrt. the new public transport scheme. Unfortunately, it is impossible to distinguish the old/new scheme from the tags only. A simple version=2 tag for the new schema would've made a lot of things easier.


I guess any attempt to decide apart the older from the newer scheme will be some based on better/worse heuristics. Personally, my motivation to deeply look into PT validation is quite low due to the transition/compatibility mess (see also thread at transit@).

comment:6 Changed 8 years ago by Don-vip

Milestone: 14.02

comment:7 Changed 8 years ago by simon04

Resolution: fixed
Status: newclosed

Fixed in the course of #9545.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.