Guess roles from selected objects tags when creating a relation via presets

[Don-vip]

Use case:

1. Select a street tagged as highway=* and street numbers tagged as addr:housenumber=*
2. Create an Associated Street via the internal presets

The selected objects are automatically added as members, but without any role. JOSM should guess the default roles (street and house) when the objects are correctly tagged.

This could be applied to other relations (bus routes, etc.)

[skyper]

+1

Would be nice for turn-restrictions !

[Don-vip]

Difficult for turn restrictions. How distinguish from and to ? Only via may be guessed.

[skyper]

Replying to Don-vip:

Difficult for turn restrictions. How distinguish from and to ? Only via may be guessed.

You are right, works only for oneway streets.

[simon04]

First working implementation attached. Further ideas: validate this information, also use for relation editor dialog (when adding new members).

[simon04]

also use for relation editor dialog (when adding new members) … ✔

[simon04]

For the validation part, I'm currently struggling on the following: We probably shouldn't validate a route relation wrt. the new public transport scheme. Unfortunately, it is impossible to distinguish the old/new scheme from the tags only. A simple version=2 tag for the new schema would've made a lot of things easier.

[simon04]

In 5614/josm:

see #8255 - suggest roles when adding objects to a relation

[Don-vip]

Wow, nice ! Thanks Simon !

[stoecker]

Hmm, the relation presets more and more becomes what I had in mind when I started it. Nice.

[Don-vip]

In 5615/josm:

see #8255 - only highway is required for role street

[Don-vip]

In 5624/josm:

see #8255 - Use 'type' attribute when specified to filter role candidates (for example, this prevents highway=crossing or highway=street_lampnodes to be added as street members to an associatedStreet relation)