Modify

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#8409 closed enhancement (fixed)

[Patch] barrier=guard_rail not supported

Reported by: Rodolfo Owned by: team
Priority: normal Milestone:
Component: Internal preset Version:
Keywords: barrier Cc:

Description

The guard_rail is still not supported as a barrier type in the menu's.

Attachments (1)

defaultpresets.xml.barrier_update.patch (19.5 KB ) - added by skyper 12 years ago.
patch version 2

Download all attachments as: .zip

Change History (14)

comment:1 by Don-vip, 12 years ago

Component: CoreInternal preset

comment:2 by Don-vip, 12 years ago

Type: defectenhancement

comment:3 by simon04, 12 years ago

Instead of only adding barrier=guard_rail, one might add some other missing barriers listed in http://taginfo.openstreetmap.org/keys/?key=barrier#values.

We are happy to take patches. The starting point would be http://josm.openstreetmap.de/browser/trunk/data/defaultpresets.xml#L1133

comment:4 by Don-vip, 12 years ago

Missing ones with at least 2500 occurences:

  • wire_fence : 9016
  • hedge_bank : 6178
  • embankment : 5382
  • wood_fence : 4750
  • kerb : 3042
  • guard_rail : 2627
  • field_boundary: 2537

in reply to:  4 comment:5 by skyper, 12 years ago

Replying to Don-vip:

Missing ones with at least 2500 occurences:

Not really sure about all of them. Some do not have any info on the wiki. We still have problems with barriers on top of each other (e.g. fence on top of retaining_wall).

  • wire_fence : 9016

Thought this is a regular fence with wire on top.

  • hedge_bank : 6178

embankment with hedge

  • embankment : 5382
  • wood_fence : 4750

fence with material=wood

  • kerb : 3042

+1

  • guard_rail : 2627

+1

  • field_boundary: 2537

What kind of barrier is this ?

in reply to:  4 comment:6 by Don-vip, 12 years ago

Replying to Don-vip:

  • wire_fence : 9016
  • wood_fence : 4750

These two must not be added as we already consider them as deprecated:

        checks.add(new DeprecationCheck(2101).
                testAndRemove("barrier", "wire_fence").
                add("barrier", "fence").
                add("fence_type", "chain"));
        checks.add(new DeprecationCheck(2102).
                testAndRemove("barrier", "wood_fence").
                add("barrier", "fence").
                add("fence_type", "wood"));

comment:7 by skyper, 12 years ago

I did start to update the barrier section of defaultpresets.

There are some changes in the values of fence_type=*:

  • chain was changed to chain_link
  • pole was changed to roundpole
  • hedge was dropped in favour of `barrier=hedge"

If we change these values we also need a validator warning for the deprecated values.

comment:8 by skyper, 12 years ago

Summary: barrier=guard_rail not supported[Patch] barrier=guard_rail not supported

Please find a patch attached.

I did update 2/3 of the barrier section and added guard_rail and kerb.

The new fence_type values are only a comment so far.

Also fixes a typo in the polish wiki link for building.

comment:9 by skyper, 12 years ago

I did finish the last part of updating the barrier section and replace the patch.

I used length="7" for heights and width. Do we need more space for the values or should it be OK ?

by skyper, 12 years ago

patch version 2

comment:10 by skyper, 12 years ago

Forgot: Last thing TODO are to find/create some icons which are missing so for.

comment:11 by Don-vip, 12 years ago

Resolution: fixed
Status: newclosed

In 5941/josm:

fix #8409 - Add missing barriers values to internal presets (patch by skyper)

comment:12 by Don-vip, 12 years ago

Nice. Thanks :)

comment:13 by Don-vip, 12 years ago

In 5943/josm:

see #8409 - Remove empty icons definitions

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.