Replace geometry: save node ids

[anonymous]

Often i use replace geometry to merge a new building, with an addressnode. The way exists of new nodes (not in the osm database) because i made the geometry finer and old nodes (with an id).
Today the function inserts the old node in the new way to preserve history. But sometimes it deletes known nodes and leaves new nodes in the way.
Replace Geometry should search in the geometry to find a node which has no known id (aka negative id) if possible.

[skyper]

See also #9929

[Don-vip]

Ticket #9929 has been marked as a duplicate of this ticket.

[skyper]

example file

[skyper]

Just hit this again. It seems to depend on the distance and/or if multiple way child nodes with id > 0 are closer.

I would say, this is a defect.

Please, find attached example file: josm_8396_sample.osm​

1. Search type:node id:0
2. Select address node and building surrounding the node
3. Replace geometry
4. Search type:node id:0
5. Search all objects for type:node deleted -id:0

Find a deleted node but there are way child nodes with id=0 and only one parent.
If the address node is move close to a node with id:0 the node id is swapped.

Relative:URL: ^/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2020-08-04 23:38:35 +0200 (Tue, 04 Aug 2020)
Revision:16850
Build-Date:2020-08-05 01:30:51
URL:https://josm.openstreetmap.de/svn/trunk

Plugins:
+ utilsplugin2 (35487)

[GerdP]

In 35617/osm:

fix #8396: Replace geometry: save node ids

• "Upgrade a node to a way or multipolygon": try first to find closest new node
• fix some sonarlint and javadoc issues

[GerdP]

In 35618/osm:

see #8396: Replace geometry: save node ids
dist