Style for inner way equals multipolygon weird catch

[grinapo]

I just cannot see why this was reported:
Style for inner way equals multipolygon: Way: 127454772 - Relation: 1725492

Relation is landuse=meadow and has two landuse=grass holes. I see no common tags.

[Don-vip]

This warning is raised because landuse=meadow and landuse=grass have the same style.
You can check it by turning off the map paint style (wireframe view) -> the warning disappears.

[grinapo]

So that's no good. Either both the message text and the related wiki entry should be heavily updated or not reported at all since renderers do not have to use the same style (and some doesn't already).
(Is it a good thing that validation is related to the current JOSM rendering mode/view? I'd think otherwise.)

[bastiK]

Maybe change to informational level?

[Don-vip]

Honestly I can't see the point of this test ? Why do we check the styles instead of tags ?

[stoecker]

It is hard to check the tags, as you don't know what tags are relevant for drawing. Don't know if the current structure of the software now allows to find the tags causing a style.

[bastiK]

Replying to stoecker:

Don't know if the current structure of the software now allows to find the tags causing a style.

No, not really.

In principle the test is a good heuristic, but people aren't used to tolerate false positives. I doubt we can re-educate them with this. ;)

[grinapo]

Replying to bastiK:

Replying to stoecker:
In principle the test is a good heuristic, but people aren't used to tolerate false positives. I doubt we can re-educate them with this. ;)

You're being unfair. Especially since I have tried to research this, went to the wiki and read the description. Now go, see how much light it sheds ("educates") about what this message exactly mean. (Hint: not much.)

There are loads and loads of tests with vast amounts of false positives, and I'm handling it pretty well since I know what they mean and I'm able to decide whether it's a problem or not and what's to fix, if any. My original problem was that the report is not well defined: see, I was even unable to see what was reported and why.

There is a point reporting if inner and outer have the same tags, my guess is that it's pretty easy to detect, and it is a good informational check.

There are some merits in checking whether something is rendered the same in the current JOSM settings, views and personal preferences, but it should be clear what is reported: the better is if JOSM message is clear, but in the end it's good if the wiki's descriptive. Now I go and try to change the wiki description, but I'm not sure how many endusers are able to go there and see. ;-)

[grinapo]

For the reference: ​http://wiki.openstreetmap.org/wiki/JOSM/Validator#Validations

[stoecker]

Hello,

There is a point reporting if inner and outer have the same tags, my guess is that it's pretty easy to detect, and it is a good informational check.

Exactly this is the problem. We cannot report the same tags. We need to check only tags which influence drawing style. Anything not related to drawing (the majority of tags) must be ignored or the test is useless. And the big problem is to find the right tags.

But probably the number of false positives could be reduced, when we check for differences in some of the more prominent tags like landuse, natural, ...

[Don-vip]

What about making some light changes in the rendering style ? We currently have the exact same green color for various landuses, we could use small variants to disable this warning ? Like a greener green for grass :)

[bastiK]

Replying to Don-vip:

What about making some light changes in the rendering style ? We currently have the exact same green color for various landuses, we could use small variants to disable this warning ? Like a greener green for grass :)

Some users prefer the Potlatch 2 style and so far I kept it in sync with upstream.

[bastiK]

Replying to stoecker:

But probably the number of false positives could be reduced, when we check for differences in some of the more prominent tags like landuse, natural, ...

Yes, I think this would eliminate most of the bogus reports.

[Don-vip]

Ticket #8716 has been marked as a duplicate of this ticket.

[Don-vip]

Ticket #9139 has been marked as a duplicate of this ticket.

[aceman]

Why can't we check if some of the TAGS are the same? Is there a separate test for that? I would welcome that as that makes sense. If the existing test showing the message here checks if the COLOR of the area is the same then that is useless for me. The color is the same in JOSM, but is not the same in Mapnik or other renderers. I do not see the point. So is there the tag comparison test?

[Don-vip]

Closed as duplicate of #6363.