Changeset tags handling coming from a .osm file

[_sly_]

Hi,

Patch from #6742 is a rather nice option to help auto setting changesets tags for the future data integration users are going to do.

It "kind of work" but has strange behaviour in several cases
(test file included)

• If you open that file and try a direct upload, tags in the changeset are ignored
• If you start modifying things, tags are attached to the changeset
• If you upload the changes, and start modifying other things, subsequent changeset will get those tags while you'd expect tags, related to the first upload to be forgotten
• If you mess around with removing the JOSM data layers, modify things tags will hopefully be forgotten at some point
• If you save your data layer in an osm file, changeset tags are not saved in it while it would be nice to have

[Don-vip]

Replying to _sly_:

• If you open that file and try a direct upload, tags in the changeset are ignored
• If you start modifying things, tags are attached to the changeset

Found the cause of that strange behaviour:
​http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/actions/UploadAction.java#L214

As written in comments, we need a proper solution :)

[Don-vip]

Ticket #8590 has been marked as a duplicate of this ticket.

[Don-vip]

From #8590 comments: Tickets #4003,#4181,#4215,#6379,#6381,#6442,#6471,#7004 should be fixed as well when looking at this ticket

[skyper]

There are even some more concerning upload dialog:

#4535, #6103, #7090

[brycenesbitt]

And #8771 which while fixed, could revert again.

[Don-vip]

Ticket #11131 has been marked as a duplicate of this ticket.

[simon04]

In 9514/josm:

fix #4003 fix #7004 fix #8149 - Improve changeset tags handling (from earlier changeset, from dataset)