Opened 13 years ago
Closed 5 years ago
#8076 closed enhancement (fixed)
presets: merge "Towers" and "Communication Towers"
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | 20.09 |
Component: | External preset | Version: | |
Keywords: | tower mast | Cc: | derstefan, iav, geozeisig, Alexander-II, stoecker |
Description ¶
We have two new presets:
They seem to have much in commen and there are some objects already in both. So I propose to merge these two presets.
Change History (21)
comment:1 by , 13 years ago
comment:2 by , 12 years ago
I did try to merge them. Please, have a look at the attachment.
I am too tired to publish and we should remove the other two presets in advance.
follow-up: 4 comment:3 by , 12 years ago
I propose to change name="Transmitter (steel mast)" to "Antenna (steel mast)".
And add lightning tower:
<item name="Lighting tower" dk.name="Forsvars tårn" ru.name="Осветительная вышка" icon="com_tower.png" type="node,closedway"> <link href="http://wiki.openstreetmap.org/wiki/Tag:man_made=tower"/> <label text="Lighting tower" dk.name="Forsvars tårn" ru.name="Осветительная вышка" /> <key key="man_made" value="tower"/> <key key="tower:type" value="lighting"/> <text key="name" text="Name" dk.text="Navn" default="" delete_if_empty="true"/> <space/> <text key="ref" text="Ref" dk.text="Ref" default="" delete_if_empty="true"/> <space/> <text key="operator" text="Operator" dk.text="Operatør" default="" delete_if_empty="true"/> <text key="height" text="Height" dk.text="Højde" default="" delete_if_empty="true"/> </item>
comment:4 by , 12 years ago
Replying to iav:
I propose to change name="Transmitter (steel mast)" to "Antenna (steel mast)".
+1
And add lightning tower:
Sorry, I did remove it as I did not find it in the wiki and was not sure about the differences to a lighthouse.
The key technology should be changed into a "multiselection" instead of a "combo"
follow-up: 6 comment:5 by , 12 years ago
Lighting towers that not a lighthouses:
http://www.shayanbargh.com/images/DecoraviteLight/stadium-light-03.JPG
http://www.shayanbargh.com/images/DecoraviteLight/high_mast_tower_light3.jpg
Good landmarks.
http://taginfo.openstreetmap.org/keys/tower:type#values
currently 603 usage, but I suppose they will be much more if they be included into the presets
comment:6 by , 12 years ago
Replying to iav:
Lighting towers that not a lighthouses:
http://www.shayanbargh.com/images/DecoraviteLight/stadium-light-03.JPG
http://www.shayanbargh.com/images/DecoraviteLight/high_mast_tower_light3.jpg
Good landmarks.
These are no lightning towers !
Maybe light towers
but probably man_made=mast is better suited or lamp or even highway=street_lamp
This is about a lightning tower, but introducing this type of tower we definitely need a tag for small ones (e.g. no towers!), too.
Have a look at https://en.wikipedia.org/wiki/Lightning_rod.
http://taginfo.openstreetmap.org/keys/tower:type#values
currently 603 usage, but I suppose they will be much more if they be included into the presets
We need to change them if needed !
follow-up: 8 comment:7 by , 12 years ago
You are right, light towers, not lightning. Sorry, just my bad english knowledge.
But we need to differentiate highway light poles (not landmarks), and much higher masts or poles placed at stadiums and industrial areas - where they are landmarks, and, often, the one landmarks for a huge territory
Sure it's not a highway=lamps, at least because there no highway. But what it should be exactly?
I simply choose a man_made=tower, because it seems to me as good fit to http://wiki.openstreetmap.org/wiki/Tag:man_made=tower, and have some 100's usages.
comment:8 by , 12 years ago
Replying to iav:
You are right, light towers, not lightning. Sorry, just my bad english knowledge.
Please, fix your preset and have a look at the so far tagged objects. Maybe some other user is using your preset.
But we need to differentiate highway light poles (not landmarks), and much higher masts or poles placed at stadiums and industrial areas - where they are landmarks, and, often, the one landmarks for a huge territory
+1
Sure it's not a highway=lamps, at least because there no highway. But what it should be exactly?
I simply choose a man_made=tower, because it seems to me as good fit to http://wiki.openstreetmap.org/wiki/Tag:man_made=tower, and have some 100's usages.
Did not think these are towers but masts, something like this:
man_made=mast
mast:type=light
light:type=*
light:colour=*
came to my mind.
The more I read + think about it the less am sure about this issue.
- First, we need to define
tower
,mast
andantenna
.- As far as I understand wikipedia in English all free-standing structures are towers. Masts are tied with some guy wire/rope what we use antenna for, where as antenna would be only the part that is actually transmitting and/or receiving. This can lead that we have a communication tower with an observation deck with restaurant and on top a mast with several antennas for different types of communication. Have a look at Partially_guyed_tower.
As am also not a native speaker the best is probably to open a thread at tagging@.
comment:10 by , 10 years ago
Despite the two external presets, the major tags like man_made=antenna/mast/pole
deserve a place in the internal presets.
comment:11 by , 7 years ago
Keywords: | tower added |
---|
comment:12 by , 5 years ago
Maybe, it is time to include tower and mast with more details in defaultpresets. See #10759 for mast.
comment:13 by , 5 years ago
Cc: | added |
---|---|
Keywords: | mast added |
I added a complete preset for all kind of masts and towers, see Presets/MastAndTower (@geozeisig: Thanks for the icons).
Think we can deprecate the other two external presets. Opinions ?!
follow-up: 15 comment:14 by , 5 years ago
Cc: | added |
---|
@Dirk:
Are there any numbers about external tagging presets' popularity?
comment:15 by , 5 years ago
Replying to skyper:
@Dirk:
Are there any numbers about external tagging presets' popularity?
No. We only have a tracking for (activated) maps and plugins.
comment:16 by , 5 years ago
Milestone: | → 20.09 |
---|
Mast, tower and communication tower are now in the internal preset and we have the new combined external preset from skyper too. Lets remove the two old external presets mentioned in the ticket description in 3 months.
comment:17 by , 5 years ago
Here are the two presets as zip for archiving. I'll delete the two pages tomorrow.
by , 5 years ago
Attachment: | Presets_Towers.zip added |
---|
by , 5 years ago
Attachment: | Presets_Communication_Towers.zip added |
---|
comment:18 by , 5 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Generaly I just want to add one type to Jens Winbladh preset, but can't do it until xml hosted in wiki.