[patch] extruder: different curser icons for non-rectangled variants or different preview

[skyper]

Please show the different variants (shifts) of extruding non-rectangled oblects by different mouse cursor icons or change the preview

Right now, for angles close to 90° the differences are not visable in preview and resulting in guessing and undo. For background please have a look at #7723.

r5471

[AlfonZ]

preliminary patch

[AlfonZ]

cursor modifier image

[AlfonZ]

cursor modifier image

[AlfonZ]

patch in work

[AlfonZ]

I have attached patch that highlights way segment used as a reference.
Includes two new cursor modifiers (rectangle_move.png and rectangle_plussmall.png for CTRL and SHIFT).
Comments are welcome.

Does it need a preference setting that can disable it?

[stoecker]

I don't see any problem with the patch when reading the diff.

As you changed javadoc, completing it (e.g. adding doc to every function and member variable and class) would be fine. We wanna get better and better :-)

[skyper]

Replying to AlfonZ:

I have attached patch that highlights way segment used as a reference.

Looks great.

Does it need a preference setting that can disable it?

As far as I know, you can disable highlighting/mouse cursor changes at once already in the preferences. Setting it separatly for each mode does not make much sense.

[bastiK]

In 5506/josm:

applied #7990 extruder: different curser icons for non-rectangled variants or different preview (patch by AlfonZ)

[bastiK]

In 5507/josm:

forgot to add images (see #7990)