Modify

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#7990 closed enhancement (fixed)

[patch] extruder: different curser icons for non-rectangled variants or different preview

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: extruder mouse icon Cc:

Description (last modified by skyper)

Please show the different variants (shifts) of extruding non-rectangled oblects by different mouse cursor icons or change the preview

Right now, for angles close to 90° the differences are not visable in preview and resulting in guessing and undo. For background please have a look at #7723.

r5471

Attachments (4)

7990.diff (15.4 KB) - added by AlfonZ 7 years ago.
preliminary patch
rectangle_move.png (232 bytes) - added by AlfonZ 7 years ago.
cursor modifier image
rectangle_plussmall.png (227 bytes) - added by AlfonZ 7 years ago.
cursor modifier image
7990-highlightedWaySegments.png (3.7 KB) - added by AlfonZ 7 years ago.
patch in work

Download all attachments as: .zip

Change History (11)

comment:1 Changed 7 years ago by skyper

Description: modified (diff)

comment:2 Changed 7 years ago by skyper

Description: modified (diff)

Changed 7 years ago by AlfonZ

Attachment: 7990.diff added

preliminary patch

Changed 7 years ago by AlfonZ

Attachment: rectangle_move.png added

cursor modifier image

Changed 7 years ago by AlfonZ

Attachment: rectangle_plussmall.png added

cursor modifier image

Changed 7 years ago by AlfonZ

patch in work

comment:3 Changed 7 years ago by AlfonZ

Summary: extruder: different curser icons for non-rectangled variants or different preview[patch] extruder: different curser icons for non-rectangled variants or different preview

I have attached patch that highlights way segment used as a reference.
Includes two new cursor modifiers (rectangle_move.png and rectangle_plussmall.png for CTRL and SHIFT).
Comments are welcome.

patch in work

Does it need a preference setting that can disable it?

comment:4 Changed 7 years ago by stoecker

I don't see any problem with the patch when reading the diff.

As you changed javadoc, completing it (e.g. adding doc to every function and member variable and class) would be fine. We wanna get better and better :-)

comment:5 in reply to:  3 Changed 7 years ago by skyper

Replying to AlfonZ:

I have attached patch that highlights way segment used as a reference.

Looks great.

Does it need a preference setting that can disable it?

As far as I know, you can disable highlighting/mouse cursor changes at once already in the preferences. Setting it separatly for each mode does not make much sense.

comment:6 Changed 7 years ago by bastiK

Resolution: fixed
Status: newclosed

In 5506/josm:

applied #7990 extruder: different curser icons for non-rectangled variants or different preview (patch by AlfonZ)

comment:7 Changed 7 years ago by bastiK

In 5507/josm:

forgot to add images (see #7990)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.