Changeset 5471 in josm

Timestamp:

2012-08-22T01:48:59+02:00 (12 years ago)

Author:

Don-vip

Message:

see #7980 - fix another memory leak

File:

• trunk/src/org/openstreetmap/josm/gui/SideButton.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/SideButton.java

@@ -27 +27 @@
 public class SideButton extends JButton implements Destroyable {
     private final static int iconHeight = 20;
+    
+    private PropertyChangeListener propertyChangeListener;
 
     public SideButton(Action action)
@@ -52 +54 @@
     }
 
-    void fixIcon(Action action) {
+    private void fixIcon(Action action) {
         // need to listen for changes, so that putValue() that are called after the
         // SideButton is constructed get the proper icon size
-        if(action != null) {
-            action.addPropertyChangeListener(new PropertyChangeListener() {
+        if (action != null) {
+            action.addPropertyChangeListener(propertyChangeListener = new PropertyChangeListener() {
                 @Override
                 public void propertyChange(PropertyChangeEvent evt) {
-                    if(evt.getPropertyName() == javax.swing.Action.SMALL_ICON) {
+                    if (evt.getPropertyName() == javax.swing.Action.SMALL_ICON) {
                         fixIcon(null);
                     }
@@ -66 +68 @@
         }
         Icon i = getIcon();
-        if(i != null && i instanceof ImageIcon && i.getIconHeight() != iconHeight) {
+        if (i != null && i instanceof ImageIcon && i.getIconHeight() != iconHeight) {
             setIcon(getScaledImage(((ImageIcon) i).getImage()));
         }
@@ -144 +146 @@
             ((Destroyable) action).destroy();
         }
-        setAction(null);
+        if (action != null) {
+            if (propertyChangeListener != null) {
+                action.removePropertyChangeListener(propertyChangeListener);
+            }
+            setAction(null);
+        }
     }
 }