Shortcuts in toggle dialogs: Enter, Spacebar, Up/Down

[akks]

During fixing #7463 I noticed that keys Enter/Spacebar in toggle dialog tables and lists are often ignored or does not do anything useful (when table or list item is focused, not the buttons). This behavior was changed in #7131 for properties dialog, there was no complains so far :)

I tried to add most useful actions on Enter and Spacebar (only when some item is selected and focused):

• activate layer = Enter in Layer List toggle dialog
• show/hide layer = Spacebar in Layer List toggle dialog
• zoom to one of selected items = Enter in Selection List toggle dialog
• open history of primitive = Enter/Spacebar in History toggle dialog
• toggle map style = Enter/Spacebar in Map Style toggle dialog
• select relation = Enter in Relation List toggle dialog
• edit relation = Ctrl-Enter in Relation List toggle dialog (because Ctrl-DoubleClick already works)
• select primitives with error = Enter in Validator toggle dialog

I am committing the changes and creating this ticket for feedback - I hope there are no errors, regressions, but anything could happen... Maybe some extra changes are needed or better solution exist.
Current behavior of keys should be untouched if no item of list/table is manually selected.

[akks]

In 5200/josm:

see #7626, fix #7463: keys Ctrl-Shift-Up/Down, Enter, Spacebar work better in toggle dialogs
Enter and Spacebar = useful actions for list items (select, toggle, etc.)

[akks]

Here is the jar for today testing (while latest is 5199): ​http://dl.dropbox.com/u/63393258/josm-custom.jar

[Don-vip]

​r5200 cause some problems with the Enter key. There's still something to do, I'm looking.

[Don-vip]

At ​http://josm.openstreetmap.de/browser/josm/trunk/src/org/openstreetmap/josm/tools/InputMapUtils.java?rev=5200#L32:

         b.getInputMap(JComponent.WHEN_FOCUSED).put(KeyStroke.getKeyStroke(KeyEvent.VK_Q,0), "enter");

It should be VK_ENTER, right ?

[Don-vip]

In 5367/josm:

see #7626 - Fix usage of key "Enter' in dialogs

[akks]

Thank you! Very strange I missed such a mispell :)

[akks]

Guess it can be closed too. No more related ideas?

[Don-vip]

Yep :) if new ideas new ticket :)