Opened 13 years ago
Closed 13 years ago
#7470 closed defect (fixed)
[Patch] Annoying warning about deleting nodes with id:0 outside BBox
Reported by: | skyper | Owned by: | team |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | Core | Version: | latest |
Keywords: | Cc: |
Description
I get warnings about deleting nodes with id:0 outside BBox.
There should be no warning as you can not delete any incomplete object by deleting a node with id:0
Attachments (2)
Change History (8)
follow-up: 2 comment:1 by , 13 years ago
follow-up: 3 comment:2 by , 13 years ago
Replying to simon04:
Please attach a test file, I cannot reproduce (1. download some area, 2. add a node outside the area, 3. delete this node).
Sorry not much time right now:
Please, try it with a way id:0.
Thanks
comment:3 by , 13 years ago
Replying to skyper:
Replying to simon04:
Please attach a test file, I cannot reproduce (1. download some area, 2. add a node outside the area, 3. delete this node).
Sorry not much time right now:
I had five minutes !
Sorry my description is incomplete.
- download an closed way with at least one node outside BBox
- use terracer to terrace keeping the original way
- delete the new created closed way with the node outside BBox
It has to due with ways. I gonna attach an example.
by , 13 years ago
Attachment: | 7470.patch added |
---|
comment:4 by , 13 years ago
Summary: | Annoying warning about deleting nodes with id:0 outside BBox → [Patch] Annoying warning about deleting nodes with id:0 outside BBox |
---|
The attached patch should take care of this issue. Patch explained in words: As the delete operation already takes care of including/excluding way-nodes from deletion, there is no need to check ways in the outlying check.
To be on the safe side, I'd await the end of stabilization phase although I do not expect any problems with the patch.
Please attach a test file, I cannot reproduce (1. download some area, 2. add a node outside the area, 3. delete this node).