Opened 13 years ago
Closed 13 years ago
#7409 closed defect (fixed)
[PATCH] Plugin routing ignores roundabout implicit oneway
| Reported by: | franpd | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugin routing | Version: | latest |
| Keywords: | roundabout oneway | Cc: |
Description
In roundabouts with no oneway tag, the plugin assumes bidirectional path instead of oneway. Implicit oneway is not applied.
Attachments (4)
Change History (26)
by , 13 years ago
| Attachment: | Roundabout_before.png added |
|---|
by , 13 years ago
| Attachment: | Roundabout_after.png added |
|---|
comment:2 by , 13 years ago
Maybe you will want get SVN account from TomH and continue to support routing plugin?
comment:3 by , 13 years ago
Replying to akks:
Should we apply it together with your patch in #3447?
May be I should create a patch with both changes at the same time, as one of them can delete some code from the other one.
Replying to akks:
Maybe you will want get SVN account from TomH and continue to support routing plugin?
I would be pleased if I can help improving the routing plugin. I talked to the owners and liked the idea.
comment:4 by , 13 years ago
This could help getting account: http://josm.openstreetmap.de/ticket/7237#comment:13
comment:6 by , 13 years ago
Replying to akks:
Can your include patches for routing yourself now?
I have the access now. I will try to submit the changes and close the tickets as soon as possible.
Thank you very much.
follow-up: 8 comment:7 by , 13 years ago
I did not mean to hurry you, I am just curios :)
Do not forget main cycle of publishing version - use "ant publish" with comment in build.xml or perform full "commit source -> update source (svn update) -> ant dist -> commit jar" cycle. I missed some steps several times (forget svn add, forget to publish jar or source, most often - forget to update and rebuild the source).
The guide
http://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins
is also worth reading:)
comment:8 by , 13 years ago
Replying to akks:
I did not mean to hurry you, I am just curios :)
Do not forget main cycle of publishing version - use "ant publish" with comment in build.xml or perform full "commit source -> update source (svn update) -> ant dist -> commit jar" cycle. I missed some steps several times (forget svn add, forget to publish jar or source, most often - forget to update and rebuild the source).
The guide
http://josm.openstreetmap.de/wiki/DevelopersGuide/DevelopingPlugins
is also worth reading:)
I need your help in committing the changes. Could you please help me? I do not now if you can send me an email or I can just post my scenario and problem in here.
follow-up: 10 comment:9 by , 13 years ago
It is simpler to put it here, so not only me could help. What is the problem?
if you need e ma il, it is alexei_kasatkin <at sign> mail.ru
comment:10 by , 13 years ago
Replying to akks:
It is simpler to put it here, so not only me could help. What is the problem?
if you need e ma il, it is alexei_kasatkin <at sign> mail.ru
Scenario:
Eclipse installed on Windows 7. Followed all steps in videos "How to checkout JOSM into Eclipse" and "How to checkout a JOSM plugin into Eclipse". Projects located in /workspace/core/... for JOSM and /workspace/plugins/routing/... for the plugin, so the paths in build.xml have not to be changed. Changed plugin SVN from "http://svn.openstreetmap.org/applications/editors/josm/plugins/routing" to "http://myusername@svn.openstreetmap.org/applications/editors/josm/plugins/routing". Ant could not find a command line SVN, so I installed TortoiseSVN (I do not know it is the best solution, or if I can do with Eclipse). All local compilations and tests work fine.
Problems:
1) I do not know where to configure my SVN account password.
2) When I try to publish (ANT -> publish), it gets stalled in the commit step (maybe waiting for a password). No windows appears to ask for it.
follow-up: 12 comment:11 by , 13 years ago
This is the password problem. Commit source first time with TortoiseSvn (gui or command line svn commit src -m "routing plugin update") - it will ask for user and password (by the way, it does not work from behind proxy at my university).
Then ant publish will then work saved password (it is noninteractive).
You can clean password later by TortoiseSvn settings (Settings-Saved Data-Authentication data-clean)
comment:12 by , 13 years ago
Replying to akks:
This is the password problem. Commit source first time with TortoiseSvn (gui or command line svn commit src -m "routing plugin update") - it will ask for user and password (by the way, it does not work from behind proxy at my university).
Then ant publish will then work saved password (it is noninteractive).
You can clean password later by TortoiseSvn settings (Settings-Saved Data-Authentication data-clean)
Sorry I am not experienced with SVN, so...what exactly should I write in the "routing plugin update" part of the command, knowing the paths I told you before?
follow-up: 14 comment:13 by , 13 years ago
Just a message to be shown in http://trac.openstreetmap.org/timeline
for example "Routing plugin: added one-way support". TortoiseSVN GUI commit should also work (src folder in Explorer -> context menu -> commit -> [enter message] -> OK - [enter login and password]). Short SVN introduction: http://www.cse.yorku.ca/percept/svn_starters_guide.pdf
follow-up: 15 comment:14 by , 13 years ago
Replying to akks:
Just a message to be shown in http://trac.openstreetmap.org/timeline
for example "Routing plugin: added one-way support". TortoiseSVN GUI commit should also work (src folder in Explorer -> context menu -> commit -> [enter message] -> OK - [enter login and password]). Short SVN introduction: http://www.cse.yorku.ca/percept/svn_starters_guide.pdf
Oh, then I meant "src" part of the command :) Now I see it should be workspace/plugins/routing/src
follow-up: 16 comment:15 by , 13 years ago
Replying to anonymous:
Replying to akks:
Just a message to be shown in http://trac.openstreetmap.org/timeline
for example "Routing plugin: added one-way support". TortoiseSVN GUI commit should also work (src folder in Explorer -> context menu -> commit -> [enter message] -> OK - [enter login and password]). Short SVN introduction: http://www.cse.yorku.ca/percept/svn_starters_guide.pdf
Oh, then I meant "src" part of the command :) Now I see it should be workspace/plugins/routing/src
It is better to commit from corresponding folder (svn commit in routing folder commits sources, images, build.xml, etc.). Do not forget to add files to svn (svn add or gui menus) if you create them (new .java, new images, etc.).
comment:16 by , 13 years ago
Replying to akks:
Replying to anonymous:
Replying to akks:
Just a message to be shown in http://trac.openstreetmap.org/timeline
for example "Routing plugin: added one-way support". TortoiseSVN GUI commit should also work (src folder in Explorer -> context menu -> commit -> [enter message] -> OK - [enter login and password]). Short SVN introduction: http://www.cse.yorku.ca/percept/svn_starters_guide.pdf
Oh, then I meant "src" part of the command :) Now I see it should be workspace/plugins/routing/src
It is better to commit from corresponding folder (svn commit in routing folder commits sources, images, build.xml, etc.). Do not forget to add files to svn (svn add or gui menus) if you create them (new .java, new images, etc.).
Done. Could you please check if all steps have been uploaded correctly (src + jar + version + comments)?
Thank you very much!
follow-up: 18 comment:17 by , 13 years ago
Source and build.xml are OK.
You can do ant publish to publish jar now (it should not hang).
(Use http://trac.openstreetmap.org/timeline to check)
follow-up: 19 comment:18 by , 13 years ago
Replying to akks:
Source and build.xml are OK.
You can do ant publish to publish jar now (it should not hang).
(Use http://trac.openstreetmap.org/timeline to check)
jar file should have been uploaded too at that moment, as I made ant publish after committing with TortoiseSVN.
follow-up: 20 comment:19 by , 13 years ago
Replying to franpd@…:
jar file should have been uploaded too at that moment, as I made ant publish after committing with TortoiseSVN.
Hmm, but there is no JAR in repository, as you can see in timeline. I had such problem too. It seems ant publish ended with error. It may be conflicts in dist folders, for example (some plugins updated)...
Try to make svn update and then ant dist and then commit routing.jar from dist with TortoiseSVN...
follow-up: 21 comment:20 by , 13 years ago
Replying to akks:
Replying to franpd@…:
jar file should have been uploaded too at that moment, as I made ant publish after committing with TortoiseSVN.
Hmm, but there is no JAR in repository, as you can see in timeline. I had such problem too. It seems ant publish ended with error. It may be conflicts in dist folders, for example (some plugins updated)...
Try to make svn update and then ant dist and then commit routing.jar from dist with TortoiseSVN...
I think it may be because dist dir is outside my workspace folder. I will try to upload it.
comment:21 by , 13 years ago
Replying to franpd@…:
Replying to akks:
Replying to franpd@…:
jar file should have been uploaded too at that moment, as I made ant publish after committing with TortoiseSVN.
Hmm, but there is no JAR in repository, as you can see in timeline. I had such problem too. It seems ant publish ended with error. It may be conflicts in dist folders, for example (some plugins updated)...
Try to make svn update and then ant dist and then commit routing.jar from dist with TortoiseSVN...
I think it may be because dist dir is outside my workspace folder. I will try to upload it.
I think it is OK now. I had to add dist dir as a SVN source too.
Roundabout before patch