Modify

Opened 11 years ago

Closed 20 months ago

#7120 closed enhancement (duplicate)

Check: Railway end node near other railway

Reported by: newsScott@… Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: unconnected_way railway Cc: GerdP

Description

There allready exists a "Way end node near other highway" check. The same would be very helpful to improve the quality of railway data.

Some false positives may be avoidable if the code would also check for the tag "railway:buffer_stop" in the end node.

Attachments (0)

Change History (10)

comment:1 Changed 11 years ago by anonymous

i realized that there is allready some support of this. But i think the current implementation needs some changes:

in org/openstreetmap/josm/data/validation/tests/UnconnectedWays.java:

The default distance (mindist) of 10 meters is not useful for checking railways. I my experiments, something like 1-2 meters is best. So should there be a mindist_highway and mindist_railway?

The code finds some false positives: many platforms are still tagged "railway=platform" instead of "public_transport=platform". In member function "visit", ways tagged with railway=platform should not be taken into account:

something like

if (w.hasKey("highway")
w.hasKey("railway") && !w.get("railway").equals("platform")) {

set = endnodes_highway;

}

comment:2 Changed 11 years ago by simon04

Component: CoreCore validator

comment:3 Changed 11 years ago by simon04

Keywords: unconnected_way added

comment:4 Changed 5 years ago by Don-vip

Keywords: railway added

comment:5 Changed 2 years ago by skyper

The test was reworked. Does it work better, now?

Last edited 2 years ago by skyper (previous) (diff)

comment:6 Changed 20 months ago by skyper

Cc: GerdP added

Anything left, besides #21038.

comment:7 Changed 20 months ago by GerdP

Resolution: fixed
Status: newclosed

I think #18272 fixes this. Please open a new ticket if further issues are found

comment:8 Changed 20 months ago by Don-vip

Resolution: fixedduplicate

Marked as duplicate of #18272.

comment:9 Changed 20 months ago by skyper

Resolution: duplicate
Status: closedreopened

comment:10 Changed 20 months ago by skyper

Resolution: duplicate
Status: reopenedclosed

Closed as duplicate of #21038.
See r18272.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.