[Patch] Stop creating validator folder

[bagage]

What steps will reproduce the problem?

1. Run new version of JOSM

What is the expected result?

Validator should use JOSM preferences to store its items.

What happens instead?

It still creates a folder in user settings ($HOME/.local/JOSM/validator on GNU/Linux).

Attached patch should address the problem (really looking forward to gitlab migration though!).

Please provide any additional information below. Attach a screenshot if possible.

Build-Date:2019-06-16 15:08:02
Revision:15171
Is-Local-Build:true

Identification: JOSM/1.5 (15171 SVN en) Linux Debian GNU/Linux bullseye/sid
Memory Usage: 1051 MB / 4450 MB (362 MB allocated, but free)
Java version: 1.8.0_232-8u232-b09-1-b09, Debian, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1080
Maximum Screen Size: 1920x1080
Java package: openjdk-8-jre:amd64-8u232-b09-1
Java ATK Wrapper package: libatk-wrapper-java:all-0.37.1-1
libcommons-compress-java: libcommons-compress-java:-
libcommons-logging-java: libcommons-logging-java:all-1.2-2
fonts-noto: fonts-noto:all-20181227-1
liboauth-signpost-java: liboauth-signpost-java:-
VM arguments: [-javaagent:/opt/ideaIU-2018.2/idea-IU-182.3684.101/lib/idea_rt.jar=33929:/opt/ideaIU-2018.2/idea-IU-182.3684.101/bin, -Dfile.encoding=UTF-8]
Program arguments: [${HOME}/code/osm/josm/caudalie.joz, --lang=en]

Plugins:
+ apache-commons (35092)
+ buildings_tools (35171)
+ cadastre-fr (35167)
+ conflation (0.6.4)
+ ejml (35122)
+ geotools (35169)
+ jts (35122)
+ scripting (30796)
+ todo (30306)
+ utilsplugin2 (35177)

Last errors/warnings:
- E: Failed to locate image 'dialogs/reorderlayers'
- W: No configuration settings found.  Using hardcoded default values for all pools.
- E: Handled by bug report queue: org.openstreetmap.josm.tools.JosmRuntimeException: Fatal: failed to locate image 'reverse.???'. This is a serious configuration problem. JOSM will stop working.
- E: Handled by bug report queue: java.lang.reflect.InvocationTargetException. Cause: java.lang.IllegalStateException: Dialog was already created

[bagage]

patch

[Don-vip]

It seems it will break validator ignored errors.

[bagage]

What makes you feel so?

The checkValidatorDir method only creates the folder ~/.local/share/JOSM/validator, but we do not write anymore in that directory.

Previously we wrote ~/.local/share/JOSM/validator/ignorederrors but now we write in josm preferences directly. We only read that file once to migrate its content to JOSM preferences. For that we first ensure it exists:

Path path = Paths.get(getValidatorDir()).resolve("ignorederrors");
try {
    if (path.toFile().exists()) {
          /* migrate to josm preferences */

I'm not sure to understand what it would break?

[Don-vip]

Ah, I thought we still used this file. Since when does JOSM migrate it to preferences? Maybe it's time to get rid of this compatibility code as well.

[bagage]

I think it is since revision r14828?

[Don-vip]

OK. Current JOSM usage is as follows:
below r14828, around 20%:

 205 ( 2.6%)*9329
  96 ( 1.2%)*14178
  58 ( 0.7%)*14382
  60 ( 0.8%)*14460
 118 ( 1.5%)*14620
  94 ( 1.2%)*14760
 114 ( 1.5%)*14824

above r14828, around 80%:

 104 ( 1.3%)*14945
 177 ( 2.3%)*15031
 224 ( 2.9%)*15155
  93 ( 1.2%) 15233
 463 ( 6.0%)*15238
 593 ( 7.7%)*15322
4271 (55.2%)*15390
  51 ( 0.7%) 15479

It's only 8 months old, we can wait a few months still to have a higher percentage.

[Don-vip]

In 15485/josm:

fix #18272 - Stop creating validator folder (patch by bagage)

[Don-vip]

Ticket #7120 has been marked as a duplicate of this ticket.