Modify

Opened 7 years ago

Last modified 4 years ago

#7012 new enhancement

Handle relation membership in "create multipolygon"

Reported by: dieterdreist Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: convert to multipolygon Cc:

Description

Please integrate "convert to multipolygon" into core, it is really useful.

Attachments (0)

Change History (9)

comment:1 Changed 5 years ago by skyper

Was it not integrated some time ago ?

If so, I have a minor issue as the "create multipolygon" nicely moves all tags but there is no option to move the memberships.

comment:2 Changed 5 years ago by Don-vip

integrate from what ? utilsplugin2 ?

comment:3 in reply to:  2 Changed 5 years ago by skyper

Replying to Don-vip:

integrate from what ? utilsplugin2 ?

Think there used to be a small plugin but nothing left (did not try archives.org, yet):

comment:4 Changed 5 years ago by Don-vip

We have Create Multipolygon since r3704 and improved in r5225 by #7458. I removed this plugin because I thought it was redundant ([o29724]). What features of it would be missing in core ?

comment:5 in reply to:  4 Changed 5 years ago by skyper

Replying to Don-vip:

We have Create Multipolygon since r3704 and improved in r5225 by #7458. I removed this plugin because I thought it was redundant ([o29724]). What features of it would be missing in core ?

As I wrote above, relation membership is not handled at all. Nice would be a dialog with list and checkboxes for each relation to choose weather to move or not, with default to move all.

comment:7 Changed 5 years ago by Don-vip

Code is available here.

Maybe we can see how to integrate what's missing in the course of #9492.

But I still don't see exactly what this plugin was capable of and we don't. Can you please give me a practical example ? Thanks.

Last edited 4 years ago by Don-vip (previous) (diff)

comment:8 in reply to:  7 ; Changed 5 years ago by dieterdreist

Replying to Don-vip:

I still don't see exactly what this plugin was capable of and we don't. Can you please give me a practical example ? Thanks.

It works like the current "create multipolygon" (i.e. it associates the roles outer and inner to the selected ways and puts them into the newly created relation), but with the difference that all tags from the (then) outer ways will be _moved_ from the object(s) to the relation. This is easy for simple cases (say one outer way), for the more complex cases maybe user interaction similar to what we do in the combine ways case for conflicting tags, could be implemented (as a start it would be superfine to simply move all tags to the relation that are present on all outer ways and are not "linear" tags like highway without area=yes).

comment:16 in reply to:  8 Changed 4 years ago by Don-vip

Priority: majornormal
Summary: integrate "convert to multipolygon" into coreHandle relation membership in "create multipolygon"

Replying to dieterdreist:

It works like the current "create multipolygon" (i.e. it associates the roles outer and inner to the selected ways and puts them into the newly created relation), but with the difference that all tags from the (then) outer ways will be _moved_ from the object(s) to the relation.

As said, we already do that since r5225. I have checked the old plugin and it did nothing more than we do.

Only the relation membership asked by skyper has to be handled now.

comment:17 Changed 4 years ago by dieterdreist

Yes, I have now discovered that I can get the desired behaviour with the current version.


If I select outer and inner ways and hit ctrl+alt+a I get a multipolygon with the tags of the outer way moved to the new relation (not sure where this function comes from, didn't find it in the menu but it works).


If instead I hit ctrl+b or click the "create multipolygon" in the "tools" menu it creates the relation, adds the members, but doesn't move the tags.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to dieterdreist
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.