Modify

Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#6853 closed enhancement (fixed)

[PATCH] In draw mode, select the way to be extended immediately

Reported by: olejorgenb Owned by: team
Priority: normal Milestone:
Component: Core Version:
Keywords: draw mode Cc:

Description (last modified by bastiK)

Currently, the way to be extended/continued is not select until adding the first new node. This patch selects the way immediately. (ie. when the user clicks the end/start node in drawmode)

The motivation is that I've sometimes realized after adding the first new node that I really wanted a _new_ way. This will emphasize that the way is extended, hopefully making me use the alt modifier before it's "too late" :)

Attachments (2)

select-way-to-be-extended-in-draw-mode-early.patch (1.3 KB) - added by olejorgenb 8 years ago.
select-way-to-be-extended-in-draw-mode-early-v2.patch (2.3 KB) - added by olejorgenb 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by olejorgenb

comment:1 Changed 8 years ago by bastiK

Description: modified (diff)

Sorry for the delay. I think it's a good idea and found no bug so far. One inconsistency: When you select the end node of a way and change into add mode, it should either select the way immediately or start drawing a new way.

Btw., is Alt in add mode supposed to work? I've always considered it a long-standing bug...

comment:2 Changed 8 years ago by olejorgenb

One inconsistency: When you select the end node of a way and change into add mode, it should either select the way immediately or start drawing a new way.

Yep. There's other similar cases. I'll try to fix them, but some might get a bit hairy

comment:3 Changed 8 years ago by olejorgenb

I think that should cover most of it.

getWayForNode is a somewhat expensive call so it might not be good to call it on every redraw (in redrawIfRequired). I don't notice any difference though. (it's as slow as always on my old computer ;)

comment:4 Changed 8 years ago by bastiK

Resolution: fixed
Status: newclosed

In [4539/josm]:

applied #6853 - In draw mode, select the way to be extended immediately (patch by olejorgenb)

comment:5 in reply to:  3 Changed 8 years ago by bastiK

Replying to olejorgenb:

I think that should cover most of it.

getWayForNode is a somewhat expensive call so it might not be good to call it on every redraw (in redrawIfRequired). I don't notice any difference though. (it's as slow as always on my old computer ;)

I don't see anything expensive in getWayForNode, should be all right.

comment:6 Changed 6 years ago by bastiK

Possible regression: see #9423

comment:7 Changed 6 years ago by Don-vip

In 6542/josm:

fix #9423, see #6853 - incorrect selection after hitting Alt key while adding a way (regression from r4539)

comment:8 Changed 6 years ago by Don-vip

In 6546/josm:

fix #9482, see #9423, see #6853 - fix regression from r6542: irregular behaviour drawing ways

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.