#6853 closed enhancement (fixed)
[PATCH] In draw mode, select the way to be extended immediately
| Reported by: | olejorgenb | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Core | Version: | |
| Keywords: | draw mode | Cc: |
Description (last modified by )
Currently, the way to be extended/continued is not select until adding the first new node. This patch selects the way immediately. (ie. when the user clicks the end/start node in drawmode)
The motivation is that I've sometimes realized after adding the first new node that I really wanted a _new_ way. This will emphasize that the way is extended, hopefully making me use the alt modifier before it's "too late" :)
Attachments (2)
Change History (10)
by , 13 years ago
| Attachment: | select-way-to-be-extended-in-draw-mode-early.patch added |
|---|
comment:1 by , 13 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 13 years ago
One inconsistency: When you select the end node of a way and change into add mode, it should either select the way immediately or start drawing a new way.
Yep. There's other similar cases. I'll try to fix them, but some might get a bit hairy
by , 13 years ago
| Attachment: | select-way-to-be-extended-in-draw-mode-early-v2.patch added |
|---|
follow-up: 5 comment:3 by , 13 years ago
I think that should cover most of it.
getWayForNode is a somewhat expensive call so it might not be good to call it on every redraw (in redrawIfRequired). I don't notice any difference though. (it's as slow as always on my old computer ;)
comment:5 by , 13 years ago
Replying to olejorgenb:
I think that should cover most of it.
getWayForNode is a somewhat expensive call so it might not be good to call it on every redraw (in redrawIfRequired). I don't notice any difference though. (it's as slow as always on my old computer ;)
I don't see anything expensive in getWayForNode, should be all right.
Sorry for the delay. I think it's a good idea and found no bug so far. One inconsistency: When you select the end node of a way and change into add mode, it should either select the way immediately or start drawing a new way.
Btw., is Alt in add mode supposed to work? I've always considered it a long-standing bug...