Modify

Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#655 closed defect (worksforme)

Delete of UnSelected Member in Edit Relation causes Exception

Reported by: Parthian Owned by: framm
Priority: minor Milestone:
Component: Core Version: latest
Keywords: Relation Editor Cc:

Description

I am adding Members to a Relation but have a minor problem with the Delete. If no row is selected when Delete is pressed an exception is raised (see below). Should be an easy fix. However, it would be nice if the row is automatically selected particularly in the case when you may wish to delete many rows (say when the wrong area is selected). So e.g. Add Selection and S/W automatically hightlights top row. Then a Delete would remove that row and highlight the next in case it needs to be deleted. So Delete, Delete, Delete in place of Click row, Delete, Click Row, Delete etc.

A nice to have.

Cheers

Path: josm
URL: http://www.openstreetmap.de/svn/josm
Repository Root: http://www.openstreetmap.de/svn/josm
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Revision: 451
Node Kind: directory
Last Changed Author: gebner
Last Changed Rev: 451
Last Changed Date: 2007-11-02 13:25:07 +0100 (Fri, 02 Nov 2007)

java.lang.ArrayIndexOutOfBoundsException: -1

at java.util.Vector.elementAt(Unknown Source)
at javax.swing.table.DefaultTableModel.getValueAt(Unknown Source)
at javax.swing.JTable.getValueAt(Unknown Source)
at org.openstreetmap.josm.gui.dialogs.RelationEditor$7.actionPerformed(RelationEditor.java:222)
at javax.swing.AbstractButton.fireActionPerformed(Unknown Source)
at javax.swing.AbstractButton$Handler.actionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.fireActionPerformed(Unknown Source)
at javax.swing.DefaultButtonModel.setPressed(Unknown Source)
at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(Unknown Source)
at java.awt.AWTEventMulticaster.mouseReleased(Unknown Source)
at java.awt.Component.processMouseEvent(Unknown Source)
at javax.swing.JComponent.processMouseEvent(Unknown Source)
at java.awt.Component.processEvent(Unknown Source)
at java.awt.Container.processEvent(Unknown Source)
at java.awt.Component.dispatchEventImpl(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.LightweightDispatcher.retargetMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.processMouseEvent(Unknown Source)
at java.awt.LightweightDispatcher.dispatchEvent(Unknown Source)
at java.awt.Container.dispatchEventImpl(Unknown Source)
at java.awt.Window.dispatchEventImpl(Unknown Source)
at java.awt.Component.dispatchEvent(Unknown Source)
at java.awt.EventQueue.dispatchEvent(Unknown Source)
at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
at java.awt.EventDispatchThread.run(Unknown Source)

Attachments (0)

Change History (3)

comment:1 by framm, 16 years ago

Resolution: worksforme
Status: newclosed

Please check if the bug is still present in the latest JOSM, I could not reproduce it here but I remember having done some work on the relation editor!

If you want to remove multiple objects from a relation, you can shift-select them all and then hit the "remove" button once.

Hope that resolves the problem?

comment:2 by anonymous, 16 years ago

Was fixed in r565.

in reply to:  2 comment:3 by Parthian, 16 years ago

Replying to anonymous:

Was fixed in r565.

Yes I was using an old version. This might sound daft but when I downloaded the file josm-latest.jar I assumed that this was some spooky Java automagical link which would run the latest josm (perhaps by being updated in the background or running over the web in some way). Seems odd that I thought that but why call a file josm-latest.jar when it is clearly not (after a few days). Why not call the file after its version number? josm-587.jar etc. and having the wiki show the latest version number in a promonent place (and also on the openstreetmap wiki front page). As far as I can tell you see the latest on the Change Log link which is fine but a little more prominence wouldn't do any harm (I rarely opened the josm wiki in the past - now I know I need to check frequently).
Cheers
Stuart

PS
The exception has gone and Shift select is fine for lots of deletes. Thanks.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain framm.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.