Modify

Opened 8 years ago

Closed 4 years ago

#6355 closed enhancement (fixed)

Rework menus / place plugin tools in own menu

Reported by: skyper Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: menu tool plugin Cc: stoecker, Don-vip, bastiK, simon04, skyper, joshdoe, Zverikk, akks

Description (last modified by skyper)

Please, place all plugin tools in an own menu.

The core tool list is getting quite long and if you have a small screen it just fits on it but not with several plugins installed.

Maybe merge it with the utils2 menu or have a subcategory within the tool menu

Thanks

r4088

Attachments (8)

testPluginsAllInstall.xml (1.3 KB) - added by akks 6 years ago.
Fast all plugins install script (Advanced - import from file)
plugins_menu.patch (29.8 KB) - added by akks 6 years ago.
core_menu.patch (3.7 KB) - added by akks 6 years ago.
JOSM_menu_rework.png (233.8 KB) - added by akks 6 years ago.
resulting picture
Submenu.png (50.1 KB) - added by akks 6 years ago.
newly added submenu screenshot
piclayer.png (17.8 KB) - added by Don-vip 5 years ago.
2014-08-22_Menu_001.png (104.6 KB) - added by grinapo 5 years ago.
Imagery / Top half
2014-08-22_Menu_003.png (113.4 KB) - added by grinapo 5 years ago.
Imagery / Bottom half

Download all attachments as: .zip

Change History (64)

comment:1 Changed 8 years ago by skyper

Please, guys.

I do not think it is useful if you have to add a new menu within many plugins but better have a methode in Core to catch the menu entries if no own menu is created.

Thanks a lot.

Last edited 8 years ago by skyper (previous) (diff)

comment:2 Changed 7 years ago by skyper

Description: modified (diff)

comment:3 Changed 7 years ago by akks

Yes, moving plugin tools to separate menu can be very convenient, if implemented without extremism)
Maybe some "Data" menu for adresses/importers/reverter and "More tools" for geometric features?

Patching plugins is simple.

Last edited 7 years ago by akks (previous) (diff)

comment:4 Changed 6 years ago by akks

Let us start this dirty job of reworking menus :)

What do we have:

  • Huge Tools menu, many additions from plugins
  • More tools menu - Utilsplugin2-only for now.
  • Some plugins extends File menu (making it huge) and Edit menu
  • There are plugins with tiny menus that takes shortcut and space: PicLayer, Scripting, Publi Transport, Walking Papers, Reverter

What do we need: split Tools+More tools so that new menus will fit on screen without scrolling and be easy to understand.

comment:5 Changed 6 years ago by akks

Propositions:

  1. Tools = the most basic geometric functions (current core menu + some carefully chosen additions from Utilsplugin2 #8864 )
  2. More tools (maybe rename?) = Advanced geometric functions from core and all the plugins, not only Utilsplugin2.

(+ split area, create grid of ways, simplify area, terrace, maybe tracer and lakewalker)

  1. Data menu = all tools (except most separate and advanced like Czech and French cadastre) that works with data: address plugins, wikipedia, reverter, opening hours, Tomb, SeaMap.
  2. Move all "select ..." actions to select menu.
  3. Need to do something with multiple importing and exporting actions (PicLayer, ImportImage and Import PDF could go to Imagery menu, for example)
  4. Maybe put all track&gpx-related actions to some Tracks menu, merging with LiveGPS?

What do you think about it?

Last edited 6 years ago by akks (previous) (diff)

comment:6 Changed 6 years ago by akks

Cc: stoecker Don-vip bastiK simon04 skyper joshdoe Zverikk akks added
Summary: place plugin tools in own menuRework menus / place plugin tools in own menu
Version: latest

comment:7 Changed 6 years ago by AlfonZ

geotools and log4j are missing in testPluginsAllInstall.xml​ (required for cadastre-fr, routing, ImportImagePlugin and videomapping plugins)

comment:8 in reply to:  7 Changed 6 years ago by akks

Replying to AlfonZ:

geotools and log4j are missing in testPluginsAllInstall.xml​ (required for cadastre-fr, routing, ImportImagePlugin and videomapping plugins)

Thank you very much! Replaced the file.

Changed 6 years ago by akks

Attachment: testPluginsAllInstall.xml added

Fast all plugins install script (Advanced - import from file)

comment:9 Changed 6 years ago by Don-vip

An other option could be (I don't know if it would be better or not than yours):

  1. Tools -> Core geometric tools
  2. More Tools -> Plugins geometric tools

For the other points:

  1. OK
  2. OK
  3. All these import/export actions could be reworked to be integrated in the standard "File open" and "File save as"
  4. OK

comment:10 in reply to:  9 Changed 6 years ago by akks

Replying to Don-vip:

An other option could be (I don't know if it would be better or not than yours):

  1. Tools -> Core geometric tools
  2. More Tools -> Plugins geometric tools

Agree, but where should we put Replace Geometry, Add nodes on intersections etc. in Tools if they are included? It is already 18 items in it.
And if we will not create menus (More tools, Data) in core, how the plugins can create them?
Should we add some extra API calls in Main.menu to add element to named menu by menu name?

Last edited 6 years ago by akks (previous) (diff)

comment:11 Changed 6 years ago by akks

I have prepared alpha patch for core and plugins.
All can be changed after discussion, current missing features are josm minimal version for plugins, nice menu accelerators and proper sorting/separating of menus. We also need to do something with help pages of plugins whose menus we delete.

Changed 6 years ago by akks

Attachment: plugins_menu.patch added

Changed 6 years ago by akks

Attachment: core_menu.patch added

comment:12 Changed 6 years ago by akks

Summary: Rework menus / place plugin tools in own menu[alpha PATCH] Rework menus / place plugin tools in own menu

Changed 6 years ago by akks

Attachment: JOSM_menu_rework.png added

resulting picture

comment:13 Changed 6 years ago by Don-vip

Looks very nice :) I won't have much time before next week, feel free to end stabilization soon (r6060 looks very stable) and start to rework these menus :)

comment:14 Changed 6 years ago by skyper

Yeah, big step forward.

One little thing:

  • maybe a general "plugin" menu is still needed (or rename "data" to "data/plugin" and use it for now) to place all the plugins' entries which only deliver some entries which do not fit to the other menus and which do not need an own menu:
    • Tomb
    • go driving
    • download along
    • landwalker
    • set building size
    • edit opening hours
    • OpenData
    • Namemanage
    • opening images with ...
    • SeaMap
    • Michigan Left
    • Wikipedia
  • all address tools should be placed under address ("Fix addresses") not sure about "select incomplete addresses" but probably "selection" fits best.

We need to document the different menus that plugin developers know which menu to use!

comment:15 Changed 6 years ago by skyper

See also #7806

comment:16 Changed 6 years ago by akks

What is the best name for "Data" menu?
Data? More Plugins? Data/Plugin? Plugins?
Is it normal to put group of address-related stuff (2-3 items) into it? (Cadastres should live their own live, I guess)

Is GPS Tracks name OK? (Alt-G accelerator)
Should we keep "More tools" name?

It is time to start committing something :)

Last edited 6 years ago by akks (previous) (diff)

comment:17 Changed 6 years ago by Don-vip

Keep it simple :) "Data" looks ok, and "more tools" is already well known by users, so I think we can keep it. GPS Tracks is ok too.

I think we can allow plugins having a real meanu (with several entries) to have their own (such as cadastre and opendata)

We should also move the preset-tagging-plugin entry from Help to Presets (first entry maybe ?)

comment:18 Changed 6 years ago by akks

Good news :) I'll wait for more opinions until tomorrow and then start committing.

comment:19 in reply to:  16 Changed 6 years ago by bastiK

Replying to akks:

What is the best name for "Data" menu?
Data? More Plugins? Data/Plugin? Plugins?
Is it normal to put group of address-related stuff (2-3 items) into it? (Cadastres should live their own live, I guess)

Is GPS Tracks name OK? (Alt-G accelerator)
Should we keep "More tools" name?

It is time to start committing something :)

Hi akks, I really appreciate what you are doing here, great stuff! It was an interesting experience to install all available plugins with your script. :)

  • +1 for "Data" and "More tools"
  • What about calling it just "GPS" instead of "GPS Tracks"?
  • I like the idea of a "Plugins" main menu, but maybe we can do that as a second step after the current rework is finished?
  • Some plugin menu entries need to be renamed after moving them to another top level menu together with other plugins. E.g. "Walking Papers > Scanned map".

comment:20 Changed 6 years ago by akks

In 6082/josm:

see #6355: add new menus (More Tools, Data, Selection, GPS) to be used by plugins

comment:21 Changed 6 years ago by akks

I have changed GPS Tracks to GPS menus and updated accelerators (will take Alt-M, Alt-N, Alt-D, Alt-G from plugins).

Next step is to change "conflicting" plugins (Utilsplugin2, LiveGPS, Reverter, Videomapping), I'll try not to increase needed version of JOSM but use version checking (to allow fixing bugs for older JOSM version)...

comment:22 Changed 6 years ago by Don-vip

I don't think this is necessary, bumping the required josm version seems fine to me.

comment:23 Changed 6 years ago by akks

I had such problem with FastDraw bug, it is easier to avoid then to explain why the bug was not gone :)

comment:24 Changed 6 years ago by akks

Here it is, in [o29769]

[josm_utilsplugin2. josm_commandline, josm_livegps, josm_reverter, josm_opendata, josm_videomapping]:
rearrange menu items and change menu accelerators, add Netbeans projects, fix some syntax warnings

Other plugins can wait until tomorrow, I guess (maybe some ideas or corrections will come).

comment:25 Changed 6 years ago by stoecker

The version check breaks the shortcut detection. Like Vincent I don't think this is required. JOSM policy is to enforce users to update the core when they want new plugins.

comment:26 in reply to:  25 Changed 6 years ago by rickmastfan67

Replying to stoecker:

The version check breaks the shortcut detection. Like Vincent I don't think this is required. JOSM policy is to enforce users to update the core when they want new plugins.

It has also broken the reverter plugin in [6081]. See: #8900.

comment:27 Changed 6 years ago by akks

OK, I an removing version check and fxing the bug.

comment:28 Changed 6 years ago by akks

josm.main versions are bumbed to 6082, more plugins moved (~18 left). That's all for today from me...

comment:29 Changed 6 years ago by Don-vip

Thanks a lot akks ! :)

comment:30 Changed 6 years ago by akks

I have patched most of the other plugins (see [o29778]). Remaining ones (that should be potentially moved) are

  • Piclayer (where to move it?)
  • ImageWaypoint (where to move it?)
  • ImportImage (where to move it?)
  • pdfimport (where to move it?)
  • Tomb (external repository)
  • ContinuousDownload (leave as is, I guess)
  • undelete (to Data near Reverter?)
  • routing, public transport, Scripting (leave as is?)
  • mirrored_download (File menu items seems OK, but not configuration in edit menu...)

Feel free to improve the menus or give advice!

Last edited 6 years ago by akks (previous) (diff)

comment:31 in reply to:  30 ; Changed 6 years ago by rickmastfan67

Replying to akks:

  • undelete (to Data near Reverter?)

I think the location for this one is perfect as is. It's right near the "download object". People would except the "un-delete object" to be in the same area.

comment:32 in reply to:  31 Changed 6 years ago by akks

Replying to rickmastfan67:

Replying to akks:

  • undelete (to Data near Reverter?)

I think the location for this one is perfect as is. It's right near the "download object". People would except the "un-delete object" to be in the same area.

I think you are right. Maybe reverter shoud go there too? But File menu is too big for now...

comment:33 Changed 6 years ago by skyper

The "windows" menu does not proper work anymore with r6090. It only contains the changeset manager but no other entries. Did not test with other versions.

comment:34 in reply to:  33 ; Changed 6 years ago by akks

Replying to skyper:

The "windows" menu does not proper work anymore with r6090. It only contains the changeset manager but no other entries. Did not test with other versions.

Strange, I can not reproduce (It is usually empty when map frame is not opened)...

comment:35 in reply to:  34 ; Changed 6 years ago by skyper

Replying to akks:

Replying to skyper:

The "windows" menu does not proper work anymore with r6090. It only contains the changeset manager but no other entries. Did not test with other versions.

Strange, I can not reproduce (It is usually empty when map frame is not opened)...

Strange, I can not either today on a different machine.

comment:36 in reply to:  9 Changed 6 years ago by akks

Replying to Don-vip:

  1. All these import/export actions could be reworked to be integrated in the standard "File open" and "File save as"

I have just moved "importvec" and "ImageWayPoint" plugins to the File Open menu/ Can someone who use them (or who is amiliar with FileImporter stuff) check that they work correctly?
Freeing hotkeys is good for JOSM :)

comment:37 Changed 6 years ago by akks

Removed ImportImage from menu, moved Import PDF to Data menu (is can not be asily changed to fileImporter).
WalkingPaper downloads URL, not file, so it remains in Imagery menu.

comment:38 in reply to:  37 Changed 6 years ago by skyper

Replying to akks:

Removed ImportImage from menu, moved Import PDF to Data menu (is can not be asily changed to fileImporter).
WalkingPaper downloads URL, not file, so it remains in Imagery menu.

WalkingPaper is depricated anyway. The replacement is "fieldpaper".

comment:39 Changed 6 years ago by akks

In 6097/josm:

see #6355: move Rectified Image and plugin imagery layers to Imagery/More... submenu
(last part of menu rework)

comment:40 Changed 6 years ago by akks

Summary: [alpha PATCH] Rework menus / place plugin tools in own menuRework menus / place plugin tools in own menu

The imagery layer plugins are moved to Imagery/More submenu (PicLayer, WalikingPaper, ImportImage (+File/Open works), PDFImport), [o29805].

I guess, menu rework is over for now?

Changed 6 years ago by akks

Attachment: Submenu.png added

newly added submenu screenshot

comment:41 Changed 6 years ago by akks

(Piclayer disabled menu item was fixed after getting screenshot)

comment:42 in reply to:  41 Changed 6 years ago by skyper

Replying to akks:

(Piclayer disabled menu item was fixed after getting screenshot)

  • Is the submenu really needed ?
  • Is it possible to only have it used with some (three+) entries ?
    • a submenu for only one entry is useless !!

comment:43 Changed 6 years ago by akks

When many plugins are installed, submenu is needed (there could be many imagery layers loo). It also separates "advanced" part.

Though, Imagery menu is dynamic and it is very easy to "inline" submenu if there are <3 items in it, for example. I can do this if it will not be confusing.

Last edited 6 years ago by akks (previous) (diff)

comment:44 in reply to:  43 Changed 6 years ago by skyper

Replying to akks:

When many plugins are installed, submenu is needed (there could be many imagery layers loo). It also separates "advanced" part.

Though, Imagery menu is dynamic and it is very easy to "inline" submenu if there are <3 items in it, for example.

We should never have a submenu with only one entry and I would be annoyed to find piclayer for example that deep in the menu as one reason, to use it, is that there are not many imagery sources for the region.

Maybe have dynamic menu all the way and only use a submenu when needed.

I can do this if it will not be confusing.

Doesn't "more" say enough ?

comment:45 Changed 6 years ago by akks

We can add second entry to submenu: configuration, for example.

Or we can keep menu unrolled if total items count is not too high. Will this be better?
I already had complains from people whose Imagery menu does not fit on screen.
BTW, PicLayer will be supported by file/open too.

Last edited 6 years ago by akks (previous) (diff)

comment:46 in reply to:  45 ; Changed 6 years ago by skyper

Replying to akks:

We can add second entry to submenu: configuration, for example.

Or we can keep menu unrolled if total items count is not too high. Will this be better?

+1

I already had complains from people whose Imagery menu does not fit on screen.

I do understand this but it is related to the problem when scrolling.

BTW, PicLayer will be supported by file/open too.

Then we do not need a duplicate at this place at all.

comment:47 Changed 6 years ago by akks

In 6098/josm:

see #6355: do not create "Imagery/More" submenu if there is enough space on screen

comment:48 in reply to:  46 Changed 6 years ago by akks

Replying to skyper:

BTW, PicLayer will be supported by file/open too.

Then we do not need a duplicate at this place at all.

It has also "layer from clipboard", so removing one and leaving another item seems strange.

comment:49 Changed 6 years ago by akks

comment:50 in reply to:  35 Changed 6 years ago by skyper

Replying to skyper:

Replying to akks:

Replying to skyper:

The "windows" menu does not proper work anymore with r6090. It only contains the changeset manager but no other entries. Did not test with other versions.

Strange, I can not reproduce (It is usually empty when map frame is not opened)...

Strange, I can not either today on a different machine.

I had the same issue again on a third machine. I had an data layer open but still only the changeset manager under "windows". Have to recheck but it was the first data layer (empty) and the first time I did open this menu.

comment:51 Changed 5 years ago by grinapo

Okay, #10397 sent me here but I fail to see where PicLayer menu should have gone. File>>Open doesn't seem to open a piclayer, no IMagery>>More menu, no PicLayer menu, so where is it? Apart from patching up from menu tree onto toolbar. :-(

Changed 5 years ago by Don-vip

Attachment: piclayer.png added

comment:52 Changed 5 years ago by Don-vip

Just here: as said in comment 47 the "more" submenu is not created if there's enough room to display plugin entries:


Last edited 5 years ago by Don-vip (previous) (diff)

Changed 5 years ago by grinapo

Attachment: 2014-08-22_Menu_001.png added

Imagery / Top half

Changed 5 years ago by grinapo

Attachment: 2014-08-22_Menu_003.png added

Imagery / Bottom half

comment:53 Changed 5 years ago by grinapo

This is not the way I observe it: I have plenty of entries and neither More nor PicLayer.
Imagery / Top halfImagery / Bottom half

Version 7435
Last change at 2014-08-20 03:12:52 +0200 (Wed, 20 Aug 2014)
Java Version 1.7.0_55
Other data in #10397

Last edited 5 years ago by grinapo (previous) (diff)

comment:54 Changed 5 years ago by Don-vip

ok that's effectively a bug, I'm reopening #10397.

comment:55 Changed 4 years ago by skyper

Think we can close this ticket or is there anything left to do ?

comment:56 Changed 4 years ago by grinapo

Resolution: fixed
Status: newclosed

piclayer bug is fixed, skyper seems happy, I take the courtesy to close. :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.