[Patch] Add points to segments directly from extrude mode

[olejorgenb]

When making non-rectangular buildings I've found the building plugin combined with extrude mode very useful. It's a bit annoying to have to switch between draw mode and extrude mode so often though.

This patch extends extrude mode to add nodes by alt-clicking.

Example:

Here one need to change to draw mode, add the first node, press esc to avoid adding a way, add the next node, change back to extrude mode and make the extrusion

With this patch the same operation become (when in extrude mode): alt-click to add the nodes, make the extrusion.

Personally I'd prefer simply have a single click add a node, but this might be to radical?

[stoecker]

There should be a visual indication that "ALT" changes behaviour. Please add a different pointer in this case. Otherwise it is a good idea I think.

P.S. In "Add mode" you can double click to create a node. No need for ESC.

[Hojoe]

Why not use the double click in the extrude mode? It is more consistent and I can use the 'ALT' for an append mode to add a new rectangle instead of changing the existing rectangle (​http://www.mail-archive.com/talk-de@openstreetmap.org/msg81990.html). With the double click there is no need for a new pointer.

[Hojoe]

Here's my proposal. With the Alt modifier and a double click nodes can be added. Alt and mouse drag creates a new rectangle. This patch uses code from the first patch.

[Hojoe]

... and the cursor

[olejorgenb]

That's great! I got sick of drawing buildings, so my interest kinda subsided :)

I'd say:

1. Node creation directly from the mode isn't actually that important/useful (You can hold shift in draw-mode to create single nodes too)
2. The current patch for node creation doesn't handle multiple ways properly. (only one way get the new node)
3. The "new rectangle" seems really useful

Given the above, I vote for including the new rectangle part and postpone/toss away the node part. (Until 2 get fixed at least. I will not do that myself).

If the node part end up being included I don't see why Alt should be required for the double click though?

[Hojoe]

the creat_new mode without the 'add node' code

[stoecker]

In [4142/josm]:

fix #6323 - patch by olejorgenb and Hojoe (modified and bug fixed by me) - add new node and new segment creation to extrude mode

[stoecker]

Changed: double click is now effective without ALT modifier.

Could someone please update [Help/Action/Extrude]. The new stuff is missing and it seems also some older stuff.

As said, the node creation should affect all ways. This is an future improvement.