Modify

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#6323 closed enhancement (fixed)

[Patch] Add points to segments directly from extrude mode

Reported by: olejorgenb Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: extrude mode, building, area Cc: Hojoe

Description

When making non-rectangular buildings I've found the building plugin combined with extrude mode very useful. It's a bit annoying to have to switch between draw mode and extrude mode so often though.

This patch extends extrude mode to add nodes by alt-clicking.

Example:

http://folk.ntnu.no/bronner/temp/building-extrude-01.png

Here one need to change to draw mode, add the first node, press esc to avoid adding a way, add the next node, change back to extrude mode and make the extrusion

With this patch the same operation become (when in extrude mode): alt-click to add the nodes, make the extrusion.

Personally I'd prefer simply have a single click add a node, but this might be to radical?

Attachments (4)

extrude-add-point.patch (3.7 KB) - added by olejorgenb 9 years ago.
create_new_mode_6323.patch (8.6 KB) - added by Hojoe 9 years ago.
Here's my proposal. With the Alt modifier and a double click nodes can be added. Alt and mouse drag creates a new rectangle. This patch uses code from the first patch.
rectangle_plus.png (221 bytes) - added by Hojoe 9 years ago.
... and the cursor
create_new_mode_2_6323.patch (7.5 KB) - added by Hojoe 9 years ago.
the creat_new mode without the 'add node' code

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by olejorgenb

Attachment: extrude-add-point.patch added

comment:1 Changed 9 years ago by stoecker

There should be a visual indication that "ALT" changes behaviour. Please add a different pointer in this case. Otherwise it is a good idea I think.

P.S. In "Add mode" you can double click to create a node. No need for ESC.

comment:2 Changed 9 years ago by Hojoe

Why not use the double click in the extrude mode? It is more consistent and I can use the 'ALT' for an append mode to add a new rectangle instead of changing the existing rectangle (http://www.mail-archive.com/talk-de@openstreetmap.org/msg81990.html). With the double click there is no need for a new pointer.

comment:3 Changed 9 years ago by stoecker

Summary: [Patch] Add points to segments directly from extrude mode[Patch needs rework] Add points to segments directly from extrude mode

Changed 9 years ago by Hojoe

Attachment: create_new_mode_6323.patch added

Here's my proposal. With the Alt modifier and a double click nodes can be added. Alt and mouse drag creates a new rectangle. This patch uses code from the first patch.

Changed 9 years ago by Hojoe

Attachment: rectangle_plus.png added

... and the cursor

comment:4 Changed 9 years ago by Hojoe

Cc: Hojoe added
Summary: [Patch needs rework] Add points to segments directly from extrude mode[Patch] Add points to segments directly from extrude mode

comment:5 Changed 9 years ago by olejorgenb

That's great! I got sick of drawing buildings, so my interest kinda subsided :)

I'd say:

  1. Node creation directly from the mode isn't actually that important/useful (You can hold shift in draw-mode to create single nodes too)
  2. The current patch for node creation doesn't handle multiple ways properly. (only one way get the new node)
  3. The "new rectangle" seems really useful

Given the above, I vote for including the new rectangle part and postpone/toss away the node part. (Until 2 get fixed at least. I will not do that myself).

If the node part end up being included I don't see why Alt should be required for the double click though?

Changed 9 years ago by Hojoe

the creat_new mode without the 'add node' code

comment:6 Changed 8 years ago by stoecker

Resolution: fixed
Status: newclosed

In [4142/josm]:

fix #6323 - patch by olejorgenb and Hojoe (modified and bug fixed by me) - add new node and new segment creation to extrude mode

comment:7 Changed 8 years ago by stoecker

Changed: double click is now effective without ALT modifier.

Could someone please update [Help/Action/Extrude]. The new stuff is missing and it seems also some older stuff.

As said, the node creation should affect all ways. This is an future improvement.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.